[Bug regression/34970] New: name mangling broken for __attributte__((fastcall))

[Bug regression/34970] New: name mangling broken for __attributte__((fastcall))

[Christoph_vW at reactos dot org]

BOOL FASTCALL DdHmgDestroy();

 .def   _@DdHmgDestroy@0;       .scl    2;      .type   32;     .endef

 "Cannot export @DdHmgDestroy@0: symbol not found"


-- 
           Summary: name mangling broken for __attributte__((fastcall))
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: regression
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: Christoph_vW at reactos dot org
 GCC build triplet: 4.3.0 20080118
  GCC host triplet: linux x86_64
GCC target triplet: mingw32


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug regression/34970] name mangling broken for __attributte__((fastcall))

[Christoph_vW at reactos dot org]

------- Comment #1 from Christoph_vW at reactos dot org  2008-01-25 09:45 -------
Created an attachment (id=15021)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15021&action=view)
assembly


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug regression/34970] name mangling broken for __attributte__((fastcall))

[Christoph_vW at reactos dot org]

------- Comment #2 from Christoph_vW at reactos dot org  2008-01-25 09:46 -------
updated "known to work"


-- 

Christoph_vW at reactos dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug regression/34970] name mangling broken for __attributte__((fastcall))

[Christoph_vW at reactos dot org]

------- Comment #3 from Christoph_vW at reactos dot org  2008-01-25 09:53 -------
Created an attachment (id=15022)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15022&action=view)
preprocessed source


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug regression/34970] name mangling broken for __attributte__((fastcall))

[Christoph_vW at reactos dot org]

------- Comment #4 from Christoph_vW at reactos dot org  2008-01-25 10:10 -------
void __attribute__ ((fastcall)) test();

int main()
{
  test();
  return 0;
}

void __attribute__ ((fastcall)) test()
{
  return;
}



Results in .s file :

gcc 4.3.0  _@test@0
gcc 4.1.3  @test@0


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug regression/34970] name mangling broken for __attributte__((fastcall))

[Christoph_vW at reactos dot org]

------- Comment #5 from Christoph_vW at reactos dot org  2008-01-25 10:17 -------
build steps

mingw32-gcc -c drivers/directx/dxg/main.c -o
obj-i386/drivers/directx/dxg/main_dxg.o -Idrivers/directx/dxg -D__USE_W32API
-mpreferred-stack-boundary=2 -Wno-strict-aliasing -Wpointer-arith -I. -Iinclude
-Iobj-i386/include -Iinclude/psdk -Iobj-i386/include/psdk -Iinclude/dxsdk
-Iinclude/crt -Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL -Iinclude/ndk
-Iinclude/reactos -Iobj-i386/include/reactos -Iinclude/reactos/libs
-D__REACTOS__ -D_M_IX86 -D_X86_ -D__i386__ -DDBG=1 -D_SEH_ENABLE_TRACE -DKDBG=1
-Os -ftracer -momit-leaf-frame-pointer -I. -Iinclude -Iobj-i386/include
-Iinclude/psdk -Iobj-i386/include/psdk -Iinclude/dxsdk -Iinclude/crt
-Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL -Iinclude/ndk
-Iinclude/reactos -Iobj-i386/include/reactos -Iinclude/reactos/libs -Wall
-march=pentium -mpreferred-stack-boundary=2 -Wno-strict-aliasing
-Wpointer-arith -Os -ftracer -momit-leaf-frame-pointer -g -pipe -Werror
-nostdinc -fno-optimize-sibling-calls -D__NTDRIVER__
mingw32-gcc -c drivers/directx/dxg/ddhmg.c -o
obj-i386/drivers/directx/dxg/ddhmg_dxg.o -Idrivers/directx/dxg -D__USE_W32API
-mpreferred-stack-boundary=2 -Wno-strict-aliasing -Wpointer-arith -I. -Iinclude
-Iobj-i386/include -Iinclude/psdk -Iobj-i386/include/psdk -Iinclude/dxsdk
-Iinclude/crt -Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL -Iinclude/ndk
-Iinclude/reactos -Iobj-i386/include/reactos -Iinclude/reactos/libs
-D__REACTOS__ -D_M_IX86 -D_X86_ -D__i386__ -DDBG=1 -D_SEH_ENABLE_TRACE -DKDBG=1
-Os -ftracer -momit-leaf-frame-pointer -I. -Iinclude -Iobj-i386/include
-Iinclude/psdk -Iobj-i386/include/psdk -Iinclude/dxsdk -Iinclude/crt
-Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL -Iinclude/ndk
-Iinclude/reactos -Iobj-i386/include/reactos -Iinclude/reactos/libs -Wall
-march=pentium -mpreferred-stack-boundary=2 -Wno-strict-aliasing
-Wpointer-arith -Os -ftracer -momit-leaf-frame-pointer -g -pipe -Werror
-nostdinc -fno-optimize-sibling-calls -D__NTDRIVER__
mingw32-gcc -c drivers/directx/dxg/eng.c -o
obj-i386/drivers/directx/dxg/eng_dxg.o -Idrivers/directx/dxg -D__USE_W32API
-mpreferred-stack-boundary=2 -Wno-strict-aliasing -Wpointer-arith -I. -Iinclude
-Iobj-i386/include -Iinclude/psdk -Iobj-i386/include/psdk -Iinclude/dxsdk
-Iinclude/crt -Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL -Iinclude/ndk
-Iinclude/reactos -Iobj-i386/include/reactos -Iinclude/reactos/libs
-D__REACTOS__ -D_M_IX86 -D_X86_ -D__i386__ -DDBG=1 -D_SEH_ENABLE_TRACE -DKDBG=1
-Os -ftracer -momit-leaf-frame-pointer -I. -Iinclude -Iobj-i386/include
-Iinclude/psdk -Iobj-i386/include/psdk -Iinclude/dxsdk -Iinclude/crt
-Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL -Iinclude/ndk
-Iinclude/reactos -Iobj-i386/include/reactos -Iinclude/reactos/libs -Wall
-march=pentium -mpreferred-stack-boundary=2 -Wno-strict-aliasing
-Wpointer-arith -Os -ftracer -momit-leaf-frame-pointer -g -pipe -Werror
-nostdinc -fno-optimize-sibling-calls -D__NTDRIVER__
mingw32-gcc -c drivers/directx/dxg/historic.c -o
obj-i386/drivers/directx/dxg/historic_dxg.o -Idrivers/directx/dxg
-D__USE_W32API -mpreferred-stack-boundary=2 -Wno-strict-aliasing
-Wpointer-arith -I. -Iinclude -Iobj-i386/include -Iinclude/psdk
-Iobj-i386/include/psdk -Iinclude/dxsdk -Iinclude/crt -Iinclude/crt/mingw32
-Iinclude/ddk -Iinclude/GL -Iinclude/ndk -Iinclude/reactos
-Iobj-i386/include/reactos -Iinclude/reactos/libs -D__REACTOS__ -D_M_IX86
-D_X86_ -D__i386__ -DDBG=1 -D_SEH_ENABLE_TRACE -DKDBG=1 -Os -ftracer
-momit-leaf-frame-pointer -I. -Iinclude -Iobj-i386/include -Iinclude/psdk
-Iobj-i386/include/psdk -Iinclude/dxsdk -Iinclude/crt -Iinclude/crt/mingw32
-Iinclude/ddk -Iinclude/GL -Iinclude/ndk -Iinclude/reactos
-Iobj-i386/include/reactos -Iinclude/reactos/libs -Wall -march=pentium
-mpreferred-stack-boundary=2 -Wno-strict-aliasing -Wpointer-arith -Os -ftracer
-momit-leaf-frame-pointer -g -pipe -Werror -nostdinc
-fno-optimize-sibling-calls -D__NTDRIVER__
mingw32-gcc -xc -E -DRC_INVOKED -Idrivers/directx/dxg -D__USE_W32API -I.
-Iinclude -Iobj-i386/include -Iinclude/psdk -Iobj-i386/include/psdk
-Iinclude/dxsdk -Iinclude/crt -Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL
-Iinclude/ndk -Iinclude/reactos -Iobj-i386/include/reactos
-Iinclude/reactos/libs -D__REACTOS__ -D_M_IX86 -D_X86_ -D__i386__ -DDBG=1
-D_SEH_ENABLE_TRACE -DKDBG=1 -I. -Iinclude -Iobj-i386/include -Iinclude/psdk
-Iobj-i386/include/psdk -Iinclude/dxsdk -Iinclude/crt -Iinclude/crt/mingw32
-Iinclude/ddk -Iinclude/GL -Iinclude/ndk -Iinclude/reactos
-Iobj-i386/include/reactos -Iinclude/reactos/libs -D__REACTOS__ -D_M_IX86
-D_X86_ -D__i386__ -DDBG=1 -D_SEH_ENABLE_TRACE -DKDBG=1
drivers/directx/dxg/dxg.rc > ./dxg.dxg.rci.tmp
output-i386/tools/wrc/wrc -Idrivers/directx/dxg -D__USE_W32API -I. -Iinclude
-Iobj-i386/include -Iinclude/psdk -Iobj-i386/include/psdk -Iinclude/dxsdk
-Iinclude/crt -Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL -Iinclude/ndk
-Iinclude/reactos -Iobj-i386/include/reactos -Iinclude/reactos/libs
-D__REACTOS__ -D_M_IX86 -D_X86_ -D__i386__ -DDBG=1 -D_SEH_ENABLE_TRACE -DKDBG=1
-I. -Iinclude -Iobj-i386/include -Iinclude/psdk -Iobj-i386/include/psdk
-Iinclude/dxsdk -Iinclude/crt -Iinclude/crt/mingw32 -Iinclude/ddk -Iinclude/GL
-Iinclude/ndk -Iinclude/reactos -Iobj-i386/include/reactos
-Iinclude/reactos/libs -D__REACTOS__ -D_M_IX86 -D_X86_ -D__i386__ -DDBG=1
-D_SEH_ENABLE_TRACE -DKDBG=1 ./dxg.dxg.rci.tmp ./dxg.dxg.res.tmp
mingw32-windres ./dxg.dxg.res.tmp -o obj-i386/drivers/directx/dxg/dxg_dxg.coff
mingw32-dlltool --dllname dxg.sys --def drivers/directx/dxg/dxg.def
--output-exp ./dxg.temp.exp --kill-at 
mingw32-gcc -Wl,--subsystem,native -Wl,--entry,_DriverEntry@8
-Wl,--image-base,0x00010000 -Wl,--file-alignment,0x1000
-Wl,--section-alignment,0x1000 -nostartfiles -shared  ./dxg.temp.exp -o
output-i386/drivers/directx/dxg/dxg.sys obj-i386/drivers/directx/dxg/main_dxg.o
obj-i386/drivers/directx/dxg/ddhmg_dxg.o obj-i386/drivers/directx/dxg/eng_dxg.o
obj-i386/drivers/directx/dxg/historic_dxg.o
obj-i386/drivers/directx/dxg/dxg_dxg.coff
obj-i386/drivers/directx/dxgthk/libdxgthk.a obj-i386/ntoskrnl/libntoskrnl.a
obj-i386/lib/debugsup/debugsup_ntoskrnl.a -enable-stdcall-fixup -g
-nostartfiles -nostdlib


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug target/34970] name mangling broken for __attributte__((fastcall))

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2008-01-25 11:03 -------
It's there:

Ltext0:
.globl _@DdHmgDestroy@0
        .def    _@DdHmgDestroy@0;       .scl    2;      .type   32;     .endef
_@DdHmgDestroy@0:

so can you be more elaborate on what is wrong?  It looks like an assembler
problem instead?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|regression                  |target


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug target/34970] name mangling broken for __attributte__((fastcall))

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug target/34970] name mangling broken for __attributte__((fastcall))

[dannysmith at users dot sourceforge dot net]

------- Comment #7 from dannysmith at users dot sourceforge dot net  2008-01-26 00:58 -------
Confirmed.  Fastcall symbols should not be prefixed with USER_LABEL_PREFIX.
This bug was introduced with 

2007-03-29  Richard Henderson  <rth@redhat.com>
<snip>
        * config/i386/cygming.h: Remove function declarations.
        (SUBTARGET_ENCODE_SECTION_INFO): Don't undef first.
        (ASM_OUTPUT_LABELREF): Remove.
        ...

Testing a patch that adds ASM_OUTPUT_LABELREF define back to cygming.h

Danny


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dannysmith at users dot
                   |dot org                     |sourceforge dot net
             Status|WAITING                     |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-01-26 00:58:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug target/34970] [4.3 regression] name mangling broken for __attributte__((fastcall))

[dannysmith at users dot sourceforge dot net]

------- Comment #8 from dannysmith at users dot sourceforge dot net  2008-01-26 07:17 -------
This is a 4.3.0  regression.


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.3.0
      Known to work|4.1.3                       |4.1.3 4.2.1
            Summary|name mangling broken for    |[4.3 regression] name
                   |__attributte__((fastcall))  |mangling broken for
                   |                            |__attributte__((fastcall))
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug target/34970] [4.3 regression] name mangling broken for __attributte__((fastcall))

[dannysmith at users dot sourceforge dot net]

------- Comment #10 from dannysmith at users dot sourceforge dot net  2008-01-26 09:41 -------
Fixed.


-- 

dannysmith at users dot sourceforge dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970

[Bug target/34970] [4.3 regression] name mangling broken for __attributte__((fastcall))

[dannysmith at gcc dot gnu dot org]

------- Comment #9 from dannysmith at gcc dot gnu dot org  2008-01-26 09:32 -------
Subject: Bug 34970

Author: dannysmith
Date: Sat Jan 26 09:31:30 2008
New Revision: 131859

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131859
Log:
PR target/34970

gcc
        * config/i386/cygming.h (ASM_OUTPUT_LABELREF): Define.
testsuite
        * gcc.target/i386/fastcall-1.c: Scan for correct label.
        Use -std=gnu89 switch. 




Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/cygming.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/fastcall-1.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34970