public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/34969] [4.3 regression] ICE with -fipa-cp -ffast-math
Date: Mon, 28 Jan 2008 21:48:00 -0000	[thread overview]
Message-ID: <20080128205140.27422.qmail@sourceware.org> (raw)
In-Reply-To: <bug-34969-1771@http.gcc.gnu.org/bugzilla/>



------- Comment #6 from hubicka at ucw dot cz  2008-01-28 20:51 -------
Subject: Re:  [4.3 regression] ICE with -fipa-cp -ffast-math

> No, I mean providing something like cgraph_update_edges_for_call_stmt (tree
> old, tree new); or alternatively cgraph_remove_edge_from_call_stmt () and
> cgraph_add_edge_from_call_stmt () and call those two unconditionally.

My stragegy so far was to rebuild cgraph edges from scratch when needed
(that is something possibly changed).  We can probably handle that via
function local TODO flag here too.

Updating the edges across multiple passes is kind of sliperly, since we
would need to tie cgraph a lot more with gimple, pretty much as we do
for CFG.  This seems too much pie in the sky project with current
organization of trees and folders, I hope that with tuples we will have
a lot closer correspondence in between actual statements and calls here.

Since we need to have edges up to date across inliner, I guess the patch
is fine (as would be addint the TODO flag).  Thanks for looking into it!

Honza


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34969


  parent reply	other threads:[~2008-01-28 20:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-25  8:53 [Bug middle-end/34969] New: " reichelt at gcc dot gnu dot org
2008-01-25  9:03 ` [Bug middle-end/34969] " reichelt at gcc dot gnu dot org
2008-01-25 10:26 ` rguenth at gcc dot gnu dot org
2008-01-28  9:17 ` jakub at gcc dot gnu dot org
2008-01-28 10:10 ` jakub at gcc dot gnu dot org
2008-01-28 12:35 ` rguenth at gcc dot gnu dot org
2008-01-28 13:44 ` jakub at gcc dot gnu dot org
2008-01-28 13:44 ` rguenth at gcc dot gnu dot org
2008-01-28 21:48 ` hubicka at ucw dot cz [this message]
2008-01-30  0:03 ` jakub at gcc dot gnu dot org
2008-01-30  0:07 ` jakub at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080128205140.27422.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).