[Bug fortran/35015] New: missing cleanup-modules directive in testsuite/gfortran*

[Bug fortran/35015] New: missing cleanup-modules directive in testsuite/gfortran*

[aldot at gcc dot gnu dot org]

$ wget -P gcc/contrib/ \
http://uclibc.org/~aldot/gcc/gfortran.dg-final.cleanup-mods.awk
$ chmod +x gcc/contrib/gfortran.dg-final.cleanup-mods.awk
$ cd gcc/testsuite
$ $ for i in $(grep --exclude='*.svn*' -rl dg-do gfortran*); do
../contrib/gfortran.dg-final.cleanup-mods.awk $i;done 2> /dev/null

This scripts emits on stdout a diagnostic message about
a) wrong encoding in testcases (CRLF)
b) missing cleanup-module directives

On stderr, this scripts emits sed scripts to automagically
a) fix the wrong encoding
b) add missing cleanup-module directives.

I put it into public domain, but this can be changes if required.
IMHO it would be handy to have this script in gcc/contrib


-- 
           Summary: missing cleanup-modules directive in testsuite/gfortran*
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: aldot at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[burnus at gcc dot gnu dot org]

------- Comment #1 from burnus at gcc dot gnu dot org  2008-01-29 15:36 -------
> This scripts emits on stdout a diagnostic message about
> a) wrong encoding in testcases (CRLF)

I think it is OK to mix \n and \r\n in the test suite as both should work. In
principle "\r" (old Mac files) should work as well, but seemingly no one has
requested this (-> currently unimplemented).
Thus I strongly advice against having only "\n" files.

> b) add missing cleanup-module directives.
> $ for i in $(grep --exclude='*.svn*' -rl dg-do gfortran*); do
> ../contrib/gfortran.dg-final.cleanup-mods.awk $i;done 2> /dev/null

This will find also those which are "dg-do compile" where no .mod is produced
("dg-error" in MODULE) and misses those which do not contain "dg-do compile" as
this is the default value.

But in any case the script is useful.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[aldot at gcc dot gnu dot org]

------- Comment #2 from aldot at gcc dot gnu dot org  2008-01-29 16:05 -------
You can pass any *.[fF][9]*[05]* and .inc into this script, it will happily
scan for any un-cleaned mod. See top of the script for the files i initially
fed to it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[burnus at gcc dot gnu dot org]

------- Comment #3 from burnus at gcc dot gnu dot org  2008-01-29 20:15 -------
> You can pass any *.[fF][9]*[05]* and .inc into this script, it will happily
> scan for any un-cleaned mod. See top of the script for the files i initially
> fed to it.

Most (all?) .mod files which are left over come currently from
gfortran.fortran-torture/, where dg-cleanup cannot be used.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[rep dot dot dot nop at gmail dot com]

------- Comment #4 from rep dot dot dot nop at gmail dot com  2008-01-29 20:23 -------
Subject: Re:  missing cleanup-modules directive in
        testsuite/gfortran*

On Tue, Jan 29, 2008 at 08:15:23PM -0000, burnus at gcc dot gnu dot org wrote:
>------- Comment #3 from burnus at gcc dot gnu dot org  2008-01-29 20:15 -------
>> You can pass any *.[fF][9]*[05]* and .inc into this script, it will happily
>> scan for any un-cleaned mod. See top of the script for the files i initially
>> fed to it.
>
>Most (all?) .mod files which are left over come currently from
>gfortran.fortran-torture/, where dg-cleanup cannot be used.

Fair enough. We should thus apply the script to gcc/contrib/ (ok for
adding it?) and consequently close this as fixed.
thanks,


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[aldot at gcc dot gnu dot org]

------- Comment #5 from aldot at gcc dot gnu dot org  2008-01-29 20:35 -------
Several question marks for someone more familiar with the testsuite..

In the event that we can check against several multilib variants (?) that thus
match different dg-require (?), we may (?) eventually check against stale
module data if a "board" does not cleanup-modules after itself and each board
is run in the same directory (where an old multilib-run may have left old
output/modules), no?

If there is a risk that we run into stale data, then board variants, however
they may be established, have to cleanup after themselves to prevent wrong
positives.
Janis, all, is this something that we can run into and should be concerned
about or is it impossible that this szenario triggers, ever?


-- 

aldot at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janis at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[fxcoudert at gcc dot gnu dot org]

------- Comment #6 from fxcoudert at gcc dot gnu dot org  2008-02-03 14:34 -------
(In reply to comment #5)
> In the event that we can check against several multilib variants (?) that thus
> match different dg-require (?), we may (?) eventually check against stale
> module data if a "board" does not cleanup-modules after itself and each board
> is run in the same directory (where an old multilib-run may have left old
> output/modules), no?

I don't think so, since each a newer version of the module file is written
every time before being read. It still would be nice to have to way to support
a cleanup directive in the gfortran.fortran-torture/ directory.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-03 14:34:44
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[dfranke at gcc dot gnu dot org]

------- Comment #7 from dfranke at gcc dot gnu dot org  2009-01-03 22:48 -------
(In reply to comment #4)
> Fair enough. We should thus apply the script to gcc/contrib/ (ok for
> adding it?) and consequently close this as fixed.
> thanks,

Hasn't been added yet. I think it's still useful. 
Please add.

Before closing, a note to the ML would be nice, so people know that it's
available and how to use it - thanks! :)


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |burnus at gcc dot gnu.org
         Resolution|                            |FIXED

--- Comment #9 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-06-01 12:43:30 UTC ---
As by default the .mod files of the modules in a test-suite file are removed, I
think this PR can be CLOSED. I did so now.

[Bug fortran/35015] missing cleanup-modules directive in testsuite/gfortran*

[aldot at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35015

Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2012-03/msg00080.htm
                   |                            |l

--- Comment #8 from Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> 2012-03-02 07:57:14 UTC ---
Alternative approach; Handle cleanup-modules in the testsuite implicitly