public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dave at hiauly1 dot hia dot nrc dot ca" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/34627] Incorrect branching with -Ox on hppa
Date: Sun, 03 Feb 2008 21:46:00 -0000 [thread overview]
Message-ID: <20080203214614.20416.qmail@sourceware.org> (raw)
In-Reply-To: <bug-34627-7657@http.gcc.gnu.org/bugzilla/>
------- Comment #15 from dave at hiauly1 dot hia dot nrc dot ca 2008-02-03 21:46 -------
Subject: Re: Incorrect branching with -Ox on hppa
> Instead of const0_rtx, I probably should have used CONST0_RTX(mode) ...
I've tried Steven's change on hppa2.0w-hp-hpux11.11 and can confirm
that it resolves the testsuite problem with head. I've got full
bootstraps running on 4.2 and head with the following change.
Index: combine.c
===================================================================
--- combine.c (revision 132077)
+++ combine.c (working copy)
@@ -5393,9 +5393,10 @@
/* Look for cases where we have (abs x) or (neg (abs X)). */
if (GET_MODE_CLASS (mode) == MODE_INT
+ && comparison_p
+ && XEXP (cond, 1) == CONST0_RTX (mode)
&& GET_CODE (false_rtx) == NEG
&& rtx_equal_p (true_rtx, XEXP (false_rtx, 0))
- && comparison_p
&& rtx_equal_p (true_rtx, XEXP (cond, 0))
&& ! side_effects_p (true_rtx))
switch (true_code)
Dave
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34627
next prev parent reply other threads:[~2008-02-03 21:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-34627-7657@http.gcc.gnu.org/bugzilla/>
2008-01-01 17:27 ` rguenth at gcc dot gnu dot org
2008-02-03 11:40 ` steven at gcc dot gnu dot org
2008-02-03 12:06 ` steven at gcc dot gnu dot org
2008-02-03 12:27 ` steven at gcc dot gnu dot org
2008-02-03 12:55 ` steven at gcc dot gnu dot org
2008-02-03 13:20 ` steven at gcc dot gnu dot org
2008-02-03 13:26 ` steven at gcc dot gnu dot org
2008-02-03 13:29 ` rguenther at suse dot de
2008-02-03 14:01 ` rguenth at gcc dot gnu dot org
2008-02-03 14:03 ` steven at gcc dot gnu dot org
2008-02-03 21:46 ` dave at hiauly1 dot hia dot nrc dot ca [this message]
2008-02-04 8:12 ` ebotcazou at gcc dot gnu dot org
2008-02-04 8:31 ` ebotcazou at gcc dot gnu dot org
2008-02-04 9:54 ` rguenther at suse dot de
2008-02-09 0:31 ` danglin at gcc dot gnu dot org
2008-02-09 0:35 ` danglin at gcc dot gnu dot org
2008-02-09 0:38 ` danglin at gcc dot gnu dot org
2008-02-09 0:40 ` danglin at gcc dot gnu dot org
2008-02-09 9:20 ` steven at gcc dot gnu dot org
2008-02-09 15:06 ` dave at hiauly1 dot hia dot nrc dot ca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203214614.20416.qmail@sourceware.org \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).