public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/33761] non-optimal inlining heuristics pessimizes gzip SPEC score at -O3
Date: Wed, 06 Feb 2008 19:11:00 -0000	[thread overview]
Message-ID: <20080206191031.3149.qmail@sourceware.org> (raw)
In-Reply-To: <bug-33761-1649@http.gcc.gnu.org/bugzilla/>



------- Comment #21 from ubizjak at gmail dot com  2008-02-06 19:10 -------
(In reply to comment #20)

> Since -fo-f-p adds another free reg, it looks that since inlining increases
> register pressure some unlucky heavy-used variable gets allocated to the stack
> slot.


It is "best_len" (and probably some others, too):

[uros@localhost gzip-1.2.4]$ grep best_len fp.s
        movl    %edx, -68(%ebp) #, best_len
        movl    -68(%ebp), %edx # best_len, best_len.494
        movl    %edx, -68(%ebp) # best_len.494, best_len
        movl    -68(%ebp), %edx # best_len,
        movl    -68(%ebp), %edx # best_len,
        movl    -68(%ebp), %edx # best_len, best_len.494
        cmpl    %esi, %edx      # lookahead, best_len.494
        movl    %edx, -108(%ebp)        # best_len.494, match_length
        movl    -68(%ebp), %edx # best_len, best_len.494
        movl    %edx, -88(%ebp) # prev_length.28, best_len
        movl    -88(%ebp), %edx # best_len, best_len.457
        movl    %edx, -88(%ebp) # best_len.457, best_len
        movl    -88(%ebp), %eax # best_len,
        movl    -88(%ebp), %edx # best_len,
        movl    -88(%ebp), %edx # best_len, best_len.457
        cmpl    %esi, %edx      # lookahead, best_len.457
        movl    %edx, -40(%ebp) # best_len.457, match_length.404
        movl    -88(%ebp), %edx # best_len, best_len.457
        leal    (%ecx,%eax), %edx       #, best_len.457
        cmpl    %edx, -88(%ebp) # best_len.457, best_len
        cmpl    -96(%ebp), %edx # nice_match.34, best_len.457
        leal    (%ecx,%eax), %edx       #, best_len.494
        cmpl    %edx, -68(%ebp) # best_len.494, best_len
        cmpl    -76(%ebp), %edx # nice_match.34, best_len.494

[uros@localhost gzip-1.2.4]$ grep best_len no-fp.s
        movl    %edx, 76(%esp)  #, best_len
        movl    76(%esp), %edx  # best_len,
        movl    76(%esp), %edx  # best_len, best_len.494
        movl    %edx, 76(%esp)  # best_len.494, best_len
        movl    76(%esp), %eax  # best_len,
        movl    76(%esp), %edx  # best_len, best_len.494
        movl    %edx, %ebp      # best_len.494, match_length
        movl    76(%esp), %edx  # best_len, best_len.494
        movl    %edx, %ebp      # prev_length.28, best_len
        movl    %ebp, %edx      # best_len, best_len.457
        movl    %edx, %ebp      # best_len.457, best_len
        movl    %ebp, %edx      # best_len, best_len.457
        cmpl    %esi, %edx      # lookahead, best_len.457
        movl    %ebp, %edx      # best_len, best_len.457
        leal    (%ecx,%eax), %edx       #, best_len.494
        cmpl    %edx, 76(%esp)  # best_len.494, best_len
        cmpl    68(%esp), %edx  # nice_match.34, best_len.494
        leal    (%ecx,%eax), %edx       #, best_len.457
        cmpl    %edx, %ebp      # best_len.457, best_len
        cmpl    52(%esp), %edx  # nice_match.34, best_len.457


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33761


  parent reply	other threads:[~2008-02-06 19:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-13 11:27 [Bug target/33761] New: " ubizjak at gmail dot com
2007-10-13 12:31 ` [Bug target/33761] " rguenth at gcc dot gnu dot org
2007-12-10 10:14 ` [Bug target/33761] [4.3 regression] " ubizjak at gmail dot com
2007-12-10 10:52 ` [Bug tree-optimization/33761] " rguenth at gcc dot gnu dot org
2007-12-10 12:31 ` ubizjak at gmail dot com
2007-12-10 17:12 ` ubizjak at gmail dot com
2007-12-10 17:14 ` rguenther at suse dot de
2007-12-10 17:26 ` ubizjak at gmail dot com
2007-12-11  6:00 ` [Bug tree-optimization/33761] [4.3 regression] " ubizjak at gmail dot com
2007-12-11  6:09 ` steven at gcc dot gnu dot org
2007-12-11  6:17 ` ubizjak at gmail dot com
2008-01-16 17:40 ` [Bug tree-optimization/33761] " hubicka at gcc dot gnu dot org
2008-02-02 16:23 ` hubicka at gcc dot gnu dot org
2008-02-03 13:40 ` hubicka at gcc dot gnu dot org
2008-02-03 17:35 ` ubizjak at gmail dot com
2008-02-05 13:37 ` hubicka at gcc dot gnu dot org
2008-02-05 13:56 ` hubicka at gcc dot gnu dot org
2008-02-06 13:29 ` hubicka at gcc dot gnu dot org
2008-02-06 16:45 ` hubicka at gcc dot gnu dot org
2008-02-06 16:57 ` hubicka at gcc dot gnu dot org
2008-02-06 18:43 ` ubizjak at gmail dot com
2008-02-06 19:11 ` ubizjak at gmail dot com [this message]
2008-02-06 19:22 ` hubicka at gcc dot gnu dot org
2008-02-07 12:31 ` hubicka at gcc dot gnu dot org
2008-02-08 15:12 ` hubicka at gcc dot gnu dot org
2008-02-08 15:40 ` hubicka at gcc dot gnu dot org
2008-09-06 12:01 ` hubicka at gcc dot gnu dot org
2008-09-06 12:04 ` hubicka at gcc dot gnu dot org
2008-09-06 15:27 ` [Bug tree-optimization/33761] tree-copyrename and tree-dominators pessimizes gzip SPEC score ubizjak at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206191031.3149.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).