[Bug target/35119] New: FAIL: g++.dg/template/spec35.C scan-assembler

[Bug target/35119] New: FAIL: g++.dg/template/spec35.C scan-assembler

[dominiq at lps dot ens dot fr]

On i686-apple-darwin9, g++.dg/template/spec35.C fails for

FAIL: g++.dg/template/spec35.C scan-assembler .glob(a|)l[\t ]*_Z2f2IfEvT_
FAIL: g++.dg/template/spec35.C scan-assembler .weak[\t ]*_Z2f2IiEvT_

A quick look to the assembly shows that the regular expressions should be
something like ".glob(a|)l[\t ]*_?_Z2f2IfEvT_" and ".weak(_definition)?[\t
]*__Z2f2IiEvT_".

If needed, I can do the change in the test and regtest it on Darwin9
(ppc/intel).


-- 
           Summary: FAIL: g++.dg/template/spec35.C scan-assembler
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominiq at lps dot ens dot fr
 GCC build triplet: i686-apple-darwin9
  GCC host triplet: i686-apple-darwin9
GCC target triplet: i686-apple-darwin9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2008-02-07 11:00 -------
If that is what other testcases do, then yes, this would be appreciated.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[dominiq at lps dot ens dot fr]

------- Comment #2 from dominiq at lps dot ens dot fr  2008-02-07 12:21 -------
> If that is what other testcases do, then yes, this would be appreciated.

I am not sure to understand the sentence.  What I can do is test the proposed
regular expressions on Darwin9and see if the failures disappear. What I cannot
do is test if the proposed regular expressions do not break the test on other
platforms.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2008-02-07 14:13 -------
I mean that other testcases should be using similar patterns, and if they do
the second underscore is probably there.  A quick grep only finds

rtti/tinfo1.C:// { dg-final { scan-assembler-not "(.globl|.global)\[   
\]+_ZTIP9CTemplateIhE" } }

abi/key2.C:// { dg-final { scan-assembler ".globl __ZTI1f\\n   
.weak_definition __ZTI1f\\n     .section __DATA,__const_coal,coalesced" } }

where the first one looks incomplete (it will not fail on darwin if there is
__ZTI...), but no other scan-assembler testcase with global symbols are
appearantly there.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[dominiq at lps dot ens dot fr]

------- Comment #4 from dominiq at lps dot ens dot fr  2008-02-07 14:16 -------
I get

[ibook-dhum] i686-darwin/gcc% make -k check-g++ 
RUNTESTFLAGS="dg.exp=template/spec35.C"
test -d testsuite || mkdir testsuite
test -d testsuite/g++ || mkdir testsuite/g++
(rootme=`${PWDCMD-pwd}`; export rootme; \
        srcdir=`cd ../../gcc-4.3-work/gcc; ${PWDCMD-pwd}` ; export srcdir ; \
        cd testsuite/g++; \
        rm -f tmp-site.exp; \
        sed '/set tmpdir/ s|testsuite|testsuite/g++|' \
                < ../../site.exp > tmp-site.exp; \
        /bin/sh ${srcdir}/../move-if-change tmp-site.exp site.exp; \
        EXPECT=`if [ -f ${rootme}/../expect/expect ] ; then echo
${rootme}/../expect/expect ; else echo expect ; fi` ; export EXPECT ; \
        if [ -f ${rootme}/../expect/expect ] ; then  \
           TCL_LIBRARY=`cd .. ; cd ${srcdir}/../tcl/library ; ${PWDCMD-pwd}` ;
\
            export TCL_LIBRARY ; fi ; \
        GCC_EXEC_PREFIX="/opt/gcc/gcc4.3w/lib/gcc/" ; export GCC_EXEC_PREFIX ;
\
        `if [ -f ${srcdir}/../dejagnu/runtest ] ; then echo
${srcdir}/../dejagnu/runtest ; else echo runtest; fi` --tool g++
dg.exp=template/spec35.C)
WARNING: Couldn't find the global config file.
Test Run By dominiq on Thu Feb  7 14:57:41 2008
Native configuration is i686-apple-darwin9

                === g++ tests ===

Schedule of variations:
    unix

Running target unix
Using /sw/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /sw/share/dejagnu/config/unix.exp as generic interface file for target.
Using /opt/gcc/gcc-4.3-work/gcc/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /opt/gcc/gcc-4.3-work/gcc/testsuite/g++.dg/dg.exp ...

                === g++ Summary ===

# of expected passes            5
/opt/gcc/i686-darwin/gcc/testsuite/g++/../../g++  version 4.3.0 20080206
(experimental) (GCC) 

with the following patch:

[ibook-dhum] gcc/gcc-4.3-work% diff -u
../_gcc_clean/gcc/testsuite/g++.dg/template/spec35.C
gcc/testsuite/g++.dg/template/spec35.C
--- ../_gcc_clean/gcc/testsuite/g++.dg/template/spec35.C        2007-11-15
13:25:04.000000000 +0100
+++ gcc/testsuite/g++.dg/template/spec35.C      2008-02-07 14:56:12.000000000
+0100
@@ -8,22 +8,22 @@
 template<class T>
 static void f1 (T) { }

-// { dg-final { scan-assembler-not ".glob(a|)l\[\t \]*_Z2f1IfEvT_" } }
+// { dg-final { scan-assembler-not ".glob(a|)l\[\t \]*_?_Z2f1IfEvT_" } }
 template<>
 void f1<float> (float) { }  // Expected to have static linkage

 template<class T>
 void f2 (T) { }

-// { dg-final { scan-assembler ".glob(a|)l\[\t \]*_Z2f2IfEvT_" } }
+// { dg-final { scan-assembler ".glob(a|)l\[\t \]*_?_Z2f2IfEvT_" } }
 template<>
 void f2<float> (float) { }  // Expected to have global linkage

 void instantiator ()
 {
-  // { dg-final { scan-assembler-not ".glob(a|)l\[\t \]*_Z2f1IiEvT_" } }
+  // { dg-final { scan-assembler-not ".glob(a|)l\[\t \]*_?_Z2f1IiEvT_" } }
   f1(0);  // Expected to have static linkage

-  // { dg-final { scan-assembler ".weak\[\t \]*_Z2f2IiEvT_" } }
+  // { dg-final { scan-assembler ".weak(_definition)?\[\t \]*_?_Z2f2IiEvT_" }
}
   f2(0);  // Expected to have weak global linkage
 }


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[dominiq at lps dot ens dot fr]

------- Comment #5 from dominiq at lps dot ens dot fr  2008-02-07 15:10 -------
Test summary comparison before and after the patch in comment #4:

ibook-dhum] gcc/i686-darwin% diff -u res-132160p3m.log res-132160p4m.log
--- res-132160p3m.log   2008-02-07 15:52:50.000000000 +0100
+++ res-132160p4m.log   2008-02-07 15:54:58.000000000 +0100
@@ -12,16 +12,14 @@
 FAIL: g++.dg/ext/vector13.C (test for excess errors)
 FAIL: g++.dg/ext/visibility/anon6.C scan-assembler 1BIiE1cE
 FAIL: g++.dg/pubtypes.C scan-assembler long+[ \\t]+0x24+[ \\t]+[#;]+[
\\t]+Length of Public Type Names Info
-FAIL: g++.dg/template/spec35.C scan-assembler .glob(a|)l[\\t ]*_Z2f2IfEvT_
-FAIL: g++.dg/template/spec35.C scan-assembler .weak[\\t ]*_Z2f2IiEvT_
 FAIL: g++.dg/special/conpr-3.C execution test
 FAIL: g++.dg/special/initpri1.C execution test
 FAIL: g++.old-deja/g++.pt/const2.C (test for excess errors)

                === g++ Summary for unix ===

-# of expected passes           17297
-# of unexpected failures       10
+# of expected passes           17299
+# of unexpected failures       8
 # of expected failures         82
 # of unsupported tests         125

@@ -34,23 +32,21 @@
 FAIL: g++.dg/inherit/override-attribs.C  (test for errors, line 14)
 FAIL: g++.dg/inherit/override-attribs.C (test for excess errors)
 FAIL: g++.dg/pubtypes.C scan-assembler long+[ \\t]+0x24+[ \\t]+[#;]+[
\\t]+Length of Public Type Names Info
-FAIL: g++.dg/template/spec35.C scan-assembler .glob(a|)l[\\t ]*_Z2f2IfEvT_
-FAIL: g++.dg/template/spec35.C scan-assembler .weak[\\t ]*_Z2f2IiEvT_
 FAIL: g++.dg/special/conpr-3.C execution test
 FAIL: g++.dg/special/initpri1.C execution test
 FAIL: g++.old-deja/g++.pt/const2.C (test for excess errors)

                === g++ Summary for unix/-m64 ===

-# of expected passes           17215
-# of unexpected failures       13
+# of expected passes           17217
+# of unexpected failures       11
 # of expected failures         82
 # of unsupported tests         151

                === g++ Summary ===

-# of expected passes           34512
-# of unexpected failures       23
+# of expected passes           34516
+# of unexpected failures       19
 # of expected failures         164
 # of unsupported tests         276
 /opt/gcc/i686-darwin/gcc/testsuite/g++/../../g++  version 4.3.0 20080206
(experimental) (GCC) 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[dominiq at lps dot ens dot fr]

------- Comment #6 from dominiq at lps dot ens dot fr  2008-02-15 13:37 -------
Would it be possible to test the patch in comment #4 on non Darwin architecture
and, if it does not cause regressions, to apply it before the release of gcc
4.3.0?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2008-02-15 14:06 -------
(In reply to comment #6)
> Would it be possible to test the patch in comment #4 on non Darwin architecture
> and, if it does not cause regressions, to apply it before the release of gcc
> 4.3.0?

It works OK on *-linux. Please post the patch with ChangeLog description to
gcc-patches@ and I'll commit it for you.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ubizjak at gmail dot com
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-15 14:06:15
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[uros at gcc dot gnu dot org]

------- Comment #8 from uros at gcc dot gnu dot org  2008-02-15 14:34 -------
Subject: Bug 35119

Author: uros
Date: Fri Feb 15 14:33:57 2008
New Revision: 132344

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132344
Log:
        PR testsuite/35119
        * testsuite/g++.dg/template/spec35.C
        Change the regular expressions in dg-final to match the assembly
        code generated by Darwin 9.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/template/spec35.C


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[ubizjak at gmail dot com]

------- Comment #10 from ubizjak at gmail dot com  2008-02-15 14:37 -------
Fixed.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[dominiq at lps dot ens dot fr]

------- Comment #9 from dominiq at lps dot ens dot fr  2008-02-15 14:36 -------
Uros, thanks for the quick commit.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119

[Bug target/35119] FAIL: g++.dg/template/spec35.C scan-assembler

[ubizjak at gmail dot com]

-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35119