[Bug fortran/35130] New: OpenMP: Private variable passed to subroutine

[Bug fortran/35130] New: OpenMP: Private variable passed to subroutine

[burnus at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

As reported by Ignacio Fernández Galván, the following program prints with
"gfortran -fopenmp" 0.0 instead of 42.0. Without -fopenmp or using, e.g., ifort
or sunf95 42.0 is printed.

See also http://gcc.gnu.org/ml/fortran/2008-02/msg00058.html

I believe the program is valid, compare also
http://www.openmp.org/pipermail/omp/2006/000532.html

PROGRAM Outer
 IMPLICIT NONE
 REAL, DIMENSION(20) :: A
 INTEGER :: k
 A = 0.0
!$OMP PARALLEL DO PRIVATE(k)
 DO k=1,SIZE(A)
   CALL Inner(k)
 END DO
!$OMP END PARALLEL DO
 print *, A
CONTAINS
 SUBROUTINE Inner(i)
   IMPLICIT NONE
   INTEGER :: i
   A(i) = 42
 END SUBROUTINE Inner
END PROGRAM Outer


-- 
           Summary: OpenMP: Private variable passed to subroutine
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: wrong-code, openmp
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: burnus at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug fortran/35130] OpenMP: Private variable passed to subroutine

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2008-02-07 22:44 -------
*** Bug 35133 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug fortran/35130] OpenMP: Private variable passed to subroutine

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2008-02-07 22:44 -------
*** Bug 35131 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug fortran/35130] OpenMP: Private variable passed to subroutine

[fxcoudert at gcc dot gnu dot org]

------- Comment #3 from fxcoudert at gcc dot gnu dot org  2008-02-10 15:37 -------
I have managed to reduce it a bit more, and it does not involve passing the
loop variable as an argument:

program outer
  integer k, a(1)
  a = 0.0
!$OMP PARALLEL DO
  do k = 1, 1
    call inner
  end do
!$OMP END PARALLEL DO
 print *, a(1)

contains
  subroutine inner
    a(1) = 42
  end subroutine inner
end program outer

>From the tree dump, I've made the following C testcase which also exhibits the
same bug:

$ cat u.c 
int main (void)
{
  int a[1], k;
  void inner (void) { a[0] = 42; }

  a[0] = 0;

  #pragma omp parallel
  #pragma omp for private(k) nowait
  for (k = 1; k <= 1; k = k + 1)
    inner ();

  __builtin_printf ("%d\n", a[0]);
  return 0;
}

$ gcc -fopenmp u.c && ./a.out
0


There is no OpenMP component, and since I'm not sure the C code I have created
is valid, I leave this bug as "fortran" for now... but I think it's a generic
issue of contained functions.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-10 15:37:46
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug middle-end/35130] OpenMP: Private variable passed to subroutine

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
          Component|fortran                     |middle-end
   Last reconfirmed|2008-02-10 15:37:46         |2008-02-11 16:11:27
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug middle-end/35130] OpenMP: Private variable passed to subroutine

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2008-02-15 17:37 -------
Subject: Bug 35130

Author: jakub
Date: Fri Feb 15 17:36:43 2008
New Revision: 132349

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132349
Log:
        PR middle-end/35130
        * tree-nested.c (convert_call_expr): Put FRAME.* vars into
        OMP_CLAUSE_SHARED rather than OMP_CLAUSE_FIRSTPRIVATE clause.

        * testsuite/libgomp.fortran/pr35130.f90: New test.
        * testsuite/libgomp.c/pr35130.c: New test.

Added:
    trunk/libgomp/testsuite/libgomp.c/pr35130.c
    trunk/libgomp/testsuite/libgomp.fortran/pr35130.f90
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-nested.c
    trunk/libgomp/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug middle-end/35130] OpenMP: Private variable passed to subroutine

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2008-02-15 17:50 -------
Fixed on the trunk.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug middle-end/35130] OpenMP: Private variable passed to subroutine

[ubizjak at gmail dot com]

------- Comment #6 from ubizjak at gmail dot com  2008-02-15 18:10 -------
Fixed for real.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130

[Bug middle-end/35130] OpenMP: Private variable passed to subroutine

[pinskia at gcc dot gnu dot org]

------- Comment #7 from pinskia at gcc dot gnu dot org  2008-05-28 07:18 -------
*** Bug 36351 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hailijuan at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35130