[Bug ada/35143] New: Serious regression on ACATS results since 4.2.3

[Bug ada/35143] New: Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

4.2.3: PASSED: 2309 FAILED    3
Trunk: PASSED: 1623 FAILED  689

4.2.3 only failed c380004, c761007, and c953002.

I am posting the full log for the SVN trunk as an attachment.  Hopefully
someone can spot a pattern and we can start to file appropriate PRs.  This is a
big regression.


-- 
           Summary: Serious regression on ACATS results since 4.2.3
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: joel at gcc dot gnu dot org
GCC target triplet: powerpc-rtems4.9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #1 from joel at gcc dot gnu dot org  2008-02-08 23:01 -------
Created an attachment (id=15120)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15120&action=view)
ACATS Log for powerpc-rtems4.9 SVN trunk rev 132186


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #2 from joel at gcc dot gnu dot org  2008-02-08 23:04 -------
Created an attachment (id=15121)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15121&action=view)
RTEM SVN Trunk Ada Patch

Unfortunately, I have an outstanding patch that did not get reviewed in time
for inclusion in 4.3.  It has been posted in multiple forms but this is the
latest.  A similar patch is used against 4.2.3.  


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #3 from joel at gcc dot gnu dot org  2008-02-08 23:06 -------
Created an attachment (id=15122)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15122&action=view)
Same patch but against 4.2.3

Just as a sanity measure.  This is the same patch but against 4.2.3.  4.2.3
works great on the ACATS.  SVN has lots of problems unrelated to RTEMS
specifically.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[laurent at guerby dot net]

------- Comment #4 from laurent at guerby dot net  2008-02-08 23:15 -------
I looked at several FAIL and it looks like exception are raised as expected by
the tests but they are not catched.

What doesn't work seem to be exception propagation.

I think I gave you a little Ada exception test a while ago, did you run it on
this target?


-- 

laurent at guerby dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurent at guerby dot net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #5 from joel at gcc dot gnu dot org  2008-02-08 23:19 -------
Created an attachment (id=15123)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15123&action=view)
Laurent Guerby's exception test


With SVN, the output is

Raising Constraint_Error

raised CONSTRAINT_ERROR : exception_test.adb:11 explicit raise

With 4.2.3, the output is:

Raising Constraint_Error
Caught Constraint_Error -- inner

Same RTEMS library binary in both cases.  So any tool version issues with that
code is NOT a factor.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[laurent at guerby dot net]

------- Comment #6 from laurent at guerby dot net  2008-02-09 09:00 -------
Surprising that it works whereas ACATS doesn't.

Could you try this one?

--BEGIN exceptiontest2.adb
with Ada.Text_IO; use Ada.Text_IO;

procedure ExceptionTest2 is
   function F return Boolean is
   begin
      raise Constraint_Error;
      return True;
   end F;
begin
   begin
      if F then
         Put_Line ("Not ok");
      else
         Put_Line ("Not ok and bad value");
      end if;
   exception
      when others =>
         Put_Line ("Caught Constraint_Error -- inner");
   end;
exception
   when others =>
     Put_Line ("Caught Constraint_Error -- outer -- not OK");
end ExceptionTest2;
--END exceptiontest2.adb


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[laurent at guerby dot net]

------- Comment #7 from laurent at guerby dot net  2008-02-09 09:04 -------
And then this one:

--BEGIN exceptiontest3.adb
with Ada.Text_IO; use Ada.Text_IO;

procedure ExceptionTest3 is
   function F return Boolean is
   begin
      raise Constraint_Error;
      return True;
   end F;
begin
   begin
      if F then
         Put_Line ("Not ok");
      else
         Put_Line ("Not ok and bad value");
      end if;
   exception
      when Constraint_Error =>
         Put_Line ("Caught Constraint_Error -- inner");
      when others =>
         Put_Line ("not ok wrong exception");
   end;
exception
   when others =>
     Put_Line ("Caught Constraint_Error -- outer -- not OK");
end ExceptionTest3;
--END exceptiontest3.adb


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #8 from joel at gcc dot gnu dot org  2008-02-09 19:02 -------
Exception Test 2 on powerpc with same svn
==========================================
raised CONSTRAINT_ERROR : exceptiontest2.adb:7 explicit raise

Exception Test 3 on powerpc with same svn
=========================================
raised CONSTRAINT_ERROR : exceptiontest3.adb:7 explicit raise

I hope this helps.  

Monday I will try to submit a patch with the "required" parts of my patch from
the "improvements" part.  I realized this morning that parts of it are needed 
for gcc itself to build.  Those re worthy of being merged before the 4.3
branch. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] Serious regression on ACATS results since 4.2.3

[laurent at guerby dot net]

------- Comment #9 from laurent at guerby dot net  2008-02-09 19:10 -------
Ok all three test fail on SVN (I misread your first comment), they confirm
exception propagation is broken for some reason in SVN for RTEMS target.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[tkoenig at gcc dot gnu dot org]

------- Comment #10 from tkoenig at gcc dot gnu dot org  2008-02-09 21:54 -------
Adjusting Subject and milestone, to make sure this gets
noticed.


-- 

tkoenig at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkoenig at gcc dot gnu dot
                   |                            |org
            Summary|Serious regression on ACATS |[4.3 regression] Serious
                   |results since 4.2.3         |regression on ACATS results
                   |                            |since 4.2.3
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #11 from joel at gcc dot gnu dot org  2008-02-10 01:01 -------
Just wanted to update that I went back to a virgin tree and decided to do the
bare minimum to get the trunk compiling again.  I found remnants of a suggested
EH change Arnaud had made to me and removed it.  I just finished a PowerPC run
with this result for powerpc-rtems4.9:
                === acats Summary ===
# of expected passes            2310
# of unexpected failures        2
# of unsupported tests          3
*** FAILURES: c953002 c974013 

YEAH!  I will do a sparc-rtems run and after that I will clean up and add a
patch to this PR.  Please do not close it until I do that and it is reviewed
and applied.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[charlet at adacore dot com]

------- Comment #12 from charlet at adacore dot com  2008-02-10 13:12 -------
Subject: Re:  [4.3 regression] Serious regression on ACATS results since 4.2.3

> I found remnants of a suggested
> EH change Arnaud had made to me and removed it.

I do not think it was me. Possibly Laurent Guerby.

> YEAH!  I will do a sparc-rtems run and after that I will clean up and add a
> patch to this PR.  Please do not close it until I do that and it is reviewed
> and applied.

Please close this PR as soon as you confirm that a clean tree builds
properly.

Note that in any case, this PR is 100% specific to RTEMS since Ada is in
relatively good shape wrt exceptions on all the targets where tests are
posted.

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel dot sherrill at oarcorp dot com]

------- Comment #13 from joel dot sherrill at oarcorp dot com  2008-02-10 16:16 -------
Subject: Re:  [4.3 regression] Serious regression on ACATS
 results since 4.2.3

charlet at adacore dot com wrote:
> ------- Comment #12 from charlet at adacore dot com  2008-02-10 13:12 -------
> Subject: Re:  [4.3 regression] Serious regression on ACATS results since 4.2.3
>
>   
>> I found remnants of a suggested
>> EH change Arnaud had made to me and removed it.
>>     
>
> I do not think it was me. Possibly Laurent Guerby.
>
>   
It was back when the huge slow down in compiling was reported.
You suggested changing the exception model and apparently I had
part of the patch still in my SVN tree.  I wasn't trying to blame you.
Sorry if it came out that way.
>> YEAH!  I will do a sparc-rtems run and after that I will clean up and add a
>> patch to this PR.  Please do not close it until I do that and it is reviewed
>> and applied.
>>     
>
> Please close this PR as soon as you confirm that a clean tree builds
> properly.
>
> Note that in any case, this PR is 100% specific to RTEMS since Ada is in
> relatively good shape wrt exceptions on all the targets where tests are
> posted.
>
>   
It makes sense that it is specific to RTEMS only given what fixed
it.  I will post an RTEMS only patch with the PR as soon as I can get
runs on another target.  I want to make sure no parts of the hardware
interrupt modification rework is included so this is OK for 4.3.

--joel
> Arno
>
>
> --
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143
>
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
>   


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #14 from joel at gcc dot gnu dot org  2008-02-11 14:24 -------
Created an attachment (id=15130)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15130&action=view)
SVN RTEMS Patch

This patch greatly improves the results of the ACATS for SVN on PowerPC and
SPARC.  Please apply.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #15 from joel at gcc dot gnu dot org  2008-02-11 14:25 -------
ChangeLog entry for gcc-svn-ada-20080211.diff.  

2008-02-11  Joel Sherrill <joel.sherrill@oarcorp.com>

        PR ada/35143
        * env.c: Add __rtems__ to if defined.
        * s-osinte-rtems.adb: Add To_Target_Priority.  Fix formatting.
        * s-osinte-rtems.ads: Add To_Target_Priority prototype and
        PTHREAD_SCOPE_PROCESS/PTHREAD_SCOPE_SYSTEM constants.  Add
        pragma Convention as required.
        * gsocket.h: Make compile in and out of RTS.
        * Makefile.in: Add system-rtems.ads.  Build DEC extensions.
        Use g-soccon-rtems.ads.
        * g-soccon-rtems.ads, system-rtems.ads: New files.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #16 from joel at gcc dot gnu dot org  2008-02-11 14:43 -------
ACATS Results for various combinations.  SPARC and PowerPC are the primary ones
we have tested on for years.  This was actually the first full set of automated
runs on i386 using qemu.  Suggestions on the high number of failures relative
to the other SPARC and PowerPC is appreciated.

SVN sparc-rtems4.9 -
http://gcc.gnu.org/ml/gcc-testresults/2008-02/msg00732.html
SVN powerpc-rtems4.9 -
http://gcc.gnu.org/ml/gcc-testresults/2008-02/msg00733.html
SVN i386-rtems4.9 - http://gcc.gnu.org/ml/gcc-testresults/2008-02/msg00730.html
4.2.3 powerpc-rtems4.9 -
http://gcc.gnu.org/ml/gcc-testresults/2008-02/msg00731.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #17 from joel at gcc dot gnu dot org  2008-02-11 14:47 -------
*** Bug 34469 has been marked as a duplicate of this bug. ***


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #19 from joel at gcc dot gnu dot org  2008-02-13 19:05 -------
Patch applied to SVN trunk as revision 132294.

Thanks for approving it Arnaud.


-- 

joel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143

[Bug ada/35143] [4.3 regression] Serious regression on ACATS results since 4.2.3

[joel at gcc dot gnu dot org]

------- Comment #18 from joel at gcc dot gnu dot org  2008-02-13 19:05 -------
Subject: Bug 35143

Author: joel
Date: Wed Feb 13 19:04:53 2008
New Revision: 132294

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132294
Log:
2008-02-11  Joel Sherrill <joel.sherrill@oarcorp.com>

        PR ada/35143
        * env.c: Add __rtems__ to if defined.
        * s-osinte-rtems.adb: Add To_Target_Priority.  Fix formatting.
        * s-osinte-rtems.ads: Add To_Target_Priority prototype and
        PTHREAD_SCOPE_PROCESS/PTHREAD_SCOPE_SYSTEM constants.  Add
        pragma Convention as required.
        * gsocket.h: Make compile in and out of RTS.
        * Makefile.in: Add system-rtems.ads.  Build DEC extensions.
        Use g-soccon-rtems.ads.
        * g-soccon-rtems.ads, system-rtems.ads: New files.


Added:
    trunk/gcc/ada/g-soccon-rtems.ads
    trunk/gcc/ada/system-rtems.ads
Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/Makefile.in
    trunk/gcc/ada/env.c
    trunk/gcc/ada/gsocket.h
    trunk/gcc/ada/s-osinte-rtems.adb
    trunk/gcc/ada/s-osinte-rtems.ads


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35143