[Bug c++/35078] New: ICE with reference in parallel for loop

[Bug c++/35078] New: ICE with reference in parallel for loop

[reichelt at gcc dot gnu dot org]

The following invalid code snippet triggers an ICE since GCC 4.2.0
when compiled with -fopenmp:

===========================================================
template<int> void foo()
{
#pragma omp parallel for
  for (int& i = 0; i < 10; ++i)
    ;
}
===========================================================

bug.cc: In function 'void foo()':
bug.cc:5: internal compiler error: in build_modify_expr, at cp/typeck.c:5809
Please submit a full bug report, [etc.]

Without templates the situation is not much better:

===========================================================
void foo()
{
  int j = 0;

#pragma omp parallel for
  for (int& i = j; i < 10; ++i)
    ;
}
===========================================================

bug.cc: In function 'void foo()':
bug.cc:6: error: 'i' declared as reference but not initialized
bug.cc:7: internal compiler error: in build_modify_expr, at cp/typeck.c:5809
Please submit a full bug report, [etc.]

The compiler issues a bogus error message (the variable is initialized),
and crashes afterwards.


-- 
           Summary: ICE with reference in parallel for loop
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code, diagnostic, monitored, openmp
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35078

[Bug c++/35078] ICE with reference in parallel for loop

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2008-02-04 14:27 -------
Confirmed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |rejects-valid
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-04 14:27:31
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35078

[Bug c++/35078] ICE with reference in parallel for loop

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2008-02-15 17:57 -------
This is invalid code (iteration vars must not have reference-type), so
rejects-valid is incorrect keyword.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rejects-valid               |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35078

[Bug c++/35078] ICE with reference in parallel for loop

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |02/msg00687.html
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-02-04 14:27:31         |2008-02-18 10:19:41
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35078

[Bug c++/35078] ICE with reference in parallel for loop

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2008-02-19 10:15 -------
Subject: Bug 35078

Author: jakub
Date: Tue Feb 19 10:14:57 2008
New Revision: 132424

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132424
Log:
        PR c++/35078
        * parser.c (cp_parser_omp_for_loop): If DECL has REFERENCE_TYPE, don't
        call cp_finish_decl.
        * semantics.c (finish_omp_for): Fail if DECL doesn't have integral type
        early.

        * g++.dg/gomp/pr35078.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/gomp/pr35078.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/semantics.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35078

[Bug c++/35078] ICE with reference in parallel for loop

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2008-03-06 22:09 -------
Subject: Bug 35078

Author: jakub
Date: Thu Mar  6 22:08:55 2008
New Revision: 132992

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132992
Log:
        * gimplify.c (goa_lhs_expr_p): Allow different ADDR_EXPR nodes
        for the same VAR_DECL.

        PR c++/35028
        * cp-gimplify.c (cxx_omp_clause_apply_fn): Handle vararg copy ctors.

        PR c++/34964
        PR c++/35244
        * semantics.c (finish_omp_threadprivate): Do nothing for
error_operand_p
        vars.  Afterwards ensure v is VAR_DECL.

        PR c++/35078
        * parser.c (cp_parser_omp_for_loop): If DECL has REFERENCE_TYPE, don't
        call cp_finish_decl.
        * semantics.c (finish_omp_for): Fail if DECL doesn't have integral type
        early.

        PR c++/35028
        * g++.dg/gomp/pr35028.C: New test.

        PR c++/34964
        PR c++/35244
        * gcc.dg/gomp/pr34964.c: New test.
        * g++.dg/gomp/pr34964.C: New test.
        * gcc.dg/gomp/pr35244.c: New test.
        * g++.dg/gomp/pr35244.C: New test.

        PR c++/35078
        * g++.dg/gomp/pr35078.C: New test.

        * testsuite/libgomp.c/atomic-3.c: New test.

Added:
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/gomp/pr34964.C
      - copied unchanged from r132426,
trunk/gcc/testsuite/g++.dg/gomp/pr34964.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/gomp/pr35028.C
      - copied unchanged from r132426,
trunk/gcc/testsuite/g++.dg/gomp/pr35028.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/gomp/pr35078.C
      - copied unchanged from r132426,
trunk/gcc/testsuite/g++.dg/gomp/pr35078.C
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/gomp/pr35244.C
      - copied unchanged from r132426,
trunk/gcc/testsuite/g++.dg/gomp/pr35244.C
    branches/gcc-4_3-branch/gcc/testsuite/gcc.dg/gomp/pr34964.c
      - copied unchanged from r132426,
trunk/gcc/testsuite/gcc.dg/gomp/pr34964.c
    branches/gcc-4_3-branch/gcc/testsuite/gcc.dg/gomp/pr35244.c
      - copied unchanged from r132426,
trunk/gcc/testsuite/gcc.dg/gomp/pr35244.c
    branches/gcc-4_3-branch/libgomp/testsuite/libgomp.c/atomic-3.c
      - copied unchanged from r132979,
trunk/libgomp/testsuite/libgomp.c/atomic-3.c
Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/cp/ChangeLog
    branches/gcc-4_3-branch/gcc/cp/cp-gimplify.c
    branches/gcc-4_3-branch/gcc/cp/parser.c
    branches/gcc-4_3-branch/gcc/cp/semantics.c
    branches/gcc-4_3-branch/gcc/gimplify.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_3-branch/libgomp/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35078

[Bug c++/35078] ICE with reference in parallel for loop

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2008-03-10 10:26 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35078