public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/35368] [4.1/4.2/4.3/4.4 Regression] With #pragma visibility, `vtable for __cxxabiv1::__class_type_info' is emitted as a hidden-visibility relocation
Date: Tue, 26 Feb 2008 17:39:00 -0000	[thread overview]
Message-ID: <20080226173910.15737.qmail@sourceware.org> (raw)
In-Reply-To: <bug-35368-11332@http.gcc.gnu.org/bugzilla/>



------- Comment #9 from jakub at gcc dot gnu dot org  2008-02-26 17:39 -------
BTW, not sure why 4.1.x/4.2.x is listed as broken.  Only 4.3+ has H.J's:
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=119764
Without that change, although __cxxabiv1::* symbols are incorrectly marked
as hidden, GCC doesn't emit .hidden directives for the external symbols and all
these symbols of course are external, as they are defined in
libsupc++.a/libstdc++.{so,a}, and as they are referenced just in the RTTI
pointers, not in code directly, it makes zero difference to the generated code
whether they are hidden or not.

BTW, I've noticed that for _ZTI*/_ZTV* symbols defined in the assembly .hidden
directives are emitted twice, once at the definition spot and once at the end
of the file.  Guess assemble_external_real should skip decls that lost
DECL_EXTERNAL flag (became defined in the current TU).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35368


  parent reply	other threads:[~2008-02-26 17:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25 15:17 [Bug c++/35368] New: " benjamin at smedbergs dot us
2008-02-25 15:17 ` [Bug c++/35368] " benjamin at smedbergs dot us
2008-02-25 15:34 ` benjamin at smedbergs dot us
2008-02-25 15:55 ` [Bug c++/35368] [4.1/4.2/4.3/4.4 Regression] " rguenth at gcc dot gnu dot org
2008-02-25 16:19 ` matz at gcc dot gnu dot org
2008-02-26 16:31 ` jakub at gcc dot gnu dot org
2008-02-26 17:06 ` mmitchel at gcc dot gnu dot org
2008-02-26 17:19 ` jakub at gcc dot gnu dot org
2008-02-26 17:25 ` benjamin at smedbergs dot us
2008-02-26 17:39 ` jakub at gcc dot gnu dot org [this message]
2008-02-26 17:58 ` mark at codesourcery dot com
2008-02-27  9:10 ` jakub at gcc dot gnu dot org
2008-02-27  9:27 ` jakub at gcc dot gnu dot org
2008-02-27  9:32 ` [Bug c++/35368] [4.3/4.4 " jakub at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080226173910.15737.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).