[Bug preprocessor/35458] New: Dependency generation (-M) does not quote '#' in filenames

[Bug preprocessor/35458] New: Dependency generation (-M) does not quote '#' in filenames

[markus dot milleder at generali dot at]

Dependency generation (-M) does not quote '#' in filenames.


-- 
           Summary: Dependency generation (-M) does not quote '#' in
                    filenames
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: preprocessor
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: markus dot milleder at generali dot at


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35458

[Bug preprocessor/35458] Dependency generation (-M) does not quote '#' in filenames

[markus dot milleder at generali dot at]

------- Comment #1 from markus dot milleder at generali dot at  2008-03-04 13:37 -------
Created an attachment (id=15259)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15259&action=view)
Patch for mkdeps.c + testcase

This trivial patch cures the problem. I do not have a copyright assignment, but
the patch should be small and simple enough.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35458

[Bug preprocessor/35458] Dependency generation (-M) does not quote '#' in filenames

[rwild at gcc dot gnu dot org]

------- Comment #2 from rwild at gcc dot gnu dot org  2008-03-04 13:53 -------
Please note that quoting # in makefiles is not portable, but only supported
by some make implementations.  For example, with
   foo: a\#b
   bar: c#d

AIX make will assume 'foo' depends on 'a\', and 'bar' on 'c'.
Likewise HP-UX make.  Consequently, both of these make's will error out on
either line of:
  a#b:
  a\#b:


-- 

rwild at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Ralf dot Wildenhues at gmx
                   |                            |dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35458

[Bug preprocessor/35458] Dependency generation (-M) does not quote '#' in filenames

[markus dot milleder at generali dot at]

------- Comment #3 from markus dot milleder at generali dot at  2008-03-04 14:10 -------
(In reply to comment #2)
> Please note that quoting # in makefiles is not portable, but only supported
> by some make implementations.  For example, with
>    foo: a\#b
>    bar: c#d
> 
> AIX make will assume 'foo' depends on 'a\', and 'bar' on 'c'.
> Likewise HP-UX make.  Consequently, both of these make's will error out on
> either line of:
>   a#b:
>   a\#b:
> 
So it seems to me the patch is an improvement for make versions that understand
quoting and does not worsen the situation for those that do not, i.e. files
containing # are broken on e.g. AIX without the patch and with it.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35458

[Bug preprocessor/35458] Dependency generation (-M) does not quote '#' in filenames

[tromey at gcc dot gnu dot org]

------- Comment #4 from tromey at gcc dot gnu dot org  2008-03-06 18:09 -------
Subject: Bug 35458

Author: tromey
Date: Thu Mar  6 18:08:40 2008
New Revision: 132982

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132982
Log:
libcpp
2008-03-06  Markus Milleder  <markus.milleder@generali.at>
        PR preprocessor/35458
        * mkdeps.c (munge): Quote '#' with a '\'.
gcc/testsuite
2008-03-06  Markus Milleder  <markus.milleder@generali.at>
        PR preprocessor/35458
        * gcc.dg/cpp/cmdlne-M-2.c: New file.
        * gcc.dg/cpp/cmdlne-M-2#.h: New file.
        * gcc.dg/cpp/#cmdlne-M-2.h: New file.

Added:
    trunk/gcc/testsuite/gcc.dg/cpp/#cmdlne-M-2.h
    trunk/gcc/testsuite/gcc.dg/cpp/cmdlne-M-2#.h
    trunk/gcc/testsuite/gcc.dg/cpp/cmdlne-M-2.c
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libcpp/ChangeLog
    trunk/libcpp/mkdeps.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35458

[Bug preprocessor/35458] Dependency generation (-M) does not quote '#' in filenames

[tromey at gcc dot gnu dot org]

------- Comment #5 from tromey at gcc dot gnu dot org  2008-03-06 18:15 -------
I agree with comment #3.
This is an improvement.
Users concerned with real portability should be avoiding "#" anyhow.


-- 

tromey at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35458