[Bug target/33963] New: Dllimport attribute wrongly accepted on typedefs

[Bug target/33963] New: Dllimport attribute wrongly accepted on typedefs

[dannysmith at users dot sourceforge dot net]

Testcase gcc.dg/attr-invalid.c started failing on mingw32 with

http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=125975

In particular, this delta
        * tree.c (handle_dll_attribute): Set DECL_VISIBILITY on the
        imported or exported declaration, including type declarations.

made these TYPE_DECL's valid:

# 88 "attr-invalid.c"
typedef int dllimport_type __attribute__((dllimport));

typedef int (*dllimport_fntype)(void) __attribute__((dllimport));

Prior to that revision the attribute was valid only on FUNCTION_DECLS's
and VAR_DECL's 

However, although there is no warning, the attribute is ignored 

typedef int dllimport_type __attribute__((dllimport));
extern dllimport_type foo;
int bar () { return foo; }

gives

_bar:
        pushl   %ebp
        movl    %esp, %ebp
        movl    _foo, %eax
        popl    %ebp
        ret


-- 
           Summary: Dllimport attribute wrongly accepted on typedefs
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dannysmith at users dot sourceforge dot net
GCC target triplet: i686-pc-mingw32


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33963

[Bug target/33963] [4.3/4.4 Regression] Dllimport attribute wrongly accepted on typedefs

[jsm28 at gcc dot gnu dot org]

------- Comment #1 from jsm28 at gcc dot gnu dot org  2008-02-26 12:13 -------
Mark confirms this should not be accepted for scalar types, so a regression. 
Working on a patch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jsm28 at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
           Keywords|                            |accepts-invalid
           Priority|P3                          |P4
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-26 12:13:45
               date|                            |
            Summary|Dllimport attribute wrongly |[4.3/4.4 Regression]
                   |accepted on typedefs        |Dllimport attribute wrongly
                   |                            |accepted on typedefs
   Target Milestone|---                         |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33963

[Bug target/33963] [4.3/4.4 Regression] Dllimport attribute wrongly accepted on typedefs

[jsm28 at gcc dot gnu dot org]

------- Comment #2 from jsm28 at gcc dot gnu dot org  2008-02-28 12:35 -------
Subject: Bug 33963

Author: jsm28
Date: Thu Feb 28 12:34:51 2008
New Revision: 132744

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132744
Log:
        PR target/33963
        * tree.c (handle_dll_attribute): Disallow TYPE_DECLs for types
        other than structures and unions.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33963

[Bug target/33963] [4.3/4.4 Regression] Dllimport attribute wrongly accepted on typedefs

[jsm28 at gcc dot gnu dot org]

------- Comment #3 from jsm28 at gcc dot gnu dot org  2008-03-06 17:30 -------
Subject: Bug 33963

Author: jsm28
Date: Thu Mar  6 17:29:36 2008
New Revision: 132978

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132978
Log:
        PR target/33963
        * tree.c (handle_dll_attribute): Disallow TYPE_DECLs for types
        other than structures and unions.

Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/tree.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33963

[Bug target/33963] [4.3/4.4 Regression] Dllimport attribute wrongly accepted on typedefs

[jsm28 at gcc dot gnu dot org]

------- Comment #4 from jsm28 at gcc dot gnu dot org  2008-03-06 17:31 -------
Fixed in 4.3.1 and 4.4.0.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |4.3.0
      Known to work|4.2.0                       |4.2.0 4.3.1 4.4.0
         Resolution|                            |FIXED
   Target Milestone|4.3.0                       |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33963