[Bug ada/35493] New: Assert_Failure uintp.adb:1593

[Bug ada/35493] New: Assert_Failure uintp.adb:1593

[danglin at gcc dot gnu dot org]

/Users/dave/gnu/gcc/objdir/./prev-gcc/xgcc
-B/Users/dave/gnu/gcc/objdir/./prev-g
cc/ -B/opt/gnu/gcc/gcc-4.4.0/i686-apple-darwin9/bin/ -c -g -O2
-fomit-frame-poin
ter      -gnatpg -gnata -nostdinc -I- -I. -Iada -I../../gcc/gcc/ada
../../gcc/gc
c/ada/ada.ads -o ada/ada.o
+===========================GNAT BUG DETECTED==============================+
| 4.4.0 20080307 (experimental) [trunk revision 132999] (i686-apple-darwin9) |
| Assert_Failure uintp.adb:1593                                            |
| No source file position information available                            |

This occurs in stage3.  Build yesterday was ok.


-- 
           Summary: Assert_Failure uintp.adb:1593
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: i686-apple-darwin9
  GCC host triplet: i686-apple-darwin9
GCC target triplet: i686-apple-darwin9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug tree-optimization/35493] Assert_Failure uintp.adb:1593

[schwab at suse dot de]

------- Comment #1 from schwab at suse dot de  2008-03-07 10:48 -------
This was caused by this change:

2008-03-06  Andrew Pinski  <andrew_pinski@playstation.sony.com>

       PR tree-opt/35402
       * tree-ssa-ccp.c (get_symbol_constant_value): Handle
       integral and scalar float variables which have a
       NULL DECL_INITIAL.


-- 

schwab at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schwab at suse dot de,
                   |                            |pinskia at gcc dot gnu dot
                   |                            |org
          Component|ada                         |tree-optimization
  GCC build triplet|i686-apple-darwin9          |
   GCC host triplet|i686-apple-darwin9          |
 GCC target triplet|i686-apple-darwin9          |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug ada/35493] Assert_Failure uintp.adb:1593

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2008-03-07 11:59 -------
This has to be a bug in the Ada front-end because all the rest of the
middle-end assumes that if DECL_INITIAL is NULL, the value is going to be zero.
 I might be the case where TREE_READONLY is being set and it should not be as
the variable is not readonly.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |ada


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug ada/35493] Assert_Failure uintp.adb:1593

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2008-03-07 12:05 -------
I think the Ada front-end has TREE_CONSTANT and TREE_READONLY definition
swapped around:

  /* Whether we will make TREE_CONSTANT the DECL we produce here, in which
     case the initializer may be used in-lieu of the DECL node (as done in
     Identifier_to_gnu).  This is useful to prevent the need of elaboration
     code when an identifier for which such a decl is made is in turn used as
     an initializer.  We used to rely on CONST vs VAR_DECL for this purpose,
     but extra constraints apply to this choice (see below) and are not
     relevant to the distinction we wish to make. */ 
  bool constant_p = const_flag && init_const;

  TREE_READONLY (var_decl) = const_flag;
  DECL_EXTERNAL (var_decl) = extern_flag;
  TREE_PUBLIC   (var_decl) = public_flag || extern_flag;
  TREE_CONSTANT (var_decl) = constant_p;



READ_ONLY means it is only read and not written to at all and the initializer
is valid.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug ada/35493] [4.4 Regression] Assert_Failure uintp.adb:1593

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
            Summary|Assert_Failure              |[4.4 Regression]
                   |uintp.adb:1593              |Assert_Failure
                   |                            |uintp.adb:1593
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug ada/35493] [4.4 Regression] Assert_Failure uintp.adb:1593

[schwab at suse dot de]

------- Comment #4 from schwab at suse dot de  2008-03-07 14:59 -------
The patch in <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35494#c6> works here
as well.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug tree-optimization/35493] [4.4 Regression] Assert_Failure uintp.adb:1593

[ebotcazou at gcc dot gnu dot org]

------- Comment #5 from ebotcazou at gcc dot gnu dot org  2008-03-07 16:46 -------
Based on Andreas' latest comment.  The Ada FE may need inspection though.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
          Component|ada                         |tree-optimization
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-03-07 16:46:14
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug tree-optimization/35493] [4.4 Regression] Assert_Failure uintp.adb:1593

[ebotcazou at gcc dot gnu dot org]

------- Comment #6 from ebotcazou at gcc dot gnu dot org  2008-03-07 18:28 -------
> I think the Ada front-end has TREE_CONSTANT and TREE_READONLY definition
> swapped around:
> 
>   /* Whether we will make TREE_CONSTANT the DECL we produce here, in which
>      case the initializer may be used in-lieu of the DECL node (as done in
>      Identifier_to_gnu).  This is useful to prevent the need of elaboration
>      code when an identifier for which such a decl is made is in turn used
>      an initializer.  We used to rely on CONST vs VAR_DECL for this purpose,
>      but extra constraints apply to this choice (see below) and are not
>      relevant to the distinction we wish to make. */ 
>   bool constant_p = const_flag && init_const;
> 
>   TREE_READONLY (var_decl) = const_flag;
>   DECL_EXTERNAL (var_decl) = extern_flag;
>   TREE_PUBLIC   (var_decl) = public_flag || extern_flag;
>   TREE_CONSTANT (var_decl) = constant_p;

This doesn't seem to be the case according to
  http://gcc.gnu.org/ml/gcc/2005-08/msg00686.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug tree-optimization/35493] [4.4 Regression] Assert_Failure uintp.adb:1593

[laurent at guerby dot net]

------- Comment #7 from laurent at guerby dot net  2008-03-08 20:45 -------
For reference H. J. Lu proposed patch (for C++):

http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00466.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493

[Bug tree-optimization/35493] [4.4 Regression] Assert_Failure uintp.adb:1593

[belyshev at depni dot sinp dot msu dot ru]

------- Comment #8 from belyshev at depni dot sinp dot msu dot ru  2008-03-10 19:44 -------
Patch for bug 35494 was committed, so this PR should be fixed now too.


-- 

belyshev at depni dot sinp dot msu dot ru changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |belyshev at depni dot sinp
                   |                            |dot msu dot ru
  BugsThisDependsOn|                            |35494
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
Bug 35493 depends on bug 35494, which changed state.

Bug 35494 Summary: [4.4 Regression]: Revision 132991 breaks C++ static member
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35494

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35493