[Bug target/26149] New: libgomp.c/ordered-2.c fails on i686-linux-gnu

[Bug target/26149] New: libgomp.c/ordered-2.c fails on i686-linux-gnu

[pinskia at gcc dot gnu dot org]

FAIL: libgomp.c/ordered-2.c (test for excess errors)
Excess errors:
ordered-2.c:(.text+0x29): undefined reference to `__sync_fetch_and_add_4'


-- 
           Summary: libgomp.c/ordered-2.c fails on i686-linux-gnu
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
GCC target triplet: i686-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on i686-linux-gnu

[hp at gcc dot gnu dot org]

------- Comment #1 from hp at gcc dot gnu dot org  2006-02-12 23:20 -------
Looks related to one of the FAILs in 25893, so let's connect them.


-- 

hp at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |25893
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86-64-linux-gnu with -m32

[pinskia at gcc dot gnu dot org]

------- Comment #2 from pinskia at gcc dot gnu dot org  2006-09-03 20:50 -------
Still fails as of today:
http://gcc.gnu.org/ml/gcc-testresults/2006-09/msg00141.html


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-09-03 20:50:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86-64-linux-gnu with -m32

[ghazi at gcc dot gnu dot org]

------- Comment #3 from ghazi at gcc dot gnu dot org  2008-03-09 15:42 -------
Still fails in 4.2.x:
http://gcc.gnu.org/ml/gcc-testresults/2008-03/msg00510.html
http://gcc.gnu.org/ml/gcc-testresults/2008-03/msg00457.html

I don't see the error with the 4.3 branch:
http://gcc.gnu.org/ml/gcc-testresults/2008-03/msg00669.html

Maybe it was fixed and just needs backporting?


-- 

ghazi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ghazi at gcc dot gnu dot org
 GCC target triplet|x86-64-linux-gnu            |x86_64-linux-gnu
      Known to fail|                            |4.2.0 4.2.4
      Known to work|                            |4.3.0
   Last reconfirmed|2006-09-03 20:50:37         |2008-03-09 15:42:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ghazi at gcc dot gnu dot org]

------- Comment #4 from ghazi at gcc dot gnu dot org  2008-03-09 16:07 -------
On 4.3.x, this failure goes away sometime on 20070322.  Luckily we had two
testsuite results on the same day hours apart from one person in which the
failure disappears. :-)

http://gcc.gnu.org/ml/gcc-testresults/2007-03/msg01067.html

http://gcc.gnu.org/ml/gcc-testresults/2007-03/msg01071.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ubizjak at gmail dot com]

------- Comment #5 from ubizjak at gmail dot com  2008-03-09 16:17 -------
IIRC, this is a testsuite issue, -march=i486 is not appended automatically to
compile flags. This was fixed by following patch series:

2007-04-07  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

        PR testsuite/31369
        * testsuite/libgomp.c++/c++.exp: Don't use concat when setting
        ld_library_path.
        * testsuite/libgomp.fortran/fortran.exp: Likewise.

2007-03-23  Andreas Tobler  <a.tobler@schweiz.org>

        * testsuite/lib/libgomp.exp (libgomp_init): Add -shared-libgcc for
        *-*-darwin*.
        * testsuite/libgomp.c++/c++.exp: Look for shared libstdc++ library
        and use it if found.

2007-03-18  Uros Bizjak  <ubizjak@gmail.com>

        * testsuite/config/default.exp: New file.
        * testsuite/lib/libgomp.exp: New file.
        * testsuite/lib/libgomp.dg (load_gcc_lib, libgomp_init,
        libgomp_target_compile, libgomp_option_help, libgomp_option_proc,
        load_lib *, load_gcc_lib *): Move to libgomp.exp.
        (libgomp_load): Remove.
        * testsuite/lib/libgomp.exp (libgomp_init): Compute
        always_ld_library_path, not ld_library_path.  Set additional_flags
        to -march=i486 for ilp32 x86_64-*-* and i386-*-* targets.
        (target_compile): Do not call libgomp_init.  Append lang_library_path
        and lang_link_flags to options.
        * testsuite/libgomp.c/c.exp: Set DEFAULT_FLAGS to -O2.  Set
        ld_library_path from always_ld_library_path.  Set LD_LIBRARY_PATH
        here.
        * testsuite/libgomp.c++/c++.exp: Set ld_library_path from
        always_ld_library_path.  Set LD_LIBRARY_PATH here.
        * testsuite/libgomp.fortran/fortran.exp: Ditto.

And no, I didn't volunteer to do the backport ;)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ghazi at gcc dot gnu dot org]

------- Comment #6 from ghazi at gcc dot gnu dot org  2008-03-09 19:40 -------
(In reply to comment #5)
> IIRC, this is a testsuite issue, -march=i486 is not appended automatically to
> compile flags. This was fixed by following patch series:
> [...]

Uros - It would seem that the first patch written by you and installed on
3/22/2008 was sufficient to fix the problem on x86_64.  What was the need for
the others, relevant towards this PR?
Thanks,
--Kaveh


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2008-03-09 20:55 -------
(In reply to comment #6)

> Uros - It would seem that the first patch written by you and installed on
> 3/22/2008 was sufficient to fix the problem on x86_64.  What was the need for
> the others, relevant towards this PR?

IIRC, various !x86 targets need their little tweaks, i.e. where they put their
dynamic libraries.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ghazi at gcc dot gnu dot org]

-- 

ghazi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ghazi at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-03-09 15:42:19         |2008-03-10 19:55:15
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ghazi at gcc dot gnu dot org]

------- Comment #8 from ghazi at gcc dot gnu dot org  2008-03-11 01:23 -------
Patch posted here:
http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00663.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ghazi at gcc dot gnu dot org]

------- Comment #9 from ghazi at gcc dot gnu dot org  2008-03-11 15:36 -------
Subject: Bug 26149

Author: ghazi
Date: Tue Mar 11 15:35:51 2008
New Revision: 133114

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133114
Log:
        PR target/26149

        Backport:

        2007-03-18 Uros Bizjak <ubizjak@gmail.com>

        * testsuite/config/default.exp: New file.
        * testsuite/lib/libgomp.exp: New file.
        * testsuite/lib/libgomp.dg (load_gcc_lib, libgomp_init,
        libgomp_target_compile, libgomp_option_help, libgomp_option_proc,
        load_lib *, load_gcc_lib *): Move to libgomp.exp.
        (libgomp_load): Remove.
        * testsuite/lib/libgomp.exp (libgomp_init): Compute
        always_ld_library_path, not ld_library_path. Set additional_flags
        to -march=i486 for ilp32 x86_64-*-* and i386-*-* targets.
        (target_compile): Do not call libgomp_init. Append
        lang_library_path and lang_link_flags to options.
        * testsuite/libgomp.c/c.exp: Set DEFAULT_FLAGS to -O2. Set
        ld_library_path from always_ld_library_path. Set LD_LIBRARY_PATH here.
        * testsuite/libgomp.c++/c++.exp: Set ld_library_path from
        always_ld_library_path. Set LD_LIBRARY_PATH here.
        * testsuite/libgomp.fortran/fortran.exp: Ditto.
        * testsuite/libgomp.c/atomic-1.c: Set dg-options to
        "-O2 -march=pentium" for ilp32 x86 targets. Simplify check for CX8
flag.
        * testsuite/libgomp.c/pr29947-1.c: Remove default dg-options.
        * testsuite/libgomp.c/pr29947-1.c: Ditto.
        * testsuite/libgomp.c/atomic-10.c: Ditto.

        2007-03-22 Andreas Tobler <a.tobler@schweiz.org>

        * testsuite/lib/libgomp.exp (libgomp_init): Add -shared-libgcc for
        *-*-darwin*.
        * testsuite/libgomp.c++/c++.exp: Look for shared libstdc++ library
        and use it if found.

        2007-04-06  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

        PR testsuite/31369
        * testsuite/libgomp.c++/c++.exp: Don't use concat when setting
        ld_library_path.
        * testsuite/libgomp.fortran/fortran.exp: Likewise.

        2007-03-21  Jakub Jelinek  <jakub@redhat.com>

        * testsuite/libgomp.fortran/appendix-a/a.22.8.f90: Add
        dg-final cleanup-modules line.
        * testsuite/libgomp.fortran/appendix-a/a.40.1.f90: Likewise.
        * testsuite/libgomp.fortran/appendix-a/a.31.5.f90: Likewise.
        * testsuite/libgomp.fortran/appendix-a/a.31.4.f90: Likewise.
        * testsuite/libgomp.fortran/threadprivate2.f90: Likewise.
        * testsuite/libgomp.fortran/reduction5.f90: Likewise.
        * testsuite/libgomp.fortran/threadprivate3.f90: Likewise.
        * testsuite/libgomp.fortran/threadprivate1.f90: Likewise.

        2007-10-25  Jakub Jelinek  <jakub@redhat.com>

        PR libgomp/33275
        * testsuite/libgomp.fortran/omp_parse3.f90 (test_threadprivate):
        Make x and y integers rather than (implicit) reals.  Add private (j)
        clause to the last omp parallel.


Added:
    branches/gcc-4_2-branch/libgomp/testsuite/config/
    branches/gcc-4_2-branch/libgomp/testsuite/config/default.exp
    branches/gcc-4_2-branch/libgomp/testsuite/lib/libgomp.exp
Modified:
    branches/gcc-4_2-branch/libgomp/ChangeLog
    branches/gcc-4_2-branch/libgomp/testsuite/lib/libgomp-dg.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c++/c++.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/atomic-1.c
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/atomic-10.c
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/c.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/pr29947-1.c
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.c/pr29947-2.c
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.22.8.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.31.4.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.31.5.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/appendix-a/a.40.1.f90
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/fortran.exp
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/omp_parse3.f90
    branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/reduction5.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/threadprivate1.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/threadprivate2.f90
   
branches/gcc-4_2-branch/libgomp/testsuite/libgomp.fortran/threadprivate3.f90


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149

[Bug target/26149] libgomp.c/ordered-2.c fails on x86_64-linux-gnu with -m32

[ghazi at gcc dot gnu dot org]

------- Comment #10 from ghazi at gcc dot gnu dot org  2008-03-11 16:14 -------
Fixed.


-- 

ghazi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|4.2.0 4.2.4                 |4.2.0
      Known to work|4.3.0                       |4.3.0 4.2.4
         Resolution|                            |FIXED
   Target Milestone|---                         |4.2.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26149