[Bug c/35526] ICE on memcpy

[Bug c/35526] ICE on memcpy

[dominik dot strasser at onespin-solutions dot com]

------- Comment #1 from dominik dot strasser at onespin-solutions dot com  2008-03-10 18:15 -------
Created an attachment (id=15289)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15289&action=view)
Source file which gives the ICE


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug c/35526] New: ICE on memcpy

[dominik dot strasser at onespin-solutions dot com]

Compiling the attached source either with g++ or gcc renders an ICE
oo.C:9: internal compiler error: in convert_move, at expr.c:373

-O must be used.

gcc -O oo.C


-- 
           Summary: ICE on memcpy
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dominik dot strasser at onespin-solutions dot com
 GCC build triplet: x86_64-unknown-linux-gnu
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug middle-end/35526] ICE on memcpy

[ubizjak at gmail dot com]

------- Comment #2 from ubizjak at gmail dot com  2008-03-10 22:11 -------
Confirmed with g++ -O oo.C, backtrace:

#0  fancy_abort (file=0xcb2b48 "../../gcc-svn/trunk/gcc/expr.c", line=373,
function=0xcb3e43 "convert_move")
    at ../../gcc-svn/trunk/gcc/diagnostic.c:683
#1  0x00000000006a952e in convert_move (to=0x2aaaae5c28e0, from=0x2aaaae5c2900,
unsignedp=0) at ../../gcc-svn/trunk/gcc/expr.c:373
#2  0x00000000006ae785 in store_expr (exp=0x2aaaae5bc0a0,
target=0x2aaaae5c28e0, call_param_p=0, 
    nontemporal=<value optimized out>) at ../../gcc-svn/trunk/gcc/expr.c:4663
#3  0x00000000006b0dd2 in expand_assignment (to=0x2aaaae46f5f0,
from=0x2aaaae5bc0a0, nontemporal=0 '\0')
    at ../../gcc-svn/trunk/gcc/expr.c:4258
#4  0x0000000000697c89 in expand_expr_real_1 (exp=0x2aaaae5c5450, target=0x0,
tmode=VOIDmode, modifier=EXPAND_NORMAL, 
    alt_rtl=<value optimized out>) at ../../gcc-svn/trunk/gcc/expr.c:9141
#5  0x00000000006a75f3 in expand_expr_real (exp=0x2aaaae5c5450,
target=0x2aaaae46d400, tmode=VOIDmode, modifier=EXPAND_NORMAL, 
    alt_rtl=0x0) at ../../gcc-svn/trunk/gcc/expr.c:7088

we hit

  gcc_assert (from_mode != BLKmode);

with

(gdb) p debug_rtx (from)
(mem/s/c:BLK (symbol_ref:DI ("internal_crash_read_ip") [flags 0x2] <var_decl
0x2aaaae5bc0a0 internal_crash_read_ip>) [0 internal_crash_read_ip+0 S1 A8])

probably we need

Index: expr.c
===================================================================
--- expr.c      (revision 133091)
+++ expr.c      (working copy)
@@ -4654,7 +4654,8 @@ store_expr (tree exp, rtx target, int ca
              temp = convert_to_mode (GET_MODE (target), temp, unsignedp);
              emit_move_insn (target, temp);
            }
-         else if (GET_MODE (target) == BLKmode)
+         else if (GET_MODE (target) == BLKmode
+                  || GET_MODE (temp) == BLKmode)
            emit_block_move (target, temp, expr_size (exp),
                             (call_param_p
                              ? BLOCK_OP_CALL_PARM


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-03-10 22:11:35
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug middle-end/35526] ICE on memcpy

[ubizjak at gmail dot com]

------- Comment #3 from ubizjak at gmail dot com  2008-03-10 22:25 -------
FYI, patch from Comment #2 fixes the failure.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ubizjak at gmail dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-03-10 22:11:35         |2008-03-10 22:25:59
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug c/35526] ICE on memcpy

[dominik dot strasser at onespin-solutions dot com]

------- Comment #4 from dominik dot strasser at onespin-solutions dot com  2008-03-11 09:02 -------
I can confirm that the patch fixes the original example.


-- 

dominik dot strasser at onespin-solutions dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |c


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug c/35526] ICE on memcpy

[uros at gcc dot gnu dot org]

------- Comment #5 from uros at gcc dot gnu dot org  2008-03-11 12:48 -------
Subject: Bug 35526

Author: uros
Date: Tue Mar 11 12:47:29 2008
New Revision: 133106

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133106
Log:
        PR middle-end/35526
        * expr.c (store_expr): Call emit_block_move if the mode
        of "temp" RTX is BLKmode.

testsuite/ChangeLog:

        PR middle-end/35526
        * g++.dg/torture/pr35526.C: New test.


Added:
    trunk/gcc/testsuite/g++.dg/torture/pr35526.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/expr.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug c/35526] ICE on memcpy

[uros at gcc dot gnu dot org]

------- Comment #6 from uros at gcc dot gnu dot org  2008-03-11 14:17 -------
Subject: Bug 35526

Author: uros
Date: Tue Mar 11 14:16:25 2008
New Revision: 133108

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133108
Log:
2008-03-11  Uros Bizjak  <ubizjak@gmail.com>

        PR middle-end/35526
        * expr.c (store_expr): Call emit_block_move if the mode
        of "temp" RTX is BLKmode.

testsuite/ChangeLog:

        PR middle-end/35526
        * g++.dg/torture/pr35526.C: New test.


Added:
    branches/gcc-4_3-branch/gcc/testsuite/g++.dg/torture/pr35526.C
      - copied unchanged from r133106,
trunk/gcc/testsuite/g++.dg/torture/pr35526.C
Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/expr.c
    branches/gcc-4_3-branch/gcc/ifcvt.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug c/35526] ICE on memcpy

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2008-03-11 14:31 -------
Fixed.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug c/35526] ICE on memcpy

[rguenth at gcc dot gnu dot org]

------- Comment #8 from rguenth at gcc dot gnu dot org  2008-03-28 10:30 -------
*** Bug 35730 has been marked as a duplicate of this bug. ***


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |davids at webmaster dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526

[Bug c/35526] ICE on memcpy

[dominik dot strasser at onespin-solutions dot com]

------- Comment #9 from dominik dot strasser at onespin-solutions dot com  2009-05-20 14:58 -------
Works fine


-- 

dominik dot strasser at onespin-solutions dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35526