[Bug c++/35566] New: multiset constructor uses insert_unique instead of insert_equal!

[Bug c++/35566] New: multiset constructor uses insert_unique instead of insert_equal!

[dennis dot czeremin at smiths-heimann dot com]

Using the constructor of a multimap with 2 input iterators does not insert
multible keys any longer (gcc-4.2.3 had done it)

fix: Replace insert_unique with insert_equal in
/usr/local/gcc-4.3.0/include/c++/4.3.0/bits/stl_multimap.h:

190-       *  @param  first  An input iterator.
191-       *  @param  last  An input iterator.
192-       *
193-       *  Create a %multimap consisting of copies of the elements from
194-       *  [first,last).  This is linear in N if the range is already
sorted,
195-       *  and NlogN otherwise (where N is distance(first,last)).
196-       */
197-      template<typename _InputIterator>
198-        multimap(_InputIterator __first, _InputIterator __last)
199-    : _M_t()
200:        { _M_t._M_insert_unique(__first, __last); }


-- 
           Summary: multiset constructor uses insert_unique instead of
                    insert_equal!
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dennis dot czeremin at smiths-heimann dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566

[Bug c++/35566] multiset constructor uses insert_unique instead of insert_equal!

[dennis dot czeremin at smiths-heimann dot com]

------- Comment #1 from dennis dot czeremin at smiths-heimann dot com  2008-03-13 10:48 -------
Created an attachment (id=15307)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15307&action=view)
Testcase to reproduce bug

[test_O0][dcz@mars test]$g++ -v -save-temps -O0 -ggdb -Wall -Wextra -pedantic 
multimap.cpp
Using built-in specs.
Target: i686-pc-linux-gnu
Configured with: ../gcc-4.3.0/configure --prefix /usr/local/gcc-4.3.0
--program-suffix=-4.3.0 --enable-libssp
Thread model: posix
gcc version 4.3.0 (GCC)
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-O0' '-ggdb' '-Wall' '-Wextra'
'-pedantic' '-shared-libgcc' '-mtune=generic'
 /usr/local/gcc-4.3.0/libexec/gcc/i686-pc-linux-gnu/4.3.0/cc1plus -E -quiet -v
-D_GNU_SOURCE multimap.cpp -mtune=generic -Wall -Wextra -pedantic
-fworking-directory -O0 -fpch-preprocess -o multimap.ii
ignoring nonexistent directory
"/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/../../../../i686-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:

/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/../../../../include/c++/4.3.0

/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/../../../../include/c++/4.3.0/i686-pc-linux-gnu

/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/../../../../include/c++/4.3.0/backward
 /usr/local/include
 /usr/local/gcc-4.3.0/include
 /usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/include
 /usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/include-fixed
 /usr/include
End of search list.
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-O0' '-ggdb' '-Wall' '-Wextra'
'-pedantic' '-shared-libgcc' '-mtune=generic'
 /usr/local/gcc-4.3.0/libexec/gcc/i686-pc-linux-gnu/4.3.0/cc1plus
-fpreprocessed multimap.ii -quiet -dumpbase multimap.cpp -mtune=generic
-auxbase multimap -ggdb -O0 -Wall -Wextra -pedantic -version -o multimap.s
GNU C++ (GCC) version 4.3.0 (i686-pc-linux-gnu)
        compiled by GNU C version 4.3.0, GMP version 4.2.2, MPFR version
2.3.0-p2.
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: 18c2b045fc3432350b6f5025fd85e044
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-O0' '-ggdb' '-Wall' '-Wextra'
'-pedantic' '-shared-libgcc' '-mtune=generic'
 as -V -Qy -o multimap.o multimap.s
GNU assembler version 2.17.50.0.18 (i386-redhat-linux) using BFD version
version 2.17.50.0.18-1 20070731
COMPILER_PATH=/usr/local/gcc-4.3.0/libexec/gcc/i686-pc-linux-gnu/4.3.0/:/usr/local/gcc-4.3.0/libexec/gcc/i686-pc-linux-gnu/4.3.0/:/usr/local/gcc-4.3.0/libexec/gcc/i686-pc-linux-gnu/:/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/:/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/
LIBRARY_PATH=/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/:/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/../../../:/lib/:/usr/lib/
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-O0' '-ggdb' '-Wall' '-Wextra'
'-pedantic' '-shared-libgcc' '-mtune=generic'
 /usr/local/gcc-4.3.0/libexec/gcc/i686-pc-linux-gnu/4.3.0/collect2
--eh-frame-hdr -m elf_i386 -dynamic-linker /lib/ld-linux.so.2 /usr/lib/crt1.o
/usr/lib/crti.o /usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/crtbegin.o
-L/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0
-L/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/../../.. multimap.o
-lstdc++ -lm -lgcc_s -lgcc -lc -lgcc_s -lgcc
/usr/local/gcc-4.3.0/lib/gcc/i686-pc-linux-gnu/4.3.0/crtend.o /usr/lib/crtn.o


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566

[Bug c++/35566] multiset constructor uses insert_unique instead of insert_equal!

[dennis dot czeremin at smiths-heimann dot com]

------- Comment #2 from dennis dot czeremin at smiths-heimann dot com  2008-03-13 12:28 -------
Bug in /trunk/libstdc++-v3/include/bits/stl_multimap.h was introduced with

Revision 129013 
Modified Thu Oct 4 15:12:34 2007 UTC (5 months, 1 week ago) by paolo 

No hint about changes. Seems to be a copy&paste error!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566

[Bug libstdc++/35566] multiset constructor uses insert_unique instead of insert_equal!

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
          Component|c++                         |libstdc++


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566

[Bug libstdc++/35566] multiset constructor uses insert_unique instead of insert_equal!

[pcarlini at suse dot de]

-- 

pcarlini at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pcarlini at suse dot de
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-03-13 16:59:15
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566

[Bug libstdc++/35566] [4.3 Regression] multiset constructor uses insert_unique instead of insert_equal!

[paolo at gcc dot gnu dot org]

------- Comment #3 from paolo at gcc dot gnu dot org  2008-03-13 17:49 -------
Subject: Bug 35566

Author: paolo
Date: Thu Mar 13 17:48:21 2008
New Revision: 133175

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133175
Log:
2008-03-13  Dennis Czeremin  <dennis.czeremin@smiths-heimann.com>

        PR libstdc++/35566
        * include/bits/stl_multimap.h (multimap<>::multimap(_InputIterator,
        _InputIterator)): Forward to _M_insert_equal, not _M_insert_unique.


Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/stl_multimap.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566

[Bug libstdc++/35566] [4.3 Regression] multiset constructor uses insert_unique instead of insert_equal!

[paolo at gcc dot gnu dot org]

------- Comment #4 from paolo at gcc dot gnu dot org  2008-03-13 17:49 -------
Subject: Bug 35566

Author: paolo
Date: Thu Mar 13 17:48:42 2008
New Revision: 133176

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133176
Log:
2008-03-13  Dennis Czeremin  <dennis.czeremin@smiths-heimann.com>

        PR libstdc++/35566
        * include/bits/stl_multimap.h (multimap<>::multimap(_InputIterator,
        _InputIterator)): Forward to _M_insert_equal, not _M_insert_unique.


Modified:
    branches/gcc-4_3-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_3-branch/libstdc++-v3/include/bits/stl_multimap.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566

[Bug libstdc++/35566] [4.3 Regression] multiset constructor uses insert_unique instead of insert_equal!

[pcarlini at suse dot de]

------- Comment #5 from pcarlini at suse dot de  2008-03-13 17:49 -------
Fixed for 4.3.1.


-- 

pcarlini at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35566