public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test
@ 2008-03-17 2:11 danglin at gcc dot gnu dot org
2008-03-17 2:17 ` [Bug libgomp/35611] " danglin at gcc dot gnu dot org
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: danglin at gcc dot gnu dot org @ 2008-03-17 2:11 UTC (permalink / raw)
To: gcc-bugs
Executing on host: /home/dave/gnu/gcc-4.4/objdir/gcc/xgcc
-B/home/dave/gnu/gcc-4.4/objdir/gcc/
/home/dave/gnu/gcc-4.4/gcc/libgomp/testsuite/libgomp.c/omp-nested-1.c
-B/home/dave/gnu/gcc-4.4/objdir/hppa-linux/./libgomp/
-I/home/dave/gnu/gcc-4.4/objdir/hppa-linux/./libgomp
-I/home/dave/gnu/gcc-4.4/gcc/libgomp/testsuite/.. -fmessage-length=0 -fopenmp
-O2 -L/home/dave/gnu/gcc-4.4/objdir/hppa-linux/./libgomp/.libs -lgomp -lm
-o ./omp-nested-1.exe (timeout = 300)
PASS: libgomp.c/omp-nested-1.c (test for excess errors)
Setting LD_LIBRARY_PATH to
.:/home/dave/gnu/gcc-4.4/objdir/hppa-linux/./libgomp/.libs:/home/dave/gnu/gcc-4.4/objdir/gcc:.:/home/dave/gnu/gcc-4.4/objdir/hppa-linux/./libgomp/.libs:/home/dave/gnu/gcc-4.4/objdir/gcc:/home/dave/gnu/gcc-4.4/objdir/hppa-linux/libstdc++-v3/.libs:/home/dave/gnu/gcc-4.4/objdir/hppa-linux/libmudflap/.libs:/home/dave/gnu/gcc-4.4/objdir/hppa-linux/libssp/.libs:/home/dave/gnu/gcc-4.4/objdir/hppa-linux/libgomp/.libs:/home/dave/gnu/gcc-4.4/objdir/./gcc:/home/dave/gnu/gcc-4.4/objdir/./prev-gcc:/usr/lib/debug
FAIL: libgomp.c/omp-nested-1.c execution test
--
Summary: FAIL: libgomp.c/omp-nested-1.c execution test
Product: gcc
Version: 4.4.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libgomp
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: danglin at gcc dot gnu dot org
GCC build triplet: hppa-unknown-linux-gnu
GCC host triplet: hppa-unknown-linux-gnu
GCC target triplet: hppa-unknown-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libgomp/35611] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
@ 2008-03-17 2:17 ` danglin at gcc dot gnu dot org
2008-03-17 2:29 ` [Bug libgomp/35611] [4.3/4.4 Regression] " danglin at gcc dot gnu dot org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: danglin at gcc dot gnu dot org @ 2008-03-17 2:17 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from danglin at gcc dot gnu dot org 2008-03-17 02:16 -------
The test didn't fail in revision 133125.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libgomp/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
2008-03-17 2:17 ` [Bug libgomp/35611] " danglin at gcc dot gnu dot org
@ 2008-03-17 2:29 ` danglin at gcc dot gnu dot org
2008-03-17 13:33 ` kkojima at gcc dot gnu dot org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: danglin at gcc dot gnu dot org @ 2008-03-17 2:29 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from danglin at gcc dot gnu dot org 2008-03-17 02:29 -------
Same failure is also present on hppa2.0w-hp-hpux11.11 (4.3.1) and
hppa64-hp-hpux11.11 (4.4.0). There are quite a few other libgomp
fails that are probably the same bug.
--
danglin at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|FAIL: libgomp.c/omp-nested- |[4.3/4.4 Regression] FAIL:
|1.c execution test |libgomp.c/omp-nested-1.c
| |execution test
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libgomp/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
2008-03-17 2:17 ` [Bug libgomp/35611] " danglin at gcc dot gnu dot org
2008-03-17 2:29 ` [Bug libgomp/35611] [4.3/4.4 Regression] " danglin at gcc dot gnu dot org
@ 2008-03-17 13:33 ` kkojima at gcc dot gnu dot org
2008-03-18 0:10 ` danglin at gcc dot gnu dot org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: kkojima at gcc dot gnu dot org @ 2008-03-17 13:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from kkojima at gcc dot gnu dot org 2008-03-17 13:32 -------
Same on sh4-unknown-linux-gnu. It seems that they started
to fail after
r133162 | jakub | 2008-03-13 18:26:25 +0900 (Thu, 13 Mar 2008) | 7 lines
PR middle-end/35185
* omp-low.c (lower_regimplify, init_tmp_var, save_tmp_var): Removed.
(lower_omp_2): New function.
(lower_omp_1, lower_omp): Rewritten.
applied.
There is a libgomp failure on x86-linux with -march=i386
FAIL: libgomp.c/pr26943-4.c execution test
which doesn't fail on r133161, though I'm not sure it's
related with this PR.
--
kkojima at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kkojima at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug libgomp/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
` (2 preceding siblings ...)
2008-03-17 13:33 ` kkojima at gcc dot gnu dot org
@ 2008-03-18 0:10 ` danglin at gcc dot gnu dot org
2008-03-18 11:15 ` [Bug middle-end/35611] " jakub at gcc dot gnu dot org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: danglin at gcc dot gnu dot org @ 2008-03-18 0:10 UTC (permalink / raw)
To: gcc-bugs
--
danglin at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at redhat dot com
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2008-03-18 00:09:30
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug middle-end/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
` (3 preceding siblings ...)
2008-03-18 0:10 ` danglin at gcc dot gnu dot org
@ 2008-03-18 11:15 ` jakub at gcc dot gnu dot org
2008-03-18 12:22 ` jakub at gcc dot gnu dot org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu dot org @ 2008-03-18 11:15 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from jakub at gcc dot gnu dot org 2008-03-18 11:14 -------
Seems OMP_ATOMIC_LOAD isn't properly regimplified and so &i in TREE_OPERAND
(omp_atomic_load, 1) isn't replaced with .omp_data_i->i. For targets with
sync builtins this doesn't matter, as expand_omp_atomic for them runs all
addr references through force_gimple_operand_bsi and thus it is gimplified at
expand_omp time. But the expand_omp_atomic_mutex fallback just assumes the
address is gimple value.
Here is a fix I'll be testing (though for hppa-linux I can only eyeball the
assembly).
2008-03-18 Jakub Jelinek <jakub@redhat.com>
PR middle-end/35611
* gimplify.c (gimplify_expr): Gimplify second operand of
OMP_ATOMIC_LOAD.
--- gcc/gimplify.c.jj 2008-03-06 18:45:59.000000000 +0100
+++ gcc/gimplify.c 2008-03-18 11:55:04.000000000 +0100
@@ -6022,12 +6022,18 @@ gimplify_expr (tree *expr_p, tree *pre_p
case OMP_RETURN:
case OMP_CONTINUE:
- case OMP_ATOMIC_LOAD:
- case OMP_ATOMIC_STORE:
-
+ case OMP_ATOMIC_STORE:
ret = GS_ALL_DONE;
break;
+ case OMP_ATOMIC_LOAD:
+ if (gimplify_expr (&TREE_OPERAND (*expr_p, 1), pre_p, NULL,
+ is_gimple_val, fb_rvalue) != GS_ALL_DONE)
+ ret = GS_ERROR;
+ else
+ ret = GS_ALL_DONE;
+ break;
+
case POINTER_PLUS_EXPR:
/* Convert ((type *)A)+offset into &A->field_of_type_and_offset.
The second is gimple immediate saving a need for extra statement.
libgomp.c/pr26943-4.c used to fail intermitently before
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132977
but I certainly can't reproduce it with current trunk or 4.3, and I don't see
how this could be related to this - even -m32 -march=i386 has the needed sync
builtins - both QImode and SImode lock; add{b,l}.
--
jakub at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |jakub at gcc dot gnu dot org
|dot org |
Status|NEW |ASSIGNED
Component|libgomp |middle-end
Last reconfirmed|2008-03-18 00:09:30 |2008-03-18 11:14:25
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug middle-end/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
` (4 preceding siblings ...)
2008-03-18 11:15 ` [Bug middle-end/35611] " jakub at gcc dot gnu dot org
@ 2008-03-18 12:22 ` jakub at gcc dot gnu dot org
2008-03-18 12:33 ` jakub at gcc dot gnu dot org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu dot org @ 2008-03-18 12:22 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from jakub at gcc dot gnu dot org 2008-03-18 12:21 -------
Subject: Bug 35611
Author: jakub
Date: Tue Mar 18 12:21:02 2008
New Revision: 133309
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133309
Log:
PR middle-end/35611
* gimplify.c (gimplify_expr): Gimplify second operand of
OMP_ATOMIC_LOAD.
* testsuite/libgomp.c/atomic-4.c: New test.
Added:
trunk/libgomp/testsuite/libgomp.c/atomic-4.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/gimplify.c
trunk/libgomp/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug middle-end/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
` (5 preceding siblings ...)
2008-03-18 12:22 ` jakub at gcc dot gnu dot org
@ 2008-03-18 12:33 ` jakub at gcc dot gnu dot org
2008-03-18 12:42 ` jakub at gcc dot gnu dot org
2008-03-30 21:10 ` pinskia at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu dot org @ 2008-03-18 12:33 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from jakub at gcc dot gnu dot org 2008-03-18 12:32 -------
Subject: Bug 35611
Author: jakub
Date: Tue Mar 18 12:31:28 2008
New Revision: 133310
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=133310
Log:
PR middle-end/35611
* gimplify.c (gimplify_expr): Gimplify second operand of
OMP_ATOMIC_LOAD.
* testsuite/libgomp.c/atomic-4.c: New test.
Added:
branches/gcc-4_3-branch/libgomp/testsuite/libgomp.c/atomic-4.c
Modified:
branches/gcc-4_3-branch/gcc/ChangeLog
branches/gcc-4_3-branch/gcc/gimplify.c
branches/gcc-4_3-branch/libgomp/ChangeLog
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug middle-end/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
` (6 preceding siblings ...)
2008-03-18 12:33 ` jakub at gcc dot gnu dot org
@ 2008-03-18 12:42 ` jakub at gcc dot gnu dot org
2008-03-30 21:10 ` pinskia at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu dot org @ 2008-03-18 12:42 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from jakub at gcc dot gnu dot org 2008-03-18 12:41 -------
Fixed.
--
jakub at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug middle-end/35611] [4.3/4.4 Regression] FAIL: libgomp.c/omp-nested-1.c execution test
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
` (7 preceding siblings ...)
2008-03-18 12:42 ` jakub at gcc dot gnu dot org
@ 2008-03-30 21:10 ` pinskia at gcc dot gnu dot org
8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-03-30 21:10 UTC (permalink / raw)
To: gcc-bugs
--
pinskia at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.3.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35611
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-03-30 21:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-17 2:11 [Bug libgomp/35611] New: FAIL: libgomp.c/omp-nested-1.c execution test danglin at gcc dot gnu dot org
2008-03-17 2:17 ` [Bug libgomp/35611] " danglin at gcc dot gnu dot org
2008-03-17 2:29 ` [Bug libgomp/35611] [4.3/4.4 Regression] " danglin at gcc dot gnu dot org
2008-03-17 13:33 ` kkojima at gcc dot gnu dot org
2008-03-18 0:10 ` danglin at gcc dot gnu dot org
2008-03-18 11:15 ` [Bug middle-end/35611] " jakub at gcc dot gnu dot org
2008-03-18 12:22 ` jakub at gcc dot gnu dot org
2008-03-18 12:33 ` jakub at gcc dot gnu dot org
2008-03-18 12:42 ` jakub at gcc dot gnu dot org
2008-03-30 21:10 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).