public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "burnus at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/35723] Can't use run-time array element in character declaration Date: Fri, 28 Mar 2008 19:40:00 -0000 [thread overview] Message-ID: <20080328194015.28039.qmail@sourceware.org> (raw) In-Reply-To: <bug-35723-15620@http.gcc.gnu.org/bugzilla/> ------- Comment #1 from burnus at gcc dot gnu dot org 2008-03-28 19:40 ------- Confirmed. A simple patch would be the following: Index: expr.c =================================================================== --- expr.c (Revision 133693) +++ expr.c (Arbeitskopie) @@ -2502,6 +2502,7 @@ check_restricted (gfc_expr *e) || sym->attr.use_assoc || sym->attr.dummy || sym->attr.implied_index + || sym->attr.flavor == FL_PARAMETER || sym->ns != gfc_current_ns || (sym->ns->proc_name != NULL && sym->ns->proc_name->attr.flavor == FL_MODULE) However, this also accepts the following invalid program (note the "i"): program try_vf0016 call vf0016( 1, 2, 3) end SUBROUTINE VF0016(nf1,nf2,nf3) CHARACTER(LEN=9,KIND=1),DIMENSION(3) , PARAMETER $ :: TEST_STRINGS = $ (/' HI','ABC ',' CDEFG '/) integer :: i = 2 CHARACTER :: TEST_ARRAY $(LEN_TRIM(ADJUSTL(TEST_STRINGS(i))), ! changing nf1 to 1 fixes it $ SUM(LEN_TRIM(ADJUSTL(TEST_STRINGS))), $ LEN_TRIM(ADJUSTL(ADJUSTR(TEST_STRINGS(3)))), $ SUM(LEN_TRIM(ADJUSTL(ADJUSTR(TEST_STRINGS(NF1:NF3:NF2))))) ) print *, 2, 10, 5, 7 print *, shape (test_array) end We therefore need to loop over expr->ref and check_restricted() these expressions as well. I think that we can throw in another half a dozen checks as well. ;-) -- burnus at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |burnus at gcc dot gnu dot | |org Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Keywords| |rejects-valid Last reconfirmed|0000-00-00 00:00:00 |2008-03-28 19:40:15 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35723
next prev parent reply other threads:[~2008-03-28 19:40 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-27 20:34 [Bug fortran/35723] New: " dick dot hendrickson at gmail dot com 2008-03-28 19:40 ` burnus at gcc dot gnu dot org [this message] 2008-09-24 10:01 ` [Bug fortran/35723] " domob at gcc dot gnu dot org 2008-09-25 10:30 ` domob at gcc dot gnu dot org 2008-10-09 7:31 ` domob at gcc dot gnu dot org 2008-10-09 7:35 ` domob at gcc dot gnu dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080328194015.28039.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).