From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14785 invoked by alias); 6 Apr 2008 16:23:06 -0000 Received: (qmail 14637 invoked by uid 48); 6 Apr 2008 16:22:20 -0000 Date: Sun, 06 Apr 2008 16:23:00 -0000 Message-ID: <20080406162220.14636.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug fortran/27997] Fortran 2003: Support type-spec for array constructor In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "burnus at gcc dot gnu dot org" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg00476.txt.bz2 ------- Comment #22 from burnus at gcc dot gnu dot org 2008-04-06 16:22 ------- > Created an attachment (id=15435) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15435&action=view) [edit] > Handles bounds checking and fixes regressions. Great. > However, I'm not quite sure about some things I did [...] I think your patch is in a good enough shape to post it to fortran@gcc.gnu.org and ask there for comments; this ensures that all gfortraners read it (and not only three Fortraners) and it makes discussing easier than a in a bugreport. I think one could also submit it for review, which means that you need to write a changelog and should CC the email to gcc-patches@. (The reason is that then also developers of the middle end can glance at it and give comments.) +/* XXX: Ok as global or does bounds-checking need to be reentrant for things + like nested constructors? */ I think it is OK for now, but we need to fix it later. I found a test case which crashes gfortran (ICE, internal compiler error) for nested character constructors - even without typespec or bounds checks. See PR 35846. I think this should be fixed together with the rest. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27997