[Bug debug/35896] New: gfortran TLS symbols broken with debug info

[Bug debug/35896] New: gfortran TLS symbols broken with debug info

[janis at gcc dot gnu dot org]

Four tests in libgomp.fortran (omp_parse3.f90, pr25162.f, and
threadprivate[23].f90 started failing with this patch:

  http://gcc.gnu.org/viewcvs?view=rev&rev=133801
  r133801 | george | 2008-04-01 17:23:36 -0400 (Tue, 01 Apr 2008)

This small testcase fails in the same way when compiled with "-m64 -g
-fopenmp":

      program test
      call foo
      end
      subroutine foo
      real testvar
      common /testcom/ testvar
c$omp threadprivate(/testcom/)
      testvar = 1.0
      return
      end

Output:

elm3b145% /opt/gcc-nightly/trunk-20080406/bin/gfortran -g -m64 -fopenmp tls1.f
-lgomp
/opt/gcc-nightly/binutils-2.18/bin/ld: /tmp/cc0dFrjq.o(.debug_info+0x74):
R_PPC64_ADDR64 used with TLS symbol testcom_

I'll attach the .s files for revisions 133800 and 133801 for the same source
but without the first three lines.


-- 
           Summary: gfortran TLS symbols broken with debug info
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janis at gcc dot gnu dot org
GCC target triplet: powerpc64-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] gfortran TLS symbols broken with debug info

[janis at gcc dot gnu dot org]

------- Comment #1 from janis at gcc dot gnu dot org  2008-04-09 22:46 -------
Created an attachment (id=15462)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15462&action=view)
generated code before patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] gfortran TLS symbols broken with debug info

[janis at gcc dot gnu dot org]

------- Comment #2 from janis at gcc dot gnu dot org  2008-04-09 22:47 -------
Created an attachment (id=15463)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15463&action=view)
generated code after patch


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] gfortran TLS symbols broken with debug info

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |openmp
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] [4.4 Regression] gfortran TLS symbols broken with debug info

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2008-04-09 22:50 -------
I think we are emitting the debug info too early for _testcom before we marked
it as a TLS.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|gfortran TLS symbols broken |[4.4 Regression] gfortran
                   |with debug info             |TLS symbols broken with
                   |                            |debug info


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] [4.4 Regression] gfortran TLS symbols broken with debug info

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2008-04-09 22:51 -------
Before:
        .quad   testcom_@dtprel+0x8000

After:
        .8byte  testcom_


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] [4.4 Regression] gfortran TLS symbols broken with debug info

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2008-04-09 22:54 -------
Actually we just don't take into account  TLSness of the decl/RTL.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] [4.4 Regression] gfortran TLS symbols broken with debug info

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] [4.4 Regression] gfortran TLS symbols broken with debug info

[jakub at gcc dot gnu dot org]

-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |04/msg02114.html
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-04-29 16:07:37
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] [4.4 Regression] gfortran TLS symbols broken with debug info

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2008-05-07 23:16 -------
Subject: Bug 35896

Author: jakub
Date: Wed May  7 23:15:50 2008
New Revision: 135060

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135060
Log:
        PR debug/35896
        * dwarf2out.c (dw_expand_expr, common_check): Removed.
        (fortran_common): New function.
        (gen_variable_die): Call fortran_common instead of common_check,
        adjust for it returning tree instead of rtx.    Formatting.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dwarf2out.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896

[Bug debug/35896] [4.4 Regression] gfortran TLS symbols broken with debug info

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2008-05-25 20:24 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35896