[Bug ada/35050] New: renames entities not in symbol table

[Bug ada/35050] New: renames entities not in symbol table

[meudecc at itcarlow dot ie]

The example below illustrate that the .ali files do not always contain renamed
subprograms references:
>>>
--pb_renaming.ads
package pb_renaming is
  function Plus(X, Y: Integer) return Integer;
  function My_plus(X, Y: Integer) return Integer renames Plus;
  function Add(X, Y: Integer) return Integer renames "+";
  A : Integer;          
end pb_renaming;
>>>
--pb_renaming.adb
package body pb_renaming is
  function Plus(X, Y: Integer) return Integer is
  begin
    return X+Y; 
  end Plus;
begin
  --below, Add is properly cross-referenced by gnatxref in gnat v3.4.1 but not
in gnat v4.1.3
  --below, My_plus is never properly cross-referenced according to gnatxref
output
  A := Add(4, 6) + My_plus(4, 6);
end pb_renaming;
>>

Gnatxref output extract:
My_plus                                          function
  Decl:  pb_renaming.ads        3:12

Reference entry is missing for My_plus

regards,
chris


-- 
           Summary: renames entities not in symbol table
           Product: gcc
           Version: 4.1.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: meudecc at itcarlow dot ie


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050

[Bug ada/35050] renames entities not in symbol table

[sam at gcc dot gnu dot org]

-- 

sam at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |sam at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-02-25 23:37:44
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050

[Bug ada/35050] [4.x regression] renames entities not in symbol table

[tero dot koskinen at iki dot fi]

------- Comment #1 from tero dot koskinen at iki dot fi  2008-02-29 15:50 -------
I think the problem is in Xref_lib package (xref_lib.adb). It doesn't parse the
current .ali file format properly.

The patch (against gcc-trunk r131693) at
http://iki.fi/tero.koskinen/gcc/gcc-ada-xref_lib_adb.diff fixes parsing for me.

Some details:
The code expects .ali file format for renamings to be:
4V12*My_plus{integer}=4:58 2|11r20

But if I understood the code correctly, the format is:
4V12*My_plus=4:58{integer} 2|11r20

The patch moves =NUMBER:NUMBER handling before {integer}&co. handling.

gnatxref output after the patch:
Add                                              function
  Decl:  pb_renaming.ads        5:12
  Ref:   pb_renaming.adb       11:8
My_plus                                          function
  Decl:  pb_renaming.ads        4:12
  Ref:   pb_renaming.adb       11:20

I haven't tested very complex cases, but for random gtkada code the patch
seemed to work.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050

[Bug ada/35050] [4.x regression] renames entities not in symbol table

[tero dot koskinen at iki dot fi]

------- Comment #2 from tero dot koskinen at iki dot fi  2008-02-29 15:52 -------
Created an attachment (id=15246)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15246&action=view)
Fix .ali file parsing in xref_lib.adb.

The patch attached in case the url doesn't work.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050

[Bug ada/35050] [4.x regression] renames entities not in symbol table

[sam at gcc dot gnu dot org]

------- Comment #3 from sam at gcc dot gnu dot org  2008-02-29 16:10 -------
Tero,

your patch is similar to the one I proposed a few days ago :)

http://thread.gmane.org/gmane.comp.gcc.patches/157295


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050

[Bug ada/35050] [4.1/4.2/4.3/4.4 regression] renames entities not in symbol table

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
            Summary|[4.x regression] renames    |[4.1/4.2/4.3/4.4 regression]
                   |entities not in symbol table|renames entities not in
                   |                            |symbol table
   Target Milestone|---                         |4.1.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050

[Bug ada/35050] [4.1/4.2/4.3/4.4 regression] renames entities not in symbol table

[sam at gcc dot gnu dot org]

------- Comment #4 from sam at gcc dot gnu dot org  2008-04-14 09:39 -------
Subject: Bug 35050

Author: sam
Date: Mon Apr 14 09:38:34 2008
New Revision: 134256

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134256
Log:
    gcc/ada/
        PR ada/35050
        * xref_lib.adb (Parse_Identifier_Info): Correctly parse and ignore the
        renaming information.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/xref_lib.adb


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050

[Bug ada/35050] [4.1/4.2/4.3/4.4 regression] renames entities not in symbol table

[sam at gcc dot gnu dot org]

------- Comment #5 from sam at gcc dot gnu dot org  2008-04-14 09:42 -------
Bug fixed in SVN version.


-- 

sam at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.1.3                       |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35050