public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug middle-end/35897] New: DSE doesn't support targets with wide registers @ 2008-04-10 0:39 hjl dot tools at gmail dot com 2008-04-10 0:41 ` [Bug middle-end/35897] " pinskia at gcc dot gnu dot org ` (7 more replies) 0 siblings, 8 replies; 9+ messages in thread From: hjl dot tools at gmail dot com @ 2008-04-10 0:39 UTC (permalink / raw) To: gcc-bugs dse.c has struct store_info { ... /* An bitmask as wide as the number of bytes in the word that contains a 1 if the byte may be needed. The store is unused if all of the bits are 0. */ long positions_needed; }; ... record_store () { ... gcc_assert ((unsigned) width < sizeof (store_info->positions_needed) * CHAR_BIT); ... } AVX register is 32byte wide. On ia32, since width is 32 and long is 4 byte, assert fails. This scheme doesn't work. How should it be fixed? -- Summary: DSE doesn't support targets with wide registers Product: gcc Version: 4.3.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: middle-end AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: hjl dot tools at gmail dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com @ 2008-04-10 0:41 ` pinskia at gcc dot gnu dot org 2008-04-10 0:54 ` hjl at gcc dot gnu dot org ` (6 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: pinskia at gcc dot gnu dot org @ 2008-04-10 0:41 UTC (permalink / raw) To: gcc-bugs ------- Comment #1 from pinskia at gcc dot gnu dot org 2008-04-10 00:41 ------- Well first it should be made HOST_WIDE_INT and x86 should move over to 64bit HWI. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com 2008-04-10 0:41 ` [Bug middle-end/35897] " pinskia at gcc dot gnu dot org @ 2008-04-10 0:54 ` hjl at gcc dot gnu dot org 2008-04-10 13:33 ` hjl dot tools at gmail dot com ` (5 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: hjl at gcc dot gnu dot org @ 2008-04-10 0:54 UTC (permalink / raw) To: gcc-bugs ------- Comment #2 from hjl at gcc dot gnu dot org 2008-04-10 00:53 ------- Subject: Bug 35897 Author: hjl Date: Thu Apr 10 00:53:04 2008 New Revision: 134160 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134160 Log: 2008-04-09 H.J. Lu <hongjiu.lu@intel.com> PR middle-end/35897 * dse.c (store_info): Use long long on positions_needed. Added: branches/ix86/avx/gcc/ChangeLog.avx Modified: branches/ix86/avx/gcc/dse.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com 2008-04-10 0:41 ` [Bug middle-end/35897] " pinskia at gcc dot gnu dot org 2008-04-10 0:54 ` hjl at gcc dot gnu dot org @ 2008-04-10 13:33 ` hjl dot tools at gmail dot com 2008-04-10 14:07 ` hjl at gcc dot gnu dot org ` (4 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: hjl dot tools at gmail dot com @ 2008-04-10 13:33 UTC (permalink / raw) To: gcc-bugs ------- Comment #3 from hjl dot tools at gmail dot com 2008-04-10 13:32 ------- A patch is posted at http://gcc.gnu.org/ml/gcc-patches/2008-04/msg00837.html -- hjl dot tools at gmail dot com changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://gcc.gnu.org/ml/gcc- | |patches/2008- | |04/msg00837.html Keywords| |patch http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com ` (2 preceding siblings ...) 2008-04-10 13:33 ` hjl dot tools at gmail dot com @ 2008-04-10 14:07 ` hjl at gcc dot gnu dot org 2008-04-11 15:53 ` hjl at gcc dot gnu dot org ` (3 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: hjl at gcc dot gnu dot org @ 2008-04-10 14:07 UTC (permalink / raw) To: gcc-bugs ------- Comment #4 from hjl at gcc dot gnu dot org 2008-04-10 14:06 ------- Subject: Bug 35897 Author: hjl Date: Thu Apr 10 14:05:52 2008 New Revision: 134163 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134163 Log: 2008-04-09 H.J. Lu <hongjiu.lu@intel.com> PR middle-end/35897 * dse.c (store_info): Add a FIXME for positions_needed. (fill_bitmask): New. (record_store): Assert width <= size of positions_needed * CHAR_BIT. Call fill_bitmask to initialize positions_needed. (check_mem_read_rtx): Use long on mask. Call fill_bitmask to set mask. Modified: branches/ix86/avx/gcc/ChangeLog.avx branches/ix86/avx/gcc/dse.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com ` (3 preceding siblings ...) 2008-04-10 14:07 ` hjl at gcc dot gnu dot org @ 2008-04-11 15:53 ` hjl at gcc dot gnu dot org 2008-04-11 15:57 ` hjl at gcc dot gnu dot org ` (2 subsequent siblings) 7 siblings, 0 replies; 9+ messages in thread From: hjl at gcc dot gnu dot org @ 2008-04-11 15:53 UTC (permalink / raw) To: gcc-bugs ------- Comment #5 from hjl at gcc dot gnu dot org 2008-04-11 15:53 ------- Subject: Bug 35897 Author: hjl Date: Fri Apr 11 15:52:19 2008 New Revision: 134199 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134199 Log: 2008-04-11 H.J. Lu <hongjiu.lu@intel.com> PR middle-end/35897 * dse.c (store_info): Change positions_needed to unsigned HOST_WIDE_INT. (lowpart_bitmask): New. (record_store): Cast to unsigned HOST_WIDE_INT for positions_needed. Assert width <= size of positions_needed * CHAR_BIT. Call lowpart_bitmask to initialize positions_needed. (check_mem_read_rtx): Use unsigned HOST_WIDE_INT on mask. Call lowpart_bitmask to set mask. Modified: trunk/gcc/ChangeLog trunk/gcc/dse.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com ` (4 preceding siblings ...) 2008-04-11 15:53 ` hjl at gcc dot gnu dot org @ 2008-04-11 15:57 ` hjl at gcc dot gnu dot org 2008-04-16 9:07 ` steven at gcc dot gnu dot org 2008-04-16 12:57 ` hjl dot tools at gmail dot com 7 siblings, 0 replies; 9+ messages in thread From: hjl at gcc dot gnu dot org @ 2008-04-11 15:57 UTC (permalink / raw) To: gcc-bugs ------- Comment #6 from hjl at gcc dot gnu dot org 2008-04-11 15:56 ------- Subject: Bug 35897 Author: hjl Date: Fri Apr 11 15:55:57 2008 New Revision: 134200 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134200 Log: 2008-04-11 H.J. Lu <hongjiu.lu@intel.com> PR middle-end/35897 * dse.c (store_info): Change positions_needed to unsigned HOST_WIDE_INT. (lowpart_bitmask): New. (record_store): Cast to unsigned HOST_WIDE_INT for positions_needed. Assert width <= size of positions_needed * CHAR_BIT. Call lowpart_bitmask to initialize positions_needed. (check_mem_read_rtx): Use unsigned HOST_WIDE_INT on mask. Call lowpart_bitmask to set mask. Modified: branches/ix86/avx/gcc/ChangeLog.avx branches/ix86/avx/gcc/dse.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com ` (5 preceding siblings ...) 2008-04-11 15:57 ` hjl at gcc dot gnu dot org @ 2008-04-16 9:07 ` steven at gcc dot gnu dot org 2008-04-16 12:57 ` hjl dot tools at gmail dot com 7 siblings, 0 replies; 9+ messages in thread From: steven at gcc dot gnu dot org @ 2008-04-16 9:07 UTC (permalink / raw) To: gcc-bugs ------- Comment #7 from steven at gcc dot gnu dot org 2008-04-16 09:07 ------- Fixed, or what? -- steven at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |WAITING http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug middle-end/35897] DSE doesn't support targets with wide registers 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com ` (6 preceding siblings ...) 2008-04-16 9:07 ` steven at gcc dot gnu dot org @ 2008-04-16 12:57 ` hjl dot tools at gmail dot com 7 siblings, 0 replies; 9+ messages in thread From: hjl dot tools at gmail dot com @ 2008-04-16 12:57 UTC (permalink / raw) To: gcc-bugs ------- Comment #8 from hjl dot tools at gmail dot com 2008-04-16 12:56 ------- Fixed. -- hjl dot tools at gmail dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|WAITING |RESOLVED Resolution| |FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35897 ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-04-16 12:57 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2008-04-10 0:39 [Bug middle-end/35897] New: DSE doesn't support targets with wide registers hjl dot tools at gmail dot com 2008-04-10 0:41 ` [Bug middle-end/35897] " pinskia at gcc dot gnu dot org 2008-04-10 0:54 ` hjl at gcc dot gnu dot org 2008-04-10 13:33 ` hjl dot tools at gmail dot com 2008-04-10 14:07 ` hjl at gcc dot gnu dot org 2008-04-11 15:53 ` hjl at gcc dot gnu dot org 2008-04-11 15:57 ` hjl at gcc dot gnu dot org 2008-04-16 9:07 ` steven at gcc dot gnu dot org 2008-04-16 12:57 ` hjl dot tools at gmail dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).