From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24501 invoked by alias); 18 Apr 2008 16:24:36 -0000 Received: (qmail 24312 invoked by uid 48); 18 Apr 2008 16:23:53 -0000 Date: Fri, 18 Apr 2008 16:24:00 -0000 Message-ID: <20080418162353.24311.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug fortran/35892] [4.4 regression] gfortran dies on file containing module and common In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "jvdelisle at gcc dot gnu dot org" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg01299.txt.bz2 ------- Comment #6 from jvdelisle at gcc dot gnu dot org 2008-04-18 16:23 ------- Regression hunt complete. The offending patch is: Revision 133801 - (view) (download) - [select for diffs] Modified Tue Apr 1 21:23:36 2008 UTC (2 weeks, 2 days ago) by george File length: 35842 byte(s) Diff to previous 132592 (colored) * fortran/trans-common.c (create_common): Add decl to function chain to preserve identifier scope in debug output. --- trunk/gcc/fortran/trans-common.c 2008/02/24 16:43:23 132592 +++ trunk/gcc/fortran/trans-common.c 2008/04/01 21:23:36 133801 @@ -687,10 +687,7 @@ /* This is a fake variable just for debugging purposes. */ TREE_ASM_WRITTEN (var_decl) = 1; - if (com) - var_decl = pushdecl_top_level (var_decl); - else - gfc_add_decl_to_function (var_decl); + gfc_add_decl_to_function (var_decl); SET_DECL_VALUE_EXPR (var_decl, fold_build3 (COMPONENT_REF, TREE_TYPE (s->field), I have cc'ed George on this. Shall we revert? -- jvdelisle at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at gcc dot gnu dot | |org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35892