* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
@ 2006-03-20 19:40 ` pedz at easesoftware dot net
2006-07-25 15:23 ` mjuric at astro dot princeton dot edu
` (7 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: pedz at easesoftware dot net @ 2006-03-20 19:40 UTC (permalink / raw)
To: gcc-bugs
------- Comment #5 from pedz at easesoftware dot net 2006-03-20 19:40 -------
This is also on 4.0.2.
This is marked as Serverity of "enhancement". Can we change that to "normal"?
--
pedz at easesoftware dot net changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pedz at easesoftware dot net
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
2006-03-20 19:40 ` [Bug pch/14933] missing pre-compiled header depends with -MD pedz at easesoftware dot net
@ 2006-07-25 15:23 ` mjuric at astro dot princeton dot edu
2007-01-27 20:03 ` tromey at gcc dot gnu dot org
` (6 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: mjuric at astro dot princeton dot edu @ 2006-07-25 15:23 UTC (permalink / raw)
To: gcc-bugs
------- Comment #6 from mjuric at astro dot princeton dot edu 2006-07-25 15:22 -------
Created an attachment (id=11935)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11935&action=view)
Proposed fix for improper dependency tracking with PCHs
This short patch addresses the issue of precompiled header dependencies not
being recorded during -MD pass. The problem appeared because deps_add_dep() was
never called from _cpp_stack_file, as all of .gch handling is done in
should_stack_file().
The patch fixes it by calling deps_add_dep() in should_stack_file(), if the
file under consideration is a precompiled header, and if restoration of
dependencies from .gch has not been requested (restore_pch_deps == false).
Applies to HEAD as well as 4.1.1.
PS: This revealed a separate issue with counterintuitive behavior of
restore_pch_deps == true (no dependencies shown), which I'll submit as a
separate bug and proposed patch.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
2006-03-20 19:40 ` [Bug pch/14933] missing pre-compiled header depends with -MD pedz at easesoftware dot net
2006-07-25 15:23 ` mjuric at astro dot princeton dot edu
@ 2007-01-27 20:03 ` tromey at gcc dot gnu dot org
2007-11-28 19:07 ` tromey at gcc dot gnu dot org
` (5 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2007-01-27 20:03 UTC (permalink / raw)
To: gcc-bugs
------- Comment #7 from tromey at gcc dot gnu dot org 2007-01-27 20:03 -------
This patch looks reasonable to me, though I cannot approve it.
The formatting is slightly wrong, there should be a space
between the "if" and the "(".
Also a ChangeLog entry is required.
--
tromey at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at gcc dot gnu dot
| |org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2007-01-27 20:03 ` tromey at gcc dot gnu dot org
@ 2007-11-28 19:07 ` tromey at gcc dot gnu dot org
2008-03-14 21:26 ` tromey at gcc dot gnu dot org
` (4 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2007-11-28 19:07 UTC (permalink / raw)
To: gcc-bugs
------- Comment #8 from tromey at gcc dot gnu dot org 2007-11-28 19:07 -------
*** Bug 33473 has been marked as a duplicate of this bug. ***
--
tromey at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rswan at signetic dot ca
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2007-11-28 19:07 ` tromey at gcc dot gnu dot org
@ 2008-03-14 21:26 ` tromey at gcc dot gnu dot org
2008-04-20 19:00 ` tromey at gcc dot gnu dot org
` (3 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2008-03-14 21:26 UTC (permalink / raw)
To: gcc-bugs
------- Comment #9 from tromey at gcc dot gnu dot org 2008-03-14 21:25 -------
I'm testing this patch.
--
tromey at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |tromey at gcc dot gnu dot
|dot org |org
Status|NEW |ASSIGNED
Last reconfirmed|2005-07-07 13:36:12 |2008-03-14 21:26:00
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2008-03-14 21:26 ` tromey at gcc dot gnu dot org
@ 2008-04-20 19:00 ` tromey at gcc dot gnu dot org
2008-04-20 23:56 ` pedz at easesoftware dot com
` (2 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: tromey at gcc dot gnu dot org @ 2008-04-20 19:00 UTC (permalink / raw)
To: gcc-bugs
------- Comment #10 from tromey at gcc dot gnu dot org 2008-04-20 18:59 -------
FYI -- when I tried this on the compile farm tester, it caused a couple
regressions. I'll redo it at some point and post the results here.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2008-04-20 19:00 ` tromey at gcc dot gnu dot org
@ 2008-04-20 23:56 ` pedz at easesoftware dot com
2008-11-03 22:35 ` pinskia at gcc dot gnu dot org
2010-06-04 20:11 ` kristiaan dot lenaerts at gmail dot com
8 siblings, 0 replies; 13+ messages in thread
From: pedz at easesoftware dot com @ 2008-04-20 23:56 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
------- Comment #11 from pedz at easesoftware dot com 2008-04-20 23:56 -------
Subject: Re: missing pre-compiled header depends with -MD
This message has been marked as "junk" or "spam". There is a very
good chance that I will not read it. So, please send this message
again but add the word "magic special code" without the spaces (all
one word) in the message and it is suppose to slip through and get to
me.
On Apr 20, 2008, at 1:59 PM, "tromey at gcc dot gnu dot org"
<gcc-bugzilla@gcc.gnu.org
> wrote:
>
>
> ------- Comment #10 from tromey at gcc dot gnu dot org 2008-04-20
> 18:59 -------
> FYI -- when I tried this on the compile farm tester, it caused a
> couple
> regressions. I'll redo it at some point and post the results here.
>
>
> --
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
>
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.
>
This message has been marked as "junk" or "spam". There is a very
good chance that I will not read it. So, please send this message
again but add the word "magic special code" without the spaces (all
one word) in the message and it is suppose to slip through and get to
me.
On Apr 20, 2008, at 1:59 PM, "tromey at gcc dot gnu dot org"
<<gcc-bugzilla@gcc.gnu.org> wrote:
<excerpt><fontfamily><param>Times</param><bigger><bigger>
------- Comment #10 from tromey at gcc dot gnu dot org 2008-04-20
18:59 -------
FYI -- when I tried this on the compile farm tester, it caused a couple
regressions. I'll redo it at some point and post the results here.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
</bigger></bigger></fontfamily></excerpt>
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2008-04-20 23:56 ` pedz at easesoftware dot com
@ 2008-11-03 22:35 ` pinskia at gcc dot gnu dot org
2010-06-04 20:11 ` kristiaan dot lenaerts at gmail dot com
8 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-11-03 22:35 UTC (permalink / raw)
To: gcc-bugs
------- Comment #12 from pinskia at gcc dot gnu dot org 2008-11-03 22:33 -------
Any news on this patch?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug pch/14933] missing pre-compiled header depends with -MD
[not found] <bug-14933-8321@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2008-11-03 22:35 ` pinskia at gcc dot gnu dot org
@ 2010-06-04 20:11 ` kristiaan dot lenaerts at gmail dot com
8 siblings, 0 replies; 13+ messages in thread
From: kristiaan dot lenaerts at gmail dot com @ 2010-06-04 20:11 UTC (permalink / raw)
To: gcc-bugs
------- Comment #13 from kristiaan dot lenaerts at gmail dot com 2010-06-04 20:10 -------
Created an attachment (id=20847)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20847&action=view)
Updated fix for improper PCH dependency tracking
I got hit by this bug a few weeks ago when working on a C++ project. This
project has a setup for which using -fpch-deps will not work, most pch files
include local headers that have to be referenced by their complete path
elsewhere.
I rebased the proposed fix from Mario on the 4.5 branch (I created it when 4.5
was not yet out). I'm using this patch for about a month now without any
obvious problems, but I would like to get this in mainline.
What are the steps that I should take? I have not yet run the testsuite. (this
is on a corporate laptop running under cygwin - windows XP and full
hd-encryption - so compiling gcc was painfull, and I imagine running the
testsuite will be worse)
Would it be ok if I run the testsuite on cygwin with and without the patch, and
if the results are the same submit this patch to gcc-patches (with meaningfull
changelog entry)? I could also test on a x64_64-pc-linux-gnu machine at home,
but it could take a while before I can test there.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14933
^ permalink raw reply [flat|nested] 13+ messages in thread