[Bug ada/35998] New: debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[Bug ada/35998] New: debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[jan dot kratochvil at redhat dot com]

The source:

procedure AdaFF is
  type rec is
    record
      null;
    end record;
  X : rec;
begin
  null;
end AdaFF;

produces output by:
$ rm -f adaff{,.o,.ali};gnatmake -g adaff.adb ;readelf -a --debug-dump adaff |
grep 'DW_AT_byte_size.*0xffff'
    <30b>   DW_AT_byte_size   : 0xffffffff      

 <1><306>: Abbrev Number: 20 (DW_TAG_structure_type)
    <307>   DW_AT_name        : (indirect string, offset: 0x3c8):
ada_main__main__TsehB___XUT
    <30b>   DW_AT_byte_size   : 0xffffffff
    <30f>   DW_AT_decl_file   : 1
    <310>   DW_AT_decl_line   : 105
    <311>   DW_AT_sibling     : <0x33b>

A more complicated testcase
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.ada/packed_tagged/comp_bug.adb?rev=1.1&cvsroot=src
crashes GDB eating all the memory on `print x' there.


-- 
           Summary: debug info invalid x86_64 DW_AT_byte_size 0xffffffff
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: jan dot kratochvil at redhat dot com
 GCC build triplet: x86_64-fedora-linux-gnu
  GCC host triplet: x86_64-fedora-linux-gnu
GCC target triplet: x86_64-fedora-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[jan dot kratochvil at redhat dot com]

------- Comment #1 from jan dot kratochvil at redhat dot com  2008-04-21 12:40 -------
Created an attachment (id=15503)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15503&action=view)
GDB workaround.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[jan dot kratochvil at redhat dot com]

------- Comment #2 from jan dot kratochvil at redhat dot com  2008-05-19 22:19 -------
Created an attachment (id=15654)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15654&action=view)
GCC fix.

Omit the whole attribute DW_AT_byte_size 0xffffffff.
GCC testsuite ran on x86 and x86_64.
GDB with this patch still produces invalid output on packed_tagged.exp but at
least GDB does not crash.
Sure the right way would be for GNAT to output the full DWARF2 expression.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[jan dot kratochvil at redhat dot com]

------- Comment #3 from jan dot kratochvil at redhat dot com  2008-08-18 08:24 -------
The fix was posted at:
http://gcc.gnu.org/ml/gcc-patches/2008-05/msg01857.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[ebotcazou at gcc dot gnu dot org]

------- Comment #4 from ebotcazou at gcc dot gnu dot org  2009-03-08 09:46 -------
What happened to the patch?


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[ebotcazou at gcc dot gnu dot org]

------- Comment #5 from ebotcazou at gcc dot gnu dot org  2009-11-10 08:29 -------
No feedback.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |WONTFIX


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[tromey at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

Tom Tromey <tromey at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2010.11.18 21:09:15
                 CC|                            |tromey at gcc dot gnu.org
         Resolution|WONTFIX                     |
     Ever Confirmed|0                           |1

--- Comment #6 from Tom Tromey <tromey at gcc dot gnu.org> 2010-11-18 21:09:15 UTC ---
AFAICT, nobody ever reviewed this patch.

I am reopening this PR because I think that it is bad for GCC to emit
bogus DWARF like this.  The patch is not ideal, but it is an improvement.
I'll ping the patch as well.

I think we'll end up putting in the GDB workaround regardless of what
happens in GCC.

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[rupp at gnat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

Douglas B Rupp <rupp at gnat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rupp at gnat dot com

--- Comment #7 from Douglas B Rupp <rupp at gnat dot com> 2011-01-21 20:30:20 UTC ---
This bogus size of -1 is causing an informational warning from VMS Debug on
IA64 VMS.

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Wed Nov 13 10:07:14 2013
New Revision: 204736

URL: http://gcc.gnu.org/viewcvs?rev=204736&root=gcc&view=rev
Log:
    PR ada/35998
    * dwarf2out.c (add_byte_size_attribute): Also use int_size_in_bytes
    for fields.  Do not add the attribute if the size is negative.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dwarf2out.c

[Bug ada/35998] debug info invalid x86_64 DW_AT_byte_size 0xffffffff

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35998

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #9 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Fixed, at long last.