[Bug fortran/35997] New: Used function interface bug

[Bug fortran/35997] New: Used function interface bug

[drewmccormack at mac dot com]

Code that has a function interface used from two modules can fail if one of the
modules renames the function interface. The example below fails to compile with
this message:

gfortran testfuncinterface.f90 
testfuncinterface.f90:21.7:

  if ( valid() ) then
      1
Error: IF clause at (1) requires a scalar LOGICAL expression


Source Code:

module funcinterfacemod

  interface
    logical function valid()
    end function
  end interface

end module

module secondmod
  use funcinterfacemod, valid2 => valid
end module

logical function valid()
  valid = .true.
end function

program main
  use secondmod
  use funcinterfacemod
  if ( valid() ) then
    print *,'Is Valid'
  endif
end program


This example does compile is the order of the use statements is reversed. This
also compiles on earlier versions of gfortran (eg 4.3.0 20071114 (experimental)
(GCC))


-- 
           Summary: Used function interface bug
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: drewmccormack at mac dot com
 GCC build triplet: 4.3.0 20080125 (experimental) (GCC)
  GCC host triplet: i386-apple-darwin8.11.1
GCC target triplet: i386-apple-darwin8.11.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression]Used function interface bug

[jvdelisle at gcc dot gnu dot org]

------- Comment #1 from jvdelisle at gcc dot gnu dot org  2008-04-22 01:19 -------
Confirmed.  Works for me on 4.2.4, Fails on 4.3.1


-- 

jvdelisle at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
      Known to fail|                            |4.3.1 4.4.0
      Known to work|                            |4.2.4
   Last reconfirmed|0000-00-00 00:00:00         |2008-04-22 01:19:55
               date|                            |
            Summary|Used function interface bug |[4.3/4.4 regression]Used
                   |                            |function interface bug


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression]Used function interface bug

[pault at gcc dot gnu dot org]

------- Comment #2 from pault at gcc dot gnu dot org  2008-04-28 11:55 -------
Created an attachment (id=15541)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15541&action=view)
Fix for this PR

This seems to do the job.  The problem arises because the present version of
module.c does not add a new symtree that is not renamed if the symbol is
already present.  The test in module.c(find_symbol) was failing to resolve the
case where the renaming is already done in the module that is being use
associated.  This patch accomplishes this by looking for a symtree with the
same name as the symbol and, upon failure, checking that the symbol is not
renamed; this can only correspond to the unresolved case.

I will develop a proper testcase and submit later on today.


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression]Used function interface bug

[pault at gcc dot gnu dot org]

------- Comment #3 from pault at gcc dot gnu dot org  2008-04-30 20:14 -------
Subject: Bug 35997

Author: pault
Date: Wed Apr 30 20:13:21 2008
New Revision: 134836

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134836
Log:
2008-04-30  Paul Thomas  <pault@gcc.gnu.org>

       PR fortran/35997
       * module.c (find_symbol): Do not return a result for a symbol
       that has been renamed in another module.

2008-04-30  Paul Thomas  <pault@gcc.gnu.org>

       PR fortran/35997
       * gfortran.dg/use_rename_3.f90

Added:
    trunk/gcc/testsuite/gfortran.dg/use_rename_3.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/module.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression] Used function interface bug

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.3/4.4 regression]Used    |[4.3/4.4 regression] Used
                   |function interface bug      |function interface bug
   Target Milestone|---                         |4.3.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression] Used function interface bug

[jsm28 at gcc dot gnu dot org]

-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression] Used function interface bug

[burnus at gcc dot gnu dot org]

------- Comment #4 from burnus at gcc dot gnu dot org  2008-05-05 17:05 -------
It would be nice if this could go into 4.3.1; its release was scheduled for
today, but it got delayed by three P1 regressions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression] Used function interface bug

[pault at gcc dot gnu dot org]

------- Comment #5 from pault at gcc dot gnu dot org  2008-05-13 20:27 -------
Subject: Bug 35997

Author: pault
Date: Tue May 13 20:26:47 2008
New Revision: 135273

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135273
Log:
2008-05-13  Paul Thomas  <pault@gcc.gnu.org>

       PR fortran/35997
       * module.c (find_symbol): Do not return a result for a symbol
       that has been renamed in another module.

2008-05-13  Paul Thomas  <pault@gcc.gnu.org>

       PR fortran/35997
       * gfortran.dg/use_rename_3.f90


Added:
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/used_rename_3.f90
Modified:
    branches/gcc-4_3-branch/gcc/fortran/ChangeLog
    branches/gcc-4_3-branch/gcc/fortran/module.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997

[Bug fortran/35997] [4.3/4.4 regression] Used function interface bug

[pault at gcc dot gnu dot org]

------- Comment #6 from pault at gcc dot gnu dot org  2008-05-13 20:28 -------
Fixed on trunk and 4.3

Thanks for the report.

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35997