[Bug fortran/35864] New: [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90 for cris-elf

[Bug fortran/35864] New: [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90 for cris-elf

[hp at gcc dot gnu dot org]

With r133964, this test passed.  With 133965 I see:
f951: internal compiler error: Segmentation fault

Backtrace (f951 recompiled with CFLAGS=-g)
(gdb) bt
#0  splay_tree_delete (sp=0x103f880) at
/home/hp/combh/combined/libiberty/splay-tree.c:67
#1  0x0000000000423c96 in gfc_free_expr (e=0x7fff4d8a3d00)
    at /home/hp/combh/combined/gcc/fortran/expr.c:227
#2  0x0000000000426f1e in scalarize_intrinsic_call (e=0x103f7b0)
    at /home/hp/combh/combined/gcc/fortran/expr.c:1827
#3  0x00000000004278c9 in check_init_expr (e=0x103f7b0)
    at /home/hp/combh/combined/gcc/fortran/expr.c:2204
#4  0x000000000042705f in check_intrinsic_op (e=0x103f880,
    check_function=0x427737 <check_init_expr>) at
/home/hp/combh/combined/gcc/fortran/expr.c:1879
#5  0x0000000000427784 in check_init_expr (e=0x103f880)
    at /home/hp/combh/combined/gcc/fortran/expr.c:2170
#6  0x0000000000426f79 in check_intrinsic_op (e=0x103f950,
    check_function=0x427737 <check_init_expr>) at
/home/hp/combh/combined/gcc/fortran/expr.c:1839
#7  0x0000000000427784 in check_init_expr (e=0x103f950)
    at /home/hp/combh/combined/gcc/fortran/expr.c:2170
#8  0x0000000000427c07 in gfc_match_init_expr (result=0x7fff4d8a3ed8)
    at /home/hp/combh/combined/gcc/fortran/expr.c:2341
#9  0x0000000000416429 in variable_decl (elem=1)
    at /home/hp/combh/combined/gcc/fortran/decl.c:1743
#10 0x0000000000418e93 in gfc_match_data_decl ()
    at /home/hp/combh/combined/gcc/fortran/decl.c:3674
#11 0x000000000045d5bc in match_word (str=0x0, subr=0x418cd1
<gfc_match_data_decl>,
    old_locus=0x7fff4d8a3fd0) at /home/hp/combh/combined/gcc/fortran/parse.c:64
#12 0x000000000045dd3e in decode_statement () at
/home/hp/combh/combined/gcc/fortran/parse.c:280
#13 0x000000000045f0dc in next_free () at
/home/hp/combh/combined/gcc/fortran/parse.c:653
#14 0x000000000045f44e in next_statement () at
/home/hp/combh/combined/gcc/fortran/parse.c:830
#15 0x0000000000460b88 in parse_spec (st=ST_NONE)
    at /home/hp/combh/combined/gcc/fortran/parse.c:2092
#16 0x00000000004625d7 in parse_module () at
/home/hp/combh/combined/gcc/fortran/parse.c:3397
#17 0x00000000004629c4 in gfc_parse_file () at
/home/hp/combh/combined/gcc/fortran/parse.c:3548
#18 0x0000000000491982 in gfc_be_parse_file (set_yydebug=0)
    at /home/hp/combh/combined/gcc/fortran/f95-lang.c:258
#19 0x000000000087151f in compile_file () at
/home/hp/combh/combined/gcc/toplev.c:962
#20 0x0000000000873160 in do_compile () at
/home/hp/combh/combined/gcc/toplev.c:2163
#21 0x00000000008731c4 in toplev_main (argc=15, argv=0x7fff4d8a4338)
    at /home/hp/combh/combined/gcc/toplev.c:2195
#22 0x00000000004fca07 in main (argc=15, argv=0x7fff4d8a4338)
    at /home/hp/combh/combined/gcc/main.c:35

Author of 133965 CC:ed.


-- 
           Summary: [4.4 Regression] Revision 133965 broke
                    gfortran.dg/initialization_1.f90 for cris-elf
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: hp at gcc dot gnu dot org
  GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: cris-axis-elf


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90 for cris-elf

[jvdelisle at verizon dot net]

------- Comment #1 from jvdelisle at verizon dot net  2008-04-07 23:49 -------
Subject: Re:   New: [4.4 Regression] Revision 133965    broke
 gfortran.dg/initialization_1.f90 for cris-elf


On Mon, 2008-04-07 at 23:18 +0000, hp at gcc dot gnu dot org wrote:
> With r133964, this test passed.  With 133965 I see:
> f951: internal compiler error: Segmentation fault
> 
It is not target specific. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90 for cris-elf

[hp at gcc dot gnu dot org]

------- Comment #2 from hp at gcc dot gnu dot org  2008-04-08 00:12 -------
(In reply to comment #1)
>
> It is not target specific. 

Ah, I was a bit worried that it was.  Since the failure had been there all day,
and noone have entered a matching PR or mentioning it on the lists, I just
*assumed* that it was... ;)


-- 

hp at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-04-08 00:12:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[dominiq at lps dot ens dot fr]

------- Comment #3 from dominiq at lps dot ens dot fr  2008-04-08 15:14 -------
I don't see the failure on (powerpc|i686)-apple-darwin9 nor in
http://gcc.gnu.org/ml/gcc-testresults/2008-04/msg00549.html. So it does not
seem to affect all platforms.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[jvdelisle at gcc dot gnu dot org]

------- Comment #4 from jvdelisle at gcc dot gnu dot org  2008-04-08 20:05 -------
I see it on x86-64 Linux clearly enough and with -m32 and -m64.  I think Paul
removed a check that we have to put back in.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[burnus at gcc dot gnu dot org]

------- Comment #5 from burnus at gcc dot gnu dot org  2008-04-09 11:46 -------
> I see it on x86-64 Linux clearly enough and with -m32 and -m64.  I think Paul
> removed a check that we have to put back in.

Whereas I do not see it, neither with -m32 nor -m64 on x86-64-linux (openSUSE
Factory); not even using valgrind. This is with
gfortran 4.4.0 20080409 (experimental) [trunk revision 134131]


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[jvdelisle at gcc dot gnu dot org]

------- Comment #6 from jvdelisle at gcc dot gnu dot org  2008-04-09 23:47 -------
After a clean bootstrap (empty build directory) I get a pass.  I suspect we
have a dependency somewhere not getting taken car of.  Hans-Peter can you try
this and see whta happends.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[hp at gcc dot gnu dot org]

------- Comment #7 from hp at gcc dot gnu dot org  2008-04-09 23:57 -------
Try what?  I always start with a clean slate; an empty build directory!
Perhaps you mean something else?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[hp at gcc dot gnu dot org]

------- Comment #8 from hp at gcc dot gnu dot org  2008-04-10 00:00 -------
I haven't tried it myself, but since we're in voodoo-debug mode, try
"--enable-checking=yes,valgrind".


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[pault at gcc dot gnu dot org]

------- Comment #9 from pault at gcc dot gnu dot org  2008-04-11 09:54 -------
It's mine, it's mine!  I even posted a fix for it last night but have not had a
chance to commit it.  I'll try to do so over the weekend.

As Jerry remarks, it sometimes goes away; such as on my x86_ia64/FC8, on which
I developed the patch that caused the regression.

Sorry about the problem.

Cheers

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pault at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-04-08 00:12:28         |2008-04-11 09:54:39
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[burnus at gcc dot gnu dot org]

------- Comment #10 from burnus at gcc dot gnu dot org  2008-04-11 12:23 -------
> It's mine, it's mine!  I even posted a fix for it last night but have not had 
> a chance to commit it.  I'll try to do so over the weekend.

The mentioned patch was posted here:
http://gcc.gnu.org/ml/fortran/2008-04/msg00107.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[pault at gcc dot gnu dot org]

------- Comment #11 from pault at gcc dot gnu dot org  2008-04-15 19:41 -------
Subject: Bug 35864

Author: pault
Date: Tue Apr 15 19:40:33 2008
New Revision: 134329

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134329
Log:
2008-04-15  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/35864
        * expr.c (scalarize_intrinsic_call): Reorder identification of
        array argument so that if one is not found a segfault does not
        occur.  Return FAILURE if all scalar arguments.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/expr.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[pault at gcc dot gnu dot org]

------- Comment #12 from pault at gcc dot gnu dot org  2008-04-15 19:43 -------
Finally, I have managed to deal with this.

Sorry it took so long

Paul


-- 

pault at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864

[Bug fortran/35864] [4.4 Regression] Revision 133965 broke gfortran.dg/initialization_1.f90

[pault at gcc dot gnu dot org]

------- Comment #13 from pault at gcc dot gnu dot org  2008-05-01 07:32 -------
Subject: Bug 35864

Author: pault
Date: Thu May  1 07:31:28 2008
New Revision: 134847

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=134847
Log:
2008-05-01  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/35864
        * expr.c (scalarize_intrinsic_call): Reorder identification of
        array argument so that if one is not found a segfault does not
        occur.  Return FAILURE if all scalar arguments.

        PR fortran/35780
        * expr.c (scalarize_intrinsic_call): Identify which argument is
        an array and use that as the template.
        (check_init_expr): Remove tests that first argument is an array
        in the call to scalarize_intrinsic_call.

2008-05-01  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/35780
        * gfortran.dg/simplify_argN_1.f90: New test.


Added:
    branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/simplify_argN_1.f90
Modified:
    branches/gcc-4_3-branch/gcc/fortran/ChangeLog
    branches/gcc-4_3-branch/gcc/fortran/expr.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35864