[Bug c/36111] New: GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[Bug c/36111] New: GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[linuxl4 at sohu dot com]

openmpi-1.2.6
------------------------------
cd openmpi-1.2.6
mkdir i95;cd i95;../configure --prefix=/usr/local/openmpi-1.2.6
make


my $CFLAGS:
----------------
-pipe -ggdb3 -limf -lsvml -O3 -march=pentium4 -mfpmath=sse -funswitch-loops
-ftree-loop-distribution -ftree-loop-linear -ftree-loop-im -fivopts
-funroll-loops -fvariable-expansion-in-unroller -fsplit-ivs-in-unroller
-ftree-vectorize -ftree-vect-loop-version -fvect-cost-model -fgcse-sm
-fgcse-las -fsched-spec-load -fsched-stalled-insns=0
-fsched-stalled-insns-dep=0 -fbounds-check



when compile  openmpi-1.2.6/opal/mca/memory/ptmalloc2/malloc.c
-------------------------------------------------------------------------
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../../../opal/include
-I../../../../orte/include -I../../../../ompi/include
-I../../../../../opal/mca/memory/ptmalloc2 -DMALLOC_DEBUG=0 -D_GNU_SOURCE=1
-DUSE_TSD_DATA_HACK=1 -DMALLOC_HOOKS=1
-I../../../../../opal/mca/memory/ptmalloc2/sysdeps/pthread
-I../../../../../opal/mca/memory/ptmalloc2/sysdeps/generic -I../../../../..
-I../../../.. -I../../../../../opal/include -I../../../../../orte/include
-I../../../../../ompi/include -DNDEBUG -pipe -ggdb3 -limf -lsvml -O3
-march=pentium4 -mfpmath=sse -funswitch-loops -ftree-loop-distribution
-ftree-loop-linear -ftree-loop-im -fivopts -funroll-loops
-fvariable-expansion-in-unroller -fsplit-ivs-in-unroller -ftree-vectorize
-ftree-vect-loop-version -fvect-cost-model -fgcse-sm -fgcse-las
-fsched-spec-load -fsched-stalled-insns=0 -fsched-stalled-insns-dep=0
-fbounds-check -finline-functions -fno-strict-aliasing -pthread -MT malloc.lo
-MD -MP -MF .deps/malloc.Tpo -c
../../../../../opal/mca/memory/ptmalloc2/malloc.c  -fPIC -DPIC -o
.libs/malloc.o
../../../../../opal/mca/memory/ptmalloc2/malloc.c: In function 'malloc_trim':
../../../../../opal/mca/memory/ptmalloc2/malloc.c:3902: error: invalid rtl
sharing found in the insn
(insn 11 9 12 3
../../../../../opal/mca/memory/ptmalloc2/sysdeps/pthread/malloc-machine.h:51
(parallel [
            (set (reg/v:SI 80 [ r ])
                (asm_operands/v:SI ("xchgl %0, %1") ("=r") 0 [
                        (reg:SI 85)
                        (mem/s/v/j/c:SI (plus:SI (reg:SI 3 bx)
                                (const:SI (unspec:SI [
                                            (symbol_ref:SI ("main_arena")
[flags 0x2] <var_decl 0xb7e18898 main_arena>)
                                        ] 1))) [0 main_arena.mutex.lock+0 S4
A256])
                    ]
                     [
                        (asm_input:SI ("0") 0)
                        (asm_input:SI ("m") 0)
                    ] 2207718))
            (set (mem/s/v/j/c:SI (plus:SI (reg:SI 3 bx)
                        (const:SI (unspec:SI [
                                    (symbol_ref:SI ("main_arena") [flags 0x2]
<var_decl 0xb7e18898 main_arena>)
                                ] 1))) [0 main_arena.mutex.lock+0 S4 A256])
                (asm_operands/v:SI ("xchgl %0, %1") ("=m") 1 [
                        (reg:SI 85)
                        (mem/s/v/j/c:SI (plus:SI (reg:SI 3 bx)
                                (const:SI (unspec:SI [
                                            (symbol_ref:SI ("main_arena")
[flags 0x2] <var_decl 0xb7e18898 main_arena>)
                                        ] 1))) [0 main_arena.mutex.lock+0 S4
A256])
                    ]
                     [
                        (asm_input:SI ("0") 0)
                        (asm_input:SI ("m") 0)
                    ] 2207718))
            (clobber (reg:QI 18 fpsr))
            (clobber (reg:QI 17 flags))
            (clobber (mem:BLK (scratch) [0 A8]))
        ]) -1 (expr_list:REG_DEAD (reg:SI 85)
        (expr_list:REG_UNUSED (reg:QI 18 fpsr)
            (expr_list:REG_UNUSED (reg:QI 17 flags)
                (nil)))))
../../../../../opal/mca/memory/ptmalloc2/malloc.c:3902: error: shared rtx
(const:SI (unspec:SI [
            (symbol_ref:SI ("main_arena") [flags 0x2] <var_decl 0xb7e18898
main_arena>)
        ] 1))
../../../../../opal/mca/memory/ptmalloc2/malloc.c:3902: internal compiler
error: internal consistency failure
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make: *** [malloc.lo] Error 1


-- 
           Summary: GCC 4.4.0-20080501 failed to compile openmpi's malloc.c
                    file.
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: linuxl4 at sohu dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug inline-asm/36111] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2008-05-02 18:48 -------
Please attach pre-processed source of the offending source file which you can
obtain by appending -save-temps on the gcc command-line.  The pre-processed
file will be named $FILE.i.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug inline-asm/36111] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[linuxl4 at sohu dot com]

------- Comment #2 from linuxl4 at sohu dot com  2008-05-03 04:09 -------
Created an attachment (id=15566)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15566&action=view)
malloc.i

ok.please see the attachment file.
--------------------------------------------
cd openmpi-1.2.6/i95/opal/mca/memory/ptmalloc2/

gcc -DHAVE_CONFIG_H -I. -I../../../../opal/include -I../../../../orte/include
-I../../../../ompi/include -I../../../../../opal/mca/memory/ptmalloc2
-DMALLOC_DEBUG=0 -D_GNU_SOURCE=1 -DUSE_TSD_DATA_HACK=1 -DMALLOC_HOOKS=1
-I../../../../../opal/mca/memory/ptmalloc2/sysdeps/pthread
-I../../../../../opal/mca/memory/ptmalloc2/sysdeps/generic -I../../../../..
-I../../../.. -I../../../../../opal/include -I../../../../../orte/include
-I../../../../../ompi/include -DNDEBUG -pipe -ggdb3 -limf -lsvml -O3
-march=pentium4 -mfpmath=sse -funswitch-loops -ftree-loop-distribution
-ftree-loop-linear -ftree-loop-im -fivopts -funroll-loops
-fvariable-expansion-in-unroller -fsplit-ivs-in-unroller -ftree-vectorize
-ftree-vect-loop-version -fvect-cost-model -fgcse-sm -fgcse-las
-fsched-spec-load -fsched-stalled-insns=0 -fsched-stalled-insns-dep=0
-fbounds-check -finline-functions -fno-strict-aliasing -pthread -MT malloc.lo
-MD -MP -MF .deps/malloc.Tpo -c
../../../../../opal/mca/memory/ptmalloc2/malloc.c  -fPIC -DPIC -o
.libs/malloc.o -save-temps

------------------------------------

same error ocered when compile glibc 2.7's malloc.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2008-05-03 09:50 -------
Confirmed.  Reduced testcase that fails with -O2 -fPIC:

typedef struct {
  volatile unsigned int lock;
  int pad0_;
} mutex_t;
struct malloc_state {
  mutex_t mutex;
};
static struct malloc_state main_arena;
static __inline__ void mutex_lock(mutex_t *m)
{
  int r;
  for(;;)
    __asm__ __volatile__ ("xchgl %0, %1"
                          : "=r"(r), "=m"(m->lock)
                          : "0"(1), "m"(m->lock)
                          : "memory");
}
void __malloc_check_init()
{
  mutex_lock(&main_arena.mutex);
}


4.3.0 seems to work (yes, with checking enabled).


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org
          Component|inline-asm                  |rtl-optimization
           Keywords|                            |ice-on-valid-code
      Known to work|                            |4.3.0
   Last reconfirmed|0000-00-00 00:00:00         |2008-05-03 09:50:05
               date|                            |
            Summary|GCC 4.4.0-20080501 failed to|[4.4 Regression] GCC 4.4.0-
                   |compile openmpi's malloc.c  |20080501 failed to compile
                   |file.                       |openmpi's malloc.c file.
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|2008-05-03 09:50:05         |2008-05-03 09:50:18
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2008-05-05 04:59 -------
Here is a further reduced testcase:
typedef struct {
  int lock;
  int pad0_;
} mutex_t;
static mutex_t main_arena;
void __malloc_check_init()
{
  for(;;)
    __asm__ __volatile__ ("": "+m"(main_arena.lock) );
}


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
   Last reconfirmed|2008-05-03 09:50:18         |2008-05-05 04:59:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2008-05-05 05:05 -------
*** Bug 36092 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steve49152 at yahoo dot ca


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[ubizjak at gmail dot com]

------- Comment #6 from ubizjak at gmail dot com  2008-05-05 10:29 -------
This patch works for me:

Index: recog.c
===================================================================
--- recog.c     (revision 134943)
+++ recog.c     (working copy)
@@ -537,7 +537,8 @@ validate_replace_rtx_1 (rtx *loc, rtx fr
       || (GET_CODE (x) == GET_CODE (from) && GET_MODE (x) == GET_MODE (from)
          && rtx_equal_p (x, from)))
     {
-      validate_unshare_change (object, loc, to, 1);
+      to = copy_rtx_if_shared (to);
+      validate_change (object, loc, to, 1);
       return;
     }



-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[ubizjak at gmail dot com]

------- Comment #7 from ubizjak at gmail dot com  2008-05-05 10:53 -------
validate_unshare_change was introduced by:

2007-06-26  Jan Hubicka  <jh@suse.cz>

        * fwprop.c (try_fwprop_subst): Use validate_unshare_change.
        * postreload.c (reload_cse_simplify_set): Instead of copying the rtx
        early use validate_unshare_change.
        (reload_combine): Likewise.
        * recog.c (change_t): New field unshare.
        (validate_change_1): Rename from validate_change; add argument unshare.
        (validate_change): Turn into wrapper of validate_change_1; update
        prototype for bools.
        (validate_unshare_change): New.
        (confirm_change_group): Unshare changes if asked for; avoid unnecesary
        calls of df_insn_rescan.
        * recog.h (validate_change): Replace ints by bools.
        (validate_unshare_change): Declare.

The problem is, that validate_unshare_change logic creates sharing violation if
the same RTX is propagated into two places in the same insn pattern.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[ubizjak at gmail dot com]

------- Comment #8 from ubizjak at gmail dot com  2008-05-12 06:47 -------
This also fixes sse3-* failures with -fpic at
http://gcc.gnu.org/ml/gcc-testresults/2008-05/msg01014.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[ubizjak at gmail dot com]

------- Comment #9 from ubizjak at gmail dot com  2008-05-12 13:12 -------
(In reply to comment #6)
> This patch works for me:
> 
> Index: recog.c

This is not a good solution, since the problem is in

"if (SWAPPABLE_OPERANDS_P (x))"

section, a couple of lines down the code. The patch and an analysis is at patch
URL: http://gcc.gnu.org/ml/gcc-patches/2008-05/msg00687.html


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ubizjak at gmail dot com
                   |dot org                     |
                URL|                            |http://gcc.gnu.org/ml/gcc-
                   |                            |patches/2008-
                   |                            |05/msg00687.html
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-05-05 04:59:19         |2008-05-12 13:12:00
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[uros at gcc dot gnu dot org]

------- Comment #10 from uros at gcc dot gnu dot org  2008-05-12 16:56 -------
Subject: Bug 36111

Author: uros
Date: Mon May 12 16:55:43 2008
New Revision: 135221

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135221
Log:
        PR rtl-optimization/36111
        * recog.c (validate_replace_rtx_1): Unshare new RTL expression
        that was created for swappable operands.

testsuite/ChangeLog:

        PR rtl-optimization/36111
        * gcc.dg/pr36111.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr36111.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/recog.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[ubizjak at gmail dot com]

------- Comment #11 from ubizjak at gmail dot com  2008-05-12 16:58 -------
Fixed.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[linuxl4 at sohu dot com]

------- Comment #12 from linuxl4 at sohu dot com  2008-05-13 05:39 -------
I compiled openmpi 1.2.6 today,
gcc 20080512 works  fine.

thanks!


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[steve49152 at yahoo dot ca]

------- Comment #13 from steve49152 at yahoo dot ca  2008-05-31 02:53 -------
I have tested the fix as backported to 4.2.4 and everything seems fine.  I
additionaly discovered code-generation errors in XFree86 4.7.99.17 in the i810
driver which are resolved with the changes.  As an extra test I have compiled
XFree86 with the following options: 

/system/devel/bin/gcc-4.2.4 -march=pentium3 -mtune=pentium3 -mfpmath=sse,387
-mno-tls-direct-seg-refs -O2 -Wall

Everything works as expected.  I'm now recompiling glibc and expect no
surprises.

Thanks people.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[uros at gcc dot gnu dot org]

------- Comment #14 from uros at gcc dot gnu dot org  2008-06-07 21:14 -------
Subject: Bug 36111

Author: uros
Date: Sat Jun  7 21:13:29 2008
New Revision: 136538

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=136538
Log:
        Backport from mainline:
        2008-05-12  Uros Bizjak  <ubizjak@gmail.com>

        PR rtl-optimization/36111
        * recog.c (validate_replace_rtx_1): Unshare new RTL expression
        that was created for swappable operands.

testsuite/ChangeLog:

        Backport from mainline:
        2008-05-12  Uros Bizjak  <ubizjak@gmail.com>

        PR rtl-optimization/36111
        * gcc.dg/pr36111.c: New test.


Added:
    branches/gcc-4_3-branch/gcc/testsuite/gcc.dg/pr36111.c
Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/recog.c
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.3/4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[ubizjak at gmail dot com]

------- Comment #15 from ubizjak at gmail dot com  2008-06-08 05:53 -------
Fixed also for 4.3.2.


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.4 Regression] GCC 4.4.0- |[4.3/4.4 Regression] GCC
                   |20080501 failed to compile  |4.4.0-20080501 failed to
                   |openmpi's malloc.c file.    |compile openmpi's malloc.c
                   |                            |file.
   Target Milestone|4.4.0                       |4.3.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111

[Bug rtl-optimization/36111] [4.3/4.4 Regression] GCC 4.4.0-20080501 failed to compile openmpi's malloc.c file.

[ubizjak at gmail dot com]

------- Comment #16 from ubizjak at gmail dot com  2008-06-08 05:55 -------
(In reply to comment #15)
> Fixed also for 4.3.2.

See http://gcc.gnu.org/ml/gcc/2008-06/msg00172.html


-- 

ubizjak at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|4.3.0                       |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36111