public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort @ 2008-03-28 21:44 dick dot hendrickson at gmail dot com 2008-03-28 22:05 ` [Bug fortran/35745] " burnus at gcc dot gnu dot org ` (5 more replies) 0 siblings, 6 replies; 7+ messages in thread From: dick dot hendrickson at gmail dot com @ 2008-03-28 21:44 UTC (permalink / raw) To: gcc-bugs The following program aborts at run-time opening a box that says "a.exe has encountered a problem and needs to close. We are sorry for the inconvenience." And then offers to send an error report to Microsoft. I believe the problem is the extraction of the 1/NF0 from within the WHERE block. program RZ0048 INTEGER IDA(10) REAL RDA(10) RDA = 1.0 nf0 = 3 WHERE (RDA < -15.0) IDA = 1/NF0 + 2 ENDWHERE print *, 'first where completed' nf0 = 0 WHERE (RDA < -15.0) IDA = 1/NF0 + 2 ENDWHERE END -- Summary: Divide incorrectly extracted from WHERE block?; run time abort Product: gcc Version: 4.4.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: fortran AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: dick dot hendrickson at gmail dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort 2008-03-28 21:44 [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort dick dot hendrickson at gmail dot com @ 2008-03-28 22:05 ` burnus at gcc dot gnu dot org 2008-03-29 15:52 ` burnus at gcc dot gnu dot org ` (4 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: burnus at gcc dot gnu dot org @ 2008-03-28 22:05 UTC (permalink / raw) To: gcc-bugs ------- Comment #1 from burnus at gcc dot gnu dot org 2008-03-28 22:05 ------- Confirm. Valgrind shows: Process terminating with default action of signal 8 (SIGFPE): dumping core Integer divide by zero at address 0x40274EADB at 0x4008C6: MAIN__ (ghfhgk.f90:15) > Divide incorrectly extracted from WHERE block? Yes and no. The compiler essentially transforms (as -fdump-tree-original shows) WHERE (RDA < -15.0) IDA = 1/NF0 + 2 ENDWHERE into TMP = 1/NF0 + 2 WHERE (RDA < -15.0) IDA = TMP ENDWHERE which is the reason for the integer divide by zero and shows that moving constant expressions out of a loop is not always a good idea. -- burnus at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Keywords| |wrong-code Last reconfirmed|0000-00-00 00:00:00 |2008-03-28 22:05:10 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort 2008-03-28 21:44 [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort dick dot hendrickson at gmail dot com 2008-03-28 22:05 ` [Bug fortran/35745] " burnus at gcc dot gnu dot org @ 2008-03-29 15:52 ` burnus at gcc dot gnu dot org 2008-04-01 7:25 ` pault at gcc dot gnu dot org ` (3 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: burnus at gcc dot gnu dot org @ 2008-03-29 15:52 UTC (permalink / raw) To: gcc-bugs ------- Comment #2 from burnus at gcc dot gnu dot org 2008-03-29 15:52 ------- See also PR 35756. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort 2008-03-28 21:44 [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort dick dot hendrickson at gmail dot com 2008-03-28 22:05 ` [Bug fortran/35745] " burnus at gcc dot gnu dot org 2008-03-29 15:52 ` burnus at gcc dot gnu dot org @ 2008-04-01 7:25 ` pault at gcc dot gnu dot org 2008-05-16 21:13 ` pault at gcc dot gnu dot org ` (2 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: pault at gcc dot gnu dot org @ 2008-04-01 7:25 UTC (permalink / raw) To: gcc-bugs -- pault at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|unassigned at gcc dot gnu |pault at gcc dot gnu dot org |dot org | Status|NEW |ASSIGNED Last reconfirmed|2008-03-28 22:05:10 |2008-04-01 07:24:30 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort 2008-03-28 21:44 [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort dick dot hendrickson at gmail dot com ` (2 preceding siblings ...) 2008-04-01 7:25 ` pault at gcc dot gnu dot org @ 2008-05-16 21:13 ` pault at gcc dot gnu dot org 2008-05-17 7:12 ` pault at gcc dot gnu dot org 2008-05-17 7:18 ` pault at gcc dot gnu dot org 5 siblings, 0 replies; 7+ messages in thread From: pault at gcc dot gnu dot org @ 2008-05-16 21:13 UTC (permalink / raw) To: gcc-bugs ------- Comment #3 from pault at gcc dot gnu dot org 2008-05-16 21:12 ------- Subject: Bug 35745 Author: pault Date: Fri May 16 21:12:04 2008 New Revision: 135443 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135443 Log: 2008-05-16 Paul Thomas <pault@gcc.gnu.org> PR fortran/35756 PR fortran/35759 * trans-stmt.c (gfc_trans_where): Tighten up the dependency check for calling gfc_trans_where_3. PR fortran/35743 * trans-stmt.c (gfc_trans_where_2): Set the mask size to zero if it is calculated to be negative. PR fortran/35745 * trans-stmt.c (gfc_trans_where_3, gfc_trans_where_assign): Set ss->where for scalar right hand sides. * trans-array.c (gfc_add_loop_ss_code): If ss->where is set do not evaluate scalars outside the loop. Clean up whitespace. * trans.h : Add a bitfield 'where' to gfc_ss. 2008-05-16 Paul Thomas <pault@gcc.gnu.org> PR fortran/35756 PR fortran/35759 * gfortran.dg/where_1.f90: New test. PR fortran/35743 PR fortran/35745 * gfortran.dg/where_2.f90: New test. Added: trunk/gcc/testsuite/gfortran.dg/where_1.f90 trunk/gcc/testsuite/gfortran.dg/where_2.f90 Modified: trunk/gcc/fortran/ChangeLog trunk/gcc/fortran/trans-array.c trunk/gcc/fortran/trans-stmt.c trunk/gcc/fortran/trans.h trunk/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort 2008-03-28 21:44 [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort dick dot hendrickson at gmail dot com ` (3 preceding siblings ...) 2008-05-16 21:13 ` pault at gcc dot gnu dot org @ 2008-05-17 7:12 ` pault at gcc dot gnu dot org 2008-05-17 7:18 ` pault at gcc dot gnu dot org 5 siblings, 0 replies; 7+ messages in thread From: pault at gcc dot gnu dot org @ 2008-05-17 7:12 UTC (permalink / raw) To: gcc-bugs ------- Comment #4 from pault at gcc dot gnu dot org 2008-05-17 07:11 ------- Subject: Bug 35745 Author: pault Date: Sat May 17 07:10:13 2008 New Revision: 135461 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135461 Log: 2008-05-17 Paul Thomas <pault@gcc.gnu.org> Backport from mainline: PR fortran/35756 PR fortran/35759 * trans-stmt.c (gfc_trans_where): Tighten up the dependency check for calling gfc_trans_where_3. PR fortran/35743 * trans-stmt.c (gfc_trans_where_2): Set the mask size to zero if it is calculated to be negative. PR fortran/35745 * trans-stmt.c (gfc_trans_where_3, gfc_trans_where_assign): Set ss->where for scalar right hand sides. * trans-array.c (gfc_add_loop_ss_code): If ss->where is set do not evaluate scalars outside the loop. Clean up whitespace. * trans.h : Add a bitfield 'where' to gfc_ss. PR fortran/36233 * interface.c (compare_actual_formal): Do not check sizes if the actual is BT_PROCEDURE. 2008-05-17 Paul Thomas <pault@gcc.gnu.org> Backport from mainline: PR fortran/35756 PR fortran/35759 * gfortran.dg/where_1.f90: New test. PR fortran/35743 PR fortran/35745 * gfortran.dg/where_2.f90: New test. PR fortran/36233 * gfortran.dg/actual_procedure_1.f90: New test Added: branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/actual_procedure_1.f90 branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/where_1.f90 branches/gcc-4_3-branch/gcc/testsuite/gfortran.dg/where_2.f90 Modified: branches/gcc-4_3-branch/gcc/fortran/ChangeLog branches/gcc-4_3-branch/gcc/fortran/interface.c branches/gcc-4_3-branch/gcc/fortran/trans-array.c branches/gcc-4_3-branch/gcc/fortran/trans-stmt.c branches/gcc-4_3-branch/gcc/fortran/trans.h branches/gcc-4_3-branch/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/35745] Divide incorrectly extracted from WHERE block?; run time abort 2008-03-28 21:44 [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort dick dot hendrickson at gmail dot com ` (4 preceding siblings ...) 2008-05-17 7:12 ` pault at gcc dot gnu dot org @ 2008-05-17 7:18 ` pault at gcc dot gnu dot org 5 siblings, 0 replies; 7+ messages in thread From: pault at gcc dot gnu dot org @ 2008-05-17 7:18 UTC (permalink / raw) To: gcc-bugs ------- Comment #5 from pault at gcc dot gnu dot org 2008-05-17 07:17 ------- Fixed on trunk and 4.3. Thanks for the report. Paul -- pault at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35745 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-05-17 7:18 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2008-03-28 21:44 [Bug fortran/35745] New: Divide incorrectly extracted from WHERE block?; run time abort dick dot hendrickson at gmail dot com 2008-03-28 22:05 ` [Bug fortran/35745] " burnus at gcc dot gnu dot org 2008-03-29 15:52 ` burnus at gcc dot gnu dot org 2008-04-01 7:25 ` pault at gcc dot gnu dot org 2008-05-16 21:13 ` pault at gcc dot gnu dot org 2008-05-17 7:12 ` pault at gcc dot gnu dot org 2008-05-17 7:18 ` pault at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).