public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/36253] Caller-save stack slot may not have proper alignment
Date: Sat, 17 May 2008 23:59:00 -0000	[thread overview]
Message-ID: <20080517235841.7125.qmail@sourceware.org> (raw)
In-Reply-To: <bug-36253-682@http.gcc.gnu.org/bugzilla/>



------- Comment #4 from hjl at gcc dot gnu dot org  2008-05-17 23:58 -------
Subject: Bug 36253

Author: hjl
Date: Sat May 17 23:57:59 2008
New Revision: 135486

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=135486
Log:
2008-05-17  H.J. Lu  <hongjiu.lu@intel.com>

        PR middle-end/36253
        * caller-save.c (insert_restore): Verify alignment of spill
        space.
        (insert_save): Likewise.

        * cfgexpand.c (LOCAL_ALIGNMENT): Removed.
        (get_decl_align_unit): Pass VOIDmode to LOCAL_ALIGNMENT.

        * defaults.h (LOCAL_ALIGNMENT): New. Provide default.

        * function.c (LOCAL_ALIGNMENT): Removed.
        (get_stack_local_alignment): New.
        (assign_stack_local): Use it.  Set alignment on stack slot.
        (assign_stack_temp_for_type): Use get_stack_local_alignment.

        * config/bfin/bfin.c (bfin_local_alignment): Updated.
        * config/bfin/bfin.h (LOCAL_ALIGNMENT): Likewise.
        * config/bfin/bfin-protos.h (bfin_local_alignment): Likewise.
        * config/i386/i386.h (LOCAL_ALIGNMENT): Likewise.
        * config/i386/i386-protos.h (ix86_local_alignment): Likewise.
        * config/mips/mips.h (LOCAL_ALIGNMENT): Likewise.
        * config/mmix/mmix.c (mmix_local_alignment): Likewise.
        * config/mmix/mmix.h (LOCAL_ALIGNMENT): Likewise.
        * config/mmix/mmix-protos.h (mmix_local_alignment): Likewise.
        * config/rs6000/rs6000.h (LOCAL_ALIGNMENT): Likewise.
        * config/score/score.h (LOCAL_ALIGNMENT): Likewise.
        * config/sh/sh.h (LOCAL_ALIGNMENT): Likewise.
        * config/sparc/sparc.h (LOCAL_ALIGNMENT): Likewise.
        * config/spu/spu.h (LOCAL_ALIGNMENT): Likewise.

        * config/i386/i386.c (ix86_local_alignment): Handle caller-save
        stack slot in XFmode.

        * config/rs6000/rs6000.h (LOCAL_ALIGNMENT_1): New.
        * config/sh/sh.h (LOCAL_ALIGNMENT_1): Likewise.

        * doc/tm.texi (LOCAL_ALIGNMENT): Add mode.

Modified:
    branches/stack/gcc/ChangeLog.stackalign
    branches/stack/gcc/caller-save.c
    branches/stack/gcc/cfgexpand.c
    branches/stack/gcc/config/bfin/bfin-protos.h
    branches/stack/gcc/config/bfin/bfin.c
    branches/stack/gcc/config/bfin/bfin.h
    branches/stack/gcc/config/i386/i386-protos.h
    branches/stack/gcc/config/i386/i386.c
    branches/stack/gcc/config/i386/i386.h
    branches/stack/gcc/config/mips/mips.h
    branches/stack/gcc/config/mmix/mmix-protos.h
    branches/stack/gcc/config/mmix/mmix.c
    branches/stack/gcc/config/mmix/mmix.h
    branches/stack/gcc/config/rs6000/rs6000.h
    branches/stack/gcc/config/score/score.h
    branches/stack/gcc/config/sh/sh.h
    branches/stack/gcc/config/sparc/sparc.h
    branches/stack/gcc/config/spu/spu.h
    branches/stack/gcc/defaults.h
    branches/stack/gcc/doc/tm.texi
    branches/stack/gcc/function.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36253


  parent reply	other threads:[~2008-05-17 23:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-17  0:18 [Bug middle-end/36253] New: " hjl dot tools at gmail dot com
2008-05-17  2:18 ` [Bug middle-end/36253] " hjl dot tools at gmail dot com
2008-05-17 15:19 ` hjl dot tools at gmail dot com
2008-05-17 23:51 ` hjl dot tools at gmail dot com
2008-05-17 23:59 ` hjl at gcc dot gnu dot org [this message]
2008-05-26 14:01 ` hjl at gcc dot gnu dot org
2008-05-26 14:29 ` hjl dot tools at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080517235841.7125.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).