[Bug fortran/36161] New: gfc_error formats are not marked gcc-internal-format in po file

[Bug fortran/36161] New: gfc_error formats are not marked gcc-internal-format in po file

[goeran at uddeborg dot se]

The first argument of gfc_error seems to be a format string of the form tagged
with gcc-internal-format elsewhere in the po file.  But it seems gfc_error
formats are instead tagged with no-c-format.  This is somewhat dangerous, since
msgfmt will not discover mistakes in the translation, mistakes that potentially
could cause a crash.

(Yes, it happened.  I had done a few such mistakes in sv.po, which was just
pointed out to me in a friendly letter.)


-- 
           Summary: gfc_error formats are not marked gcc-internal-format in
                    po file
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: goeran at uddeborg dot se


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[kargl at gcc dot gnu dot org]

------- Comment #1 from kargl at gcc dot gnu dot org  2008-05-19 19:48 -------
I don't understand this PR.  gfc_error's format strings may look
like C's printf format strings, but these are different.  These
format strings are parsed and used by gfortran, and are not passed
directly to libc.  So, gfc_error (and gfc_warning) format strings
should be marked no-c-format.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[goeran at uddeborg dot se]

------- Comment #2 from goeran at uddeborg dot se  2008-05-19 20:15 -------
I'm not saying they should be marked "c-format", but "gcc-internal-format". 
That special marker is known by msgfmt for the "printf inspired" error messages
in GCC.

Tobias Burnus has pointed out in a mail, however, that %C and %L are gfortran
specific, and might not be supported by msgfmt's gcc-internal-format.  I am
planning to investigate this, but I will not have time to do it until later.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[dfranke at gcc dot gnu dot org]

------- Comment #3 from dfranke at gcc dot gnu dot org  2009-01-03 23:58 -------
No idea about translation, but PR38573 is surely related.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dfranke at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[fxcoudert at gcc dot gnu dot org]

------- Comment #4 from fxcoudert at gcc dot gnu dot org  2009-03-28 16:39 -------
The Fortran front-end diagnostic strings have a specific format, that is an
extension of the C printf format. It is not the same as the
gcc-internal-format. Thus, if you want it to be supported, it first needs to be
recognized by the tools (xgettext), then we'll modify the front-end headers to
mark it appropriately.


-- 

fxcoudert at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fxcoudert at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[goeran at uddeborg dot se]

------- Comment #5 from goeran at uddeborg dot se  2009-03-28 18:27 -------
I see.  I've sent an enhancement suggestion to the gettext project.

https://savannah.gnu.org/bugs/index.php?26040


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[goeran at uddeborg dot se]

------- Comment #6 from goeran at uddeborg dot se  2009-03-29 16:53 -------
It didn't take long for this to be added to xgettext.  It's already in the
development version (see https://savannah.gnu.org/bugs/?26040#comment1 for
details).

So then maybe I can reopen this, to have the new functionality used on the GCC
side?


-- 

goeran at uddeborg dot se changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[bruno at clisp dot org]

------- Comment #7 from bruno at clisp dot org  2009-03-29 16:55 -------
(In reply to comment #4)
> The Fortran front-end diagnostic strings have a specific format, that is an
> extension of the C printf format. It is not the same as the
> gcc-internal-format. Thus, if you want it to be supported, it first needs to be
> recognized by the tools (xgettext),

Support for this type of format has now been added to xgettext. The support
will be contained in gettext 0.18.

> then we'll modify the front-end headers to mark it appropriately.

The xgettext options that need to be passed to "xgettext --language=GCC-source"
are:
 --keyword=gfc_error:1:gfc-internal-format \ 
 --keyword=gfc_error_now:1:gfc-internal-format \ 
 --keyword=gfc_fatal_error:1:gfc-internal-format \ 
 --keyword=gfc_internal_error:1:gfc-internal-format \ 
 --keyword=gfc_notify_std:2:gfc-internal-format \ 
 --keyword=gfc_warning:1:gfc-internal-format \ 
 --keyword=gfc_warning_now:1:gfc-internal-format 

If you want to generate these options automatically, you'll need to modify
the 'po/exgettext' script.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[joseph at codesourcery dot com]

------- Comment #8 from joseph at codesourcery dot com  2009-03-29 16:59 -------
Subject: Re:  gfc_error formats are not marked
 gcc-internal-format in po file

On Sun, 29 Mar 2009, bruno at clisp dot org wrote:

> The xgettext options that need to be passed to "xgettext --language=GCC-source"
> are:
>  --keyword=gfc_error:1:gfc-internal-format \ 
>  --keyword=gfc_error_now:1:gfc-internal-format \ 
>  --keyword=gfc_fatal_error:1:gfc-internal-format \ 
>  --keyword=gfc_internal_error:1:gfc-internal-format \ 
>  --keyword=gfc_notify_std:2:gfc-internal-format \ 
>  --keyword=gfc_warning:1:gfc-internal-format \ 
>  --keyword=gfc_warning_now:1:gfc-internal-format 
> 
> If you want to generate these options automatically, you'll need to modify
> the 'po/exgettext' script.

For example, you might arrange for the script to do this for functions 
with a parameter named "fmsgid" (see the discussion in ABOUT-GCC-NLS of 
the conventions used).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[dfranke at gcc dot gnu dot org]

------- Comment #9 from dfranke at gcc dot gnu dot org  2009-12-07 18:40 -------
With the upcoming release of 4.5, I think it would be nice to fix/improve the
translation related bugs now, i.e. this, PR38573 and PR40489.

As I have no idea how to reproduce/check/whatever this kind of PR, could
somebody be so kind to add a step-by-step description of the commands that need
to be invoked to do so?

Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[pault at gcc dot gnu dot org]

------- Comment #10 from pault at gcc dot gnu dot org  2009-12-17 20:54 -------
(In reply to comment #9)
> With the upcoming release of 4.5, I think it would be nice to fix/improve the
> translation related bugs now, i.e. this, PR38573 and PR40489.
> 
> As I have no idea how to reproduce/check/whatever this kind of PR, could
> somebody be so kind to add a step-by-step description of the commands that need
> to be invoked to do so?
> 
> Thanks.
>

Daniel,

Would you be so kind as to follow this.  It's been unconfirmed for 18 months. 
Is it a bug or not and will we or won't we fix it?

I vote for a WONTFIX to be honest.

Cheers

Paul


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[dfranke at gcc dot gnu dot org]

------- Comment #11 from dfranke at gcc dot gnu dot org  2009-12-17 23:07 -------
[Adding Paul as CC]

(In reply to comment #10)
> Would you be so kind as to follow this.  It's been unconfirmed for 18 months. 
> Is it a bug or not and will we or won't we fix it?
> 
> I vote for a WONTFIX to be honest.

As stated before, I'm quite clueless. Presumely, one would get started with
"--enable-nls" during configure. But then ... ?!

Set to WAITING. Suggest to close as WONTFIX if there is no further activity
here (regarding comment #9) until May 2010. Ok?


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
  GCC build triplet|                            |pault@gcc.gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[burnus at gcc dot gnu dot org]

------- Comment #12 from burnus at gcc dot gnu dot org  2009-12-18 09:56 -------
> With the upcoming release of 4.5, I think it would be nice to fix/improve the
> translation related bugs now, i.e. this, PR38573 and PR40489.
> 
> As I have no idea how to reproduce/check/whatever this kind of PR, could
> somebody be so kind to add a step-by-step description of the commands that
> need to be invoked to do so?

No real step-by step introduction, but
a) Reading gcc/ABOUT-GCC-NLS
b) Modifying gcc/po/exgettext

In the latter, one takes care that %e... get properly tagged; see the function
"keyword_option" which tags them as c-format / no-c-format /
gcc-internal-format.

See also
http://www.gnu.org/software/hello/manual/gettext/xgettext-Invocation.html and
http://www.gnu.org/software/hello/manual/gettext/c_002dformat-Flag.html

As blunt solution, one could simply do what as proposed in comment 5: Add the
--keyword= lines to gcc/po/exgettext to the invocation of $xgettext.

A more advanced solution is to do what has been suggested in comment 6;
however, that does not fit the current use of messages in gfortran. What has
been done there is described in gcc/ABOUT-GCC-NLS.

For instance one calls in gcc:
  error ("register name not specified for %q+D", decl);
The function prototype is:
  void error (const char *gmsgid, ...)
Here, "msgid" triggers the the matching in "exgettext" and "g" indicates that
it is not a default C format string but a special one (cf. description in
ABOUT-GCC-NLS).

Seemingly we already ue "msgid", but not with the proper prefix:
  gfc_notify_std (int std, const char *nocmsgid, ...)
"nocmsgid" is currently translated to "no-c-format" but we want to have
gcc-internal-format or gfc-internal-format. The current matches are
(gcc/po/exgettext's function keyword_option):

    if (args ~ /g$/)
        format="gcc-internal-format"
    else if (args ~ /noc$/)
        format="no-c-format"
    else if (args ~ /c$/)
        format="c-format"

Thus "gmsgid" would be one solution or "gfcmsgid" another with adding a
    else if (args ~ /gfc$/)
        format="gfc-internal-format"

Thus, fixing error.c and possibly editing gcc/po/exgettext should be enough.


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2009-12-18 09:56:10
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[dfranke at gcc dot gnu dot org]

------- Comment #13 from dfranke at gcc dot gnu dot org  2009-12-18 18:27 -------
Tobias, thanks for your description. I'm still a bit hazy on the details, but I
changed my tree according to what I picked up. Question is, how do I verify
that the issue described in the initial report is fixed?

Currently rebuilding with maintainer-mode and nls enabled ...


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu dot org
  GCC build triplet|pault@gcc.gnu.org           |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[dfranke at gcc dot gnu dot org]

------- Comment #14 from dfranke at gcc dot gnu dot org  2009-12-19 11:38 -------
(In reply to comment #7)
> Support for this type of format has now been added to xgettext. The support
> will be contained in gettext 0.18.

I got as far as recreating the .pot for testing. Tried to compile the updated
gettext (comment #7) from git, but the dependencies, e.g. full Java and C#/Mono
envvironments, are too numerous to follow that route. Thus waiting for
gettext-0.18 to be released.


-- 

dfranke at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |dfranke at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2009-12-18 09:56:10         |2009-12-19 11:38:55
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[burnus at gcc dot gnu dot org]

------- Comment #15 from burnus at gcc dot gnu dot org  2010-01-04 07:45 -------
I believe the patch at
  http://gcc.gnu.org/ml/fortran/2010-01/msg00023.html
should be sufficient.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[burnus at gcc dot gnu dot org]

------- Comment #16 from burnus at gcc dot gnu dot org  2010-01-04 21:01 -------
Subject: Bug 36161

Author: burnus
Date: Mon Jan  4 21:01:10 2010
New Revision: 155632

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155632
Log:
2010-01-04  Tobias Burnus  <burnus@net-b.de>

        PR fortran/36161
        * error.c (error_printf, gfc_warning, gfc_notify_std,
        gfc_warning_now, gfc_error, gfc_error_now,
        gfc_fatal_error): Change argument name from nocmsgid to
        gmsgid to enable (x)gettext's % checking.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/error.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[burnus at gcc dot gnu dot org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]



------- Comment #17 from burnus at gcc dot gnu dot org  2010-01-04 21:13 -------
FIXED. Thanks Göran for the suggestion! If you want to try, I can send you the
gcc.pot file of the current 4.5 trunk (or do "cd $GCC_build_dir/gcc; make
gcc.pot" to create ./po/gcc.pot yourself.)

See also http://gcc.gnu.org/ml/fortran/2010-01/msg00033.html

> (Yes, it happened.  I had done a few such mistakes in sv.po, which was just
> pointed out to me in a friendly letter.)

That was me - after debugging some crashes in the gfortran; I created some
shell/grep/perl script to find such lines. But this fix is much better!


-- 

burnus at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[goeran at uddeborg dot se]

------- Comment #18 from goeran at uddeborg dot se  2010-01-11 17:27 -------
I did try it out as you suggested, and it seems to work just fine.

(I.e. messages from fortran/arith.c were said to come from fortraarith.c in the
pot file.  But I didn't bother to investigate that, it wasn't what I was there
to check.)

I thought we had to wait for gettext 0.18 for this, but apparently not.

One detail I happened to see: The messages defined in gfc_arith_error doesn't
get any gcc-internal-format marker, though they do contain %L.  Do you want a
separate bugzilla about that?


-- 

goeran at uddeborg dot se changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[burnus at gcc dot gnu dot org]

------- Comment #19 from burnus at gcc dot gnu dot org  2010-01-11 20:21 -------
(In reply to comment #1)
> One detail I happened to see: The messages defined in gfc_arith_error doesn't
> get any gcc-internal-format marker, though they do contain %L.  Do you want a
> separate bugzilla about that?

Yes please.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161

[Bug fortran/36161] gfc_error formats are not marked gcc-internal-format in po file

[goeran at uddeborg dot se]

------- Comment #20 from goeran at uddeborg dot se  2010-01-11 21:02 -------
(In reply to comment #19)
> Yes please.

I've filed bug 42693 about that.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36161