[Bug testsuite/28870] New: configuring, over-riding timeout values in testsuite

[Bug testsuite/28870] New: configuring, over-riding timeout values in testsuite

[bkoz at gcc dot gnu dot org]

This change:
http://gcc.gnu.org/ml/gcc-patches/2006-06/msg01487.html

Has caused problems with people who set a custom timeout value in .exp files.

Examples include:
http://gcc.gnu.org/ml/gcc/2006-08/msg00371.html
and
http://gcc.gnu.org/ml/libstdc++/2006-08/msg00027.html

Mike's suggestion to do timeout=timeout*2 is interesting, but I don't know if
that really solves the issue. Perhaps the answer that I'm searching for is to
see if timeout has been set, if so, use it. If not, set it.

I'm hoping that some of the testsuite maintainers can figure out a better way
to approach this whole issue.

-benjamin


-- 
           Summary: configuring, over-riding timeout values in testsuite
           Product: gcc
           Version: 4.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bkoz at gcc dot gnu dot org
  GCC host triplet: all


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2006-08-31 02:53 -------
Confirmed, this is a regression.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2006-08-31 02:53:03
               date|                            |
            Summary|configuring, over-riding    |[4.2 Regression]
                   |timeout values in testsuite |configuring, over-riding
                   |                            |timeout values in testsuite
   Target Milestone|---                         |4.2.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[sje at cup dot hp dot com]

------- Comment #2 from sje at cup dot hp dot com  2006-09-12 16:36 -------
I wonder if it would be possible to implement something like 'dg-timeout 600'
so that the timeout could be changed for just some tests and possibly just on
some hosts by using the target option with dg-timeout.  Most of the problems we
have with timeouts are only on a few tests in each testsuite.


-- 

sje at cup dot hp dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sje at cup dot hp dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #3 from janis at gcc dot gnu dot org  2006-09-12 23:23 -------
I'm starting to figure out how all this works.  A quick fix for now might be,
as Benjamin suggested, for libstdc++.exp to only change the timeout value if it
doesn't already exist.  That could be done with

    if [target_info exists gcc,timeout] {
        lappend options "timeout=[target_info gcc,timeout]"
    } else {
        lappend options "timeout=600"
    }

If someone here knows how to specify a timeout value in RUNTESTFLAGS or to set
it from .dejagnurc, please let me know.

If other people agree with Steve that it would be useful to be able to change
the timeout value for individual tests, let me know and I'll look into that. 
It sounds as if it would get messy to have it be an actual time; perhaps a
multiplier for the normal timeout would be better.


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janis at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #4 from janis at gcc dot gnu dot org  2006-09-12 23:42 -------
Mike, I added you to the cc: list because you know a lot about how DejaGnu is
used with the GCC testsuite and undoubtedly have useful things to add to the
discussion.


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrs at apple dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[bkoz at gcc dot gnu dot org]

------- Comment #5 from bkoz at gcc dot gnu dot org  2006-09-13 06:26 -------

Janis, this is how to set timeout on the "make check" command line:

time make check RUNTESTFLAGS="-v -v -v -v --tool_opts timeout=300"


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #6 from janis at gcc dot gnu dot org  2006-09-13 16:54 -------
Benjamin, I had tried that, but it adds "timeout=300" to the options passed to
the compiler.  Does it really work for you?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[bkoz at gcc dot gnu dot org]

------- Comment #7 from bkoz at gcc dot gnu dot org  2006-09-21 21:10 -------

Whoops, Janis, you are right. Sorry for the false alarm. The fancy dejagnu line
I spit out at you does nothing.

I also tried to hack up this as you suggested:

Index: testsuite/lib/libstdc++.exp
===================================================================
--- testsuite/lib/libstdc++.exp (revision 117118)
+++ testsuite/lib/libstdc++.exp (working copy)
@@ -350,8 +350,14 @@
     }

     lappend options "compiler=$cxx_final"
-    lappend options "timeout=600"

+    # This is a hack to set the timeout higher.
+    if [target_info exists gcc,timeout] {
+        lappend options "timeout=[target_info gcc,timeout]"
+    } else {
+        lappend options "timeout=600"
+    }
+
     return [target_compile $source $dest $type $options]
 }

However, I'm not quite sure how to test that people can over-ride timeout now.

Can any testsuite maintainer help please? Just some clear directions on how to
do this stuff would be appreciated. 

-benjamin


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2 Regression] configuring, over-riding timeout values in testsuite

[bkoz at gcc dot gnu dot org]

------- Comment #8 from bkoz at gcc dot gnu dot org  2006-10-09 21:45 -------

Note this issue is not c++ or libstdc++ specific. I see timeouts on old
hardware all over the testsuite on gcc-testresults.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[christian dot joensson at gmail dot com]

------- Comment #9 from christian dot joensson at gmail dot com  2006-11-28 09:17 -------
ping

any news on this one?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[hp at gcc dot gnu dot org]

------- Comment #10 from hp at gcc dot gnu dot org  2007-02-07 10:09 -------
Subject: Bug 28870

Author: hp
Date: Wed Feb  7 10:09:41 2007
New Revision: 121684

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121684
Log:
        PR testsuite/28870
        * testsuite/27_io/basic_stringbuf/overflow/char/1.cc: Use only
        10000 iterations for simulator targets.
        * testsuite/ext/pb_ds/regression/tree_data_map_rand.cc: Use only 5
        iterations for simulator targets.
        * testsuite/ext/pb_ds/regression/tree_no_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/trie_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/trie_no_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/hash_no_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/hash_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/priority_queue_rand.cc: Ditto.
        * testsuite/23_containers/set/modifiers/16728.cc: Use only 10
        iterations for simulator targets.

Modified:
    trunk/libstdc++-v3/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[hp at gcc dot gnu dot org]

------- Comment #11 from hp at gcc dot gnu dot org  2007-02-07 10:12 -------
Subject: Bug 28870

Author: hp
Date: Wed Feb  7 10:12:21 2007
New Revision: 121686

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=121686
Log:
        PR testsuite/28870
        * testsuite/27_io/basic_stringbuf/overflow/char/1.cc: Use only
        10000 iterations for simulator targets.
        * testsuite/ext/pb_ds/regression/tree_data_map_rand.cc: Use only 5
        iterations for simulator targets.
        * testsuite/ext/pb_ds/regression/tree_no_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/trie_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/trie_no_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/hash_no_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/hash_data_map_rand.cc: Ditto.
        * testsuite/ext/pb_ds/regression/priority_queue_rand.cc: Ditto.
        * testsuite/23_containers/set/modifiers/16728.cc: Use only 10
        iterations for simulator targets.

Modified:
    branches/gcc-4_2-branch/libstdc++-v3/ChangeLog
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/23_containers/set/modifiers/16728.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/27_io/basic_stringbuf/overflow/char/1.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/ext/pb_ds/regression/hash_data_map_rand.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/ext/pb_ds/regression/hash_no_data_map_rand.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/ext/pb_ds/regression/priority_queue_rand.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/ext/pb_ds/regression/tree_data_map_rand.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/ext/pb_ds/regression/tree_no_data_map_rand.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/ext/pb_ds/regression/trie_data_map_rand.cc
   
branches/gcc-4_2-branch/libstdc++-v3/testsuite/ext/pb_ds/regression/trie_no_data_map_rand.cc


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[hp at gcc dot gnu dot org]

------- Comment #12 from hp at gcc dot gnu dot org  2007-02-07 10:16 -------
The checked-in changes marked with this PR don't solve the timeout issue by
far,
but hint of a way to solve timeout problems for specific tests, for specific
(classes of) systems, in another way than changing the default timeout.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[mmitchel at gcc dot gnu dot org]

------- Comment #13 from mmitchel at gcc dot gnu dot org  2007-05-14 22:25 -------
Will not be fixed in 4.2.0; retargeting at 4.2.1.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.0                       |4.2.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.1                       |4.2.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[mmitchel at gcc dot gnu dot org]

------- Comment #14 from mmitchel at gcc dot gnu dot org  2007-10-09 19:21 -------
Change target milestone to 4.2.3, as 4.2.2 has been released.


-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.2                       |4.2.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |janis at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2007-09-01 20:46:36         |2007-10-23 17:39:33
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #15 from janis at gcc dot gnu dot org  2007-10-23 17:38 -------
I've been looking at this again and now have a better understanding of how
timeouts are handled and how to set variables used within the testsuite.

Timeouts for compilation can be controlled by passing --timeout=n in the list
of options for target_compile.  The GCC testsuite procedures that call it can
pass in the value from a target board, or from a global variable set in
${HOME}/.dejagnurc, or a value for a specific test in a (not-yet-existing)
dg-timeout directive.  Timeouts for execution are controlled in the mudflap
testsuite by overriding the DejaGnu proc standard_wait; other testsuites can do
the same thing, and can look for new timeout values from a variety of sources.

Before I go any further with this, is there interest in a dg-timeout to
override timeouts for individual tests, with a target specifier?  Should it
apply to compilation times and test execution?  Is there interest in a timeout
value provided in ~/.dejagnurc or site.exp that applies to all tests, or
perhaps to a particular testsuite like gcc_timeout or v3_timeout?  Should
timeout values be in seconds, or in terms of some multiplier also defined for a
testsuite, or a target, or by the person running the tests?

This is for tests expected to have problems; H-P's method is better for
cranking down the amount of time spent for tests on simulators or slow
hardware.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[rask at gcc dot gnu dot org]

------- Comment #16 from rask at gcc dot gnu dot org  2007-11-17 12:19 -------
A directive which allows a test to increase the timeout to x times the normal
timeout would probably be a good idea. A few of the tests take much longer than
most and IMO their timeout should be set based on the default timeout, which we
assume the user sets to something appropriate for the machine used for testing.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3 Regression] configuring, over-riding timeout values in testsuite

[jsm28 at gcc dot gnu dot org]

------- Comment #17 from jsm28 at gcc dot gnu dot org  2008-02-01 16:53 -------
4.2.3 is being released now, changing milestones of open bugs to 4.2.4.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.3                       |4.2.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[nightstrike at gmail dot com]

------- Comment #18 from nightstrike at gmail dot com  2008-04-06 16:03 -------
What is the status on this?  I am having a lot of test timeouts when testing
the x86_64-pc-mingw cross compiler, as sometimes there are slow programd and
annoying ssh network delays.  Extending the timeout in a robust way would be
very helpful.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[jsm28 at gcc dot gnu dot org]

------- Comment #19 from jsm28 at gcc dot gnu dot org  2008-05-19 20:22 -------
4.2.4 is being released, changing milestones to 4.2.5.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.4                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[sje at cup dot hp dot com]

------- Comment #20 from sje at cup dot hp dot com  2008-11-18 22:39 -------
I see there were some patches submitted for this issue

http://gcc.gnu.org/ml/gcc-patches/2008-02/msg01098.html
http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00267.html

I get timeouts on my slow hppa system and would be interested in being able to
extend the timeout value on some slower tests like g++.dg/torture/pr31863.C and
gcc.c-torture/compile/20001226-1.c.

Janice, are you still looking at this?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #21 from janis at gcc dot gnu dot org  2008-11-18 22:48 -------
Interesting that you should ask, I modified the patch yesterday and intend to
submit it as soon as I've done some more testing.

The current version adds dg-timeout, which sets the timeout for running the
compiler in gcc and libstdc++ tests to a specified number of seconds, or
dg-timeout-factor, which multiplies the usual timeout by the specified factor. 
The "usual timeout" is the value for the target board, which can be overridden
by gcc_timeout or v3_timeout defined in $HOME/.dejagnurc.  Let me know if
you've got suggestions for improvement.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[sje at cup dot hp dot com]

------- Comment #22 from sje at cup dot hp dot com  2008-11-18 23:21 -------
Your plan sounds good to me.  I am thinking that using the timeout-factor
on g++.dg/torture/pr31863.C,  gcc.c-torture/compile/20001226-1.c, and
gcc.dg/20020425-1.c to deal with the compiler timeouts on these long compiles
will help remove spurious failures from my nightly runs.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #23 from janis at gcc dot gnu dot org  2008-11-21 00:58 -------
I posted a patch for compiler tests at

  http://gcc.gnu.org/ml/gcc-patches/2008-11/msg01066.html

but after playing around more realized that it shouldn't be necessary to allow
setting a default in .dejagnurc, since the tester should be able to specify a
target board that has a timeout.  I tried that, adding "set_board_info
gcc,timeout 100" to the baseboards/unix.exp file that's being used, and nothing
happened; the tests still use the 300-second default from DejaGnu's remote_exec
proc in remote.exp.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #24 from janis at gcc dot gnu dot org  2008-11-21 01:28 -------
For the libstdc++ tests, which are the original focus of this PR, is it enough
to provide dg-timeout and dg-timeout-factor and either leave the 600 default,
or else take the larger of that and [target_info gcc,timeout]?

By the way, dg-timeout-factor from my latest patch takes a floating-point value
so it can be used to limit the time used for a known hanging test as well as
enabling long-running tests to complete.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #25 from janis at gcc dot gnu dot org  2008-11-24 22:31 -------
I'm still tweaking this, to support dg-timeout and dg-timeout-factor plus
tool-specific default timeouts for gcc, libstdc++-v3, libgomp, and libmudflap.

As for picking up gcc,timeout for the target board I discovered that it helps
immensely if the unix.exp file I modify is the one on the machine where I'm
running the tests; d'oh.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #26 from janis at gcc dot gnu dot org  2008-11-26 18:52 -------
Subject: Bug 28870

Author: janis
Date: Wed Nov 26 18:51:07 2008
New Revision: 142225

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142225
Log:
gcc/
        PR testsuite/28870
        * doc/sourcebuild.texi (Test Directives): Add dg-timeout and
        dg-timeout-factor.

gcc/testsuite/
        PR testsuite/28870
        * lib/timeout.exp: New.
        * lib/timeout-dg.exp: New.
        * lib/gcc-dg.exp: Include new timeout library files.
        (dg-test): Unset timeout variables.
        * lib/gcc.exp (gcc_target_compile): Set timeout value from new proc.
        * lib/g++.exp (g++_target_compile): Ditto.
        * lib/gfortran.exp (gfortran_target_compile): Ditto.
        * lib/objc.exp (objc_target_compile): Ditto.
        * lib/obj-c++.exp (obj-c++_target_compile): Ditto.
        * lib/obj-c++.exp (obj-c++_target_compile): Ditto.
        * lib/gnat.exp (gnat_target_compile): Ditto.

libstdc++-v3/
        PR testsuite/28870
        * testsuite/lib/libstdc++.exp: Include new timeout library files.
        (libstdc++_init): Define tool_timeout.
        (dg-test): Override DejaGnu proc.
        (v3_target_compile): Set timeout value from new proc.
        (v3_target_compile_as_c): Ditto.

libmudflap/
        PR testsuite/28870
        * testsuite/lib/mfdg.exp (dg-test): Use new timeout support.
        (dg-timeout): Remove.
        (standard-wait): Remove.
        * testsuite/lib/libmudflap.exp: Include new timeout library files.
        (libmudflap_target_compile): Set timeout value from new proc.

libgomp/
        PR testsuite/28870
        * testsuite/lib/libgomp.exp: Include new timeout library files.
        (libgomp_target_compile): Set timeout value from new proc.

Added:
    trunk/gcc/testsuite/lib/timeout-dg.exp
    trunk/gcc/testsuite/lib/timeout.exp
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/doc/sourcebuild.texi
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/lib/g++.exp
    trunk/gcc/testsuite/lib/gcc-dg.exp
    trunk/gcc/testsuite/lib/gcc.exp
    trunk/gcc/testsuite/lib/gfortran.exp
    trunk/gcc/testsuite/lib/gnat.exp
    trunk/gcc/testsuite/lib/obj-c++.exp
    trunk/gcc/testsuite/lib/objc.exp
    trunk/libgomp/ChangeLog
    trunk/libgomp/testsuite/lib/libgomp.exp
    trunk/libmudflap/ChangeLog
    trunk/libmudflap/testsuite/lib/libmudflap.exp
    trunk/libmudflap/testsuite/lib/mfdg.exp
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/testsuite/lib/libstdc++.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #27 from janis at gcc dot gnu dot org  2008-11-26 22:16 -------
Subject: Bug 28870

Author: janis
Date: Wed Nov 26 22:15:07 2008
New Revision: 142230

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142230
Log:
        PR testsuite/28870
        * lib/objc.exp (objc_target_compile): Fix typo from previous change.
        * lib/gnat.exp (gnat_target_compile): Fix typo from previous change.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/lib/gnat.exp
    trunk/gcc/testsuite/lib/objc.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #28 from janis at gcc dot gnu dot org  2008-12-02 17:45 -------
Subject: Bug 28870

Author: janis
Date: Tue Dec  2 17:44:08 2008
New Revision: 142366

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=142366
Log:
        Backport from mainline:
        2008-11-26  Janis Johnson  <janis187@us.ibm.com>

gcc/
        PR testsuite/28870
        * doc/sourcebuild.texi (Test Directives): Add dg-timeout and
        dg-timeout-factor.
gcc/testsuite/
        PR testsuite/28870
        * lib/timeout.exp: New.
        * lib/timeout-dg.exp: New.
        * lib/gcc-dg.exp: Include new timeout library files.
        (dg-test): Unset timeout variables.
        * lib/gcc.exp (gcc_target_compile): Set timeout value from new proc.
        * lib/g++.exp (g++_target_compile): Ditto.
        * lib/gfortran.exp (gfortran_target_compile): Ditto.
        * lib/objc.exp (objc_target_compile): Ditto.
        * lib/obj-c++.exp (obj-c++_target_compile): Ditto.
        * lib/obj-c++.exp (obj-c++_target_compile): Ditto.
        * lib/gnat.exp (gnat_target_compile): Ditto.
libstdc++-v3/
        PR testsuite/28870
        * testsuite/lib/libstdc++.exp: Include new timeout library files.
        (libstdc++_init): Define tool_timeout.
        (dg-test): Override DejaGnu proc.
        (v3_target_compile): Set timeout value from new proc.
        (v3_target_compile_as_c): Ditto.
libmudflap/
        PR testsuite/28870
        * testsuite/lib/mfdg.exp (dg-test): Use new timeout support.
        (dg-timeout): Remove.
        (standard-wait): Remove.
        * testsuite/lib/libmudflap.exp: Include new timeout library files.
        (libmudflap_target_compile): Set timeout value from new proc.
libgomp/
        PR testsuite/28870
        * testsuite/lib/libgomp.exp: Include new timeout library files.
        (libgomp_target_compile): Set timeout value from new proc.

Added:
    branches/gcc-4_3-branch/gcc/testsuite/lib/timeout-dg.exp
    branches/gcc-4_3-branch/gcc/testsuite/lib/timeout.exp
Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/doc/sourcebuild.texi
    branches/gcc-4_3-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_3-branch/gcc/testsuite/lib/g++.exp
    branches/gcc-4_3-branch/gcc/testsuite/lib/gcc-dg.exp
    branches/gcc-4_3-branch/gcc/testsuite/lib/gcc.exp
    branches/gcc-4_3-branch/gcc/testsuite/lib/gfortran.exp
    branches/gcc-4_3-branch/gcc/testsuite/lib/gnat.exp
    branches/gcc-4_3-branch/gcc/testsuite/lib/obj-c++.exp
    branches/gcc-4_3-branch/gcc/testsuite/lib/objc.exp
    branches/gcc-4_3-branch/libgomp/ChangeLog
    branches/gcc-4_3-branch/libgomp/testsuite/lib/libgomp.exp
    branches/gcc-4_3-branch/libmudflap/ChangeLog
    branches/gcc-4_3-branch/libmudflap/testsuite/lib/libmudflap.exp
    branches/gcc-4_3-branch/libmudflap/testsuite/lib/mfdg.exp
    branches/gcc-4_3-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_3-branch/libstdc++-v3/testsuite/lib/libstdc++.exp


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870

[Bug testsuite/28870] [4.2/4.3/4.4 Regression] configuring, over-riding timeout values in testsuite

[janis at gcc dot gnu dot org]

------- Comment #29 from janis at gcc dot gnu dot org  2008-12-02 17:49 -------
Fixed in trunk (4.4) and 4.3; 4.2 isn't expected to have additional releases so
I haven't backported it there.

The patch solves the original reported problem, a hard-coded timeout for
libstdc++ tests, by allowing the timeout value for a testsuite to be overridden
by "gcc,,timeout" in the target board, and for individual tests to specify a
timeout either by a number of seconds or by a multiple of the current default
timeout.  The same mechanism is also used now by the compiler tests and tests
for libmudflap and libgomp; it can be extended to libffi and libjava if there
is interest.


-- 

janis at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28870