[Bug c/34146] [4.1/4.2/4.3 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[Bug c/34146] [4.1/4.2/4.3 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |33723
   Target Milestone|---                         |4.2.3


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] New: [4.1/4.2/4.3 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[pinskia at gcc dot gnu dot org]

Exactly like PR 33723 except the compound literal is inside a CONSTRUCTOR (you
can combine compound literals and normal constructors to make this worse).
Testcase:
typedef  struct
  {
    int f1, f2, f3, f4, f5, f6, f7, f8;
    long int f9, f10;
    int f11;
  } f;
typedef union
{
  f f;
  char s[56];
  long int a;
} T;

void
foo (void)
{
  T t =  { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 } };
  test (&t);
}

void
bar (void)
{
  T t = { (f){ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 } };
  test (&t);
}

----
Basically the fix for PR 33723 was not complete.  I have a more complete fix
but it does not fix the case where you include more compound literals inside
another one.


-- 
           Summary: [4.1/4.2/4.3 Regression] Inefficient code with compound
                    literals inside a CONSTRUCTO
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] [4.1/4.2/4.3 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2007-11-19 14:58 -------
Testing a fix.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2007-11-19 14:58:04
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] [4.1/4.2/4.3 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2007-11-20 10:36 -------
Subject: Bug 34146

Author: jakub
Date: Tue Nov 20 10:36:03 2007
New Revision: 130311

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=130311
Log:
        PR c/34146
        * c-gimplify.c (optimize_compound_literals_in_ctor): New function.
        (c_gimplify_expr): Use it.

        PR c/34146
        * gcc.dg/tree-ssa/pr34146.c: New test.

        PR testsuite/33978
        * gcc.dg/tree-ssa/pr33723.c: Adjust scan pattern to make it less
        dependent on target settings like move_by_pieces etc.

Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr34146.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-gimplify.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/tree-ssa/pr33723.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] [4.1/4.2 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2007-11-20 11:00 -------
Fixed on the trunk.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2/4.3 Regression]    |[4.1/4.2 Regression]
                   |Inefficient code with       |Inefficient code with
                   |compound literals inside a  |compound literals inside a
                   |CONSTRUCTO                  |CONSTRUCTO


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] [4.1/4.2 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[jsm28 at gcc dot gnu dot org]

------- Comment #4 from jsm28 at gcc dot gnu dot org  2008-02-01 16:55 -------
4.2.3 is being released now, changing milestones of open bugs to 4.2.4.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.3                       |4.2.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] [4.1/4.2 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[jsm28 at gcc dot gnu dot org]

------- Comment #5 from jsm28 at gcc dot gnu dot org  2008-05-19 20:23 -------
4.2.4 is being released, changing milestones to 4.2.5.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.4                       |4.2.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] [4.2 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[jsm28 at gcc dot gnu dot org]

------- Comment #6 from jsm28 at gcc dot gnu dot org  2008-07-04 22:53 -------
Closing 4.1 branch.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.1/4.2 Regression]        |[4.2 Regression] Inefficient
                   |Inefficient code with       |code with compound literals
                   |compound literals inside a  |inside a CONSTRUCTO
                   |CONSTRUCTO                  |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146

[Bug c/34146] [4.2 Regression] Inefficient code with compound literals inside a CONSTRUCTO

[jsm28 at gcc dot gnu dot org]

------- Comment #7 from jsm28 at gcc dot gnu dot org  2009-03-31 00:38 -------
Closing 4.2 branch, fixed in 4.3.


-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |4.2.5
      Known to work|                            |4.3.0
         Resolution|                            |FIXED
   Target Milestone|4.2.5                       |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34146