public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/36713] [4.4 regression] r137252 breaks -O2 optimization on x86_64-unknown-linux-gnu
Date: Thu, 03 Jul 2008 12:55:00 -0000	[thread overview]
Message-ID: <20080703125435.21394.qmail@sourceware.org> (raw)
In-Reply-To: <bug-36713-13648@http.gcc.gnu.org/bugzilla/>



------- Comment #12 from rguenther at suse dot de  2008-07-03 12:54 -------
Subject: Re:  [4.4 regression] r137252 breaks -O2 optimization
 on x86_64-unknown-linux-gnu

On Thu, 3 Jul 2008, dfranke at gcc dot gnu dot org wrote:

> ------- Comment #11 from dfranke at gcc dot gnu dot org  2008-07-03 12:45 -------
>> I guess the assembly is different, right?
>
> Yes, it is. Comparing *.s files from FCFLAGS="-O2 -save-temps", there are
> differences in one file - though not the one suspected in comment #7.
>
> There is one difference in the .optimized file that I could easily identify:
> -  D.1935 = dummy_atom_model_inertia_tensor (this, phase);
> -  __result_dummy_atom_model_rad.21 = inertia_tensor_to_rg (&D.1935);
> +  D.1935 = dummy_atom_model_inertia_tensor (this, phase) [return slot
> optimization];
> +  __result_dummy_atom_model_rad.21 = inertia_tensor_to_rg (&D.1935) [tail
> call];

Ok, that is an interesting difference.  Can you try if 
-fno-optimize-sibling-calls fixes it (that should remove the [tail call]).
Unfortunately there is no option to disable the return slot optimization,
so you have to disable that in the source (tree-nrv.c, just return early
from execute_return_slot_opt).

Obviously the above may be a valid extra optimization ...

Richard.

>
> And there are plenty in *.alias, e.g.:
>  Aliased symbols
>
>  -D.1935, UID D.1935, struct inertia_tensor, is addressable, score: 8, direct
> reads: 0, direct writes: 0, indirect reads: 0, indirect writes: 2, call
> clobbered (passed to call)
>  +D.1935, UID D.1935, struct inertia_tensor, is addressable, score: 0, direct
> reads: 0, direct writes: 0, indirect reads: 0, indirect writes: 0
>
> The difference file has 3000+ lines here, one could argue that the dumps are
> significantly different ;)
>
>
>


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36713


  parent reply	other threads:[~2008-07-03 12:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03  9:09 [Bug target/36713] New: " dfranke at gcc dot gnu dot org
2008-07-03  9:13 ` [Bug target/36713] " rguenther at suse dot de
2008-07-03  9:15 ` dfranke at gcc dot gnu dot org
2008-07-03  9:43 ` rguenther at suse dot de
2008-07-03  9:54 ` franke dot daniel at gmail dot com
2008-07-03 10:09 ` rguenther at suse dot de
2008-07-03 10:41 ` dfranke at gcc dot gnu dot org
2008-07-03 11:42 ` dfranke at gcc dot gnu dot org
2008-07-03 11:50 ` rguenther at suse dot de
2008-07-03 12:00 ` dfranke at gcc dot gnu dot org
2008-07-03 12:04 ` rguenther at suse dot de
2008-07-03 12:46 ` dfranke at gcc dot gnu dot org
2008-07-03 12:55 ` rguenther at suse dot de [this message]
2008-07-03 13:01 ` dfranke at gcc dot gnu dot org
2008-07-03 13:11 ` rguenther at suse dot de
2008-07-03 19:00 ` dfranke at gcc dot gnu dot org
2008-07-03 19:27 ` rguenther at suse dot de
2008-07-03 19:34 ` franke dot daniel at gmail dot com
2008-07-03 19:45 ` rguenther at suse dot de
2008-07-04 15:07 ` rguenth at gcc dot gnu dot org
2008-07-04 15:07 ` rguenth at gcc dot gnu dot org
2008-07-04 15:47 ` rguenth at gcc dot gnu dot org
2008-07-04 21:36 ` dfranke at gcc dot gnu dot org
2008-07-06 13:30 ` rguenth at gcc dot gnu dot org
2008-07-07 15:12 ` rguenth at gcc dot gnu dot org
2008-07-07 15:17 ` rguenth at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080703125435.21394.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).