[Bug target/36904] New: [4.4 Regression] vector context sensitive keyword vs macros

[Bug target/36904] New: [4.4 Regression] vector context sensitive keyword vs macros

[pinskia at gcc dot gnu dot org]

Take the following testcase:
#include <altivec.h>
#define xprint_vec(type)  void x##type(vector type v) { }
xprint_vec(float);

This used to work in 4.3 and before but does not currently.  The problem here
was introduced when the context sensitive keyword support was added.


-- 
           Summary: [4.4 Regression] vector context sensitive keyword vs
                    macros
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pinskia at gcc dot gnu dot org
GCC target triplet: powerpc-linux


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904

[Bug target/36904] [4.4 Regression] vector context sensitive keyword vs macros

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904

[Bug target/36904] [4.4 Regression] vector context sensitive keyword vs macros

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2008-08-01 12:45 -------
Created an attachment (id=15990)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15990&action=view)
gcc44-pr36904.patch

Partial fix, which fixes the testcase from this PR, but still other cases
in the made up testcase fail and I don't know if they are meant to work or not.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904

[Bug target/36904] [4.4 Regression] vector context sensitive keyword vs macros

[mmitchel at gcc dot gnu dot org]

-- 

mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904

[Bug target/36904] [4.4 Regression] vector context sensitive keyword vs macros

[bje at au1 dot ibm dot com]

------- Comment #2 from bje at au1 dot ibm dot com  2008-08-26 12:29 -------
Subject: Re:  [4.4 Regression] vector context sensitive
        keyword vs macros

> Partial fix, which fixes the testcase from this PR, but still other cases
> in the made up testcase fail and I don't know if they are meant to
> work or not.

If it does not make things worse, should we apply this patch?

Ben


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904

[Bug target/36904] [4.4 Regression] vector context sensitive keyword vs macros

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2008-09-01 15:38 -------
Created an attachment (id=16179)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16179&action=view)
gcc44-pr36904.patch

Updated patch, apparently all other problems can be fixed just by never
expanding the conditional keywords to self.  This will make preprocessing them
tiny bit slower (as the macro_to_expand hook might be called several times on
it), but means we handle right even the cases where cpp_get_token is called
with
a conditional macro token in some inner context where following tokens aren't
seen yet (e.g. macro args, etc.).

I don't have any altivec.h codebase around, could one of you test this on
something larger?  Thanks.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15990|0                           |1
        is obsolete|                            |
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|UNCONFIRMED                 |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904

[Bug target/36904] [4.4 Regression] vector context sensitive keyword vs macros

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2008-09-10 21:07 -------
Subject: Bug 36904

Author: jakub
Date: Wed Sep 10 21:06:25 2008
New Revision: 140247

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=140247
Log:
        PR target/36904
        * config/rs6000/rs6000-c.c (rs6000_macro_to_expand): Return NULL
        instead of tok->val.node if not expanding to something else.  Handle
        intervening CPP_PADDING tokens.
        (altivec_categorize_keyword): Remove unneeded comparisons.

        * gcc.target/powerpc/altivec-27.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/powerpc/altivec-27.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/rs6000/rs6000-c.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904

[Bug target/36904] [4.4 Regression] vector context sensitive keyword vs macros

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2008-09-10 21:10 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36904