[Bug tree-optimization/36830] New: [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[Bug tree-optimization/36830] New: [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[danglin at gcc dot gnu dot org]

/test/gnu/gcc/objdir/./prev-gcc/xgcc -B/test/gnu/gcc/objdir/./prev-gcc/
-B/opt/g
nu/gcc/gcc-4.4.0/hppa2.0w-hp-hpux11.11/bin/ -c -g -O2 -mdisable-indexing    
-gn
atpg -gnata -gnatwns -nostdinc -I- -I. -Iada -I../../gcc/gcc/ada
../../gcc/gcc/a
da/s-os_lib.adb -o ada/s-os_lib.o
raised STORAGE_ERROR : stack overflow or erroneous memory access
make[3]: *** [ada/s-os_lib.o] Error 1

This was introduced in revision 137631.

So far, I haven't found a way to debug this error.  The error doesn't occur
when I run the compile under gdb, or when I enable the private mapping of
shared libraries.  Somehow, the code is attempting to write somewhere in the
region of memory occupied by libc.  gdb doesn't let me run programs without
mapping shared libraries as private.

Still present in revision 137803.


-- 
           Summary: [4.4 Regression] STORAGE_ERROR raised compiling s-
                    os_lib.adb
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa2.0w-hp-hpux11.11
  GCC host triplet: hppa2.0w-hp-hpux11.11
GCC target triplet: hppa2.0w-hp-hpux11.11


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2008-07-15 12:06 -------
*** Bug 36836 has been marked as a duplicate of this bug. ***


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreasmeier80 at gmx dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
  GCC build triplet|hppa2.0w-hp-hpux11.11       |
   GCC host triplet|hppa2.0w-hp-hpux11.11       |
 GCC target triplet|hppa2.0w-hp-hpux11.11       |
           Keywords|                            |build, ice-on-valid-code,
                   |                            |wrong-code
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[andreasmeier80 at gmx dot de]

------- Comment #2 from andreasmeier80 at gmx dot de  2008-07-16 09:52 -------
For me it was working in revision 137687


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[rguenth at gcc dot gnu dot org]

-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|                            |hppa2.0w-hp-hpux11.11
           Priority|P3                          |P2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[danglin at gcc dot gnu dot org]

------- Comment #3 from danglin at gcc dot gnu dot org  2008-07-20 21:26 -------
With revision 138012, I also hit this on hppa-unknown-linux-gnu:

(gdb) set args -I- -I. -Iada -I../../gcc/gcc/ada -quiet -nostdinc -dumpbase
s-os_lib.adb -O2 -g -gnatpg -gnata -gnatwns -gnatO ada/s-os_lib.o
../../gcc/gcc/ada/s-os_lib.adb -o xxx.s
(gdb) del 1 2
(gdb) r
Starting program: /home/dave/gnu/gcc/objdir/prev-gcc/gnat1 -I- -I. -Iada
-I../../gcc/gcc/ada -quiet -nostdinc -dumpbase s-os_lib.adb -O2 -g -gnatpg
-gnata -gnatwns -gnatO ada/s-os_lib.o ../../gcc/gcc/ada/s-os_lib.adb -o xxx.s

Program received signal SIGSEGV, Segmentation fault.
0x0161c02c in expressions_equal_p (e1=0x406d7a48, e2=0x0)
    at ../../gcc/gcc/tree-ssa-sccvn.c:2602
2602      te2 = TREE_TYPE (e2);
(gdb) bt
#0  0x0161c02c in expressions_equal_p (e1=0x406d7a48, e2=0x0)
    at ../../gcc/gcc/tree-ssa-sccvn.c:2602
#1  0x0160f75c in vn_reference_op_eq (p1=0x27a3890, p2=0x27a34a0)
    at ../../gcc/gcc/tree-ssa-sccvn.c:309
#2  0x0160fbbc in vn_reference_eq (p1=0x28391d0, p2=0xfafc1c50)
    at ../../gcc/gcc/tree-ssa-sccvn.c:391
#3  0x01f4845c in htab_find_slot_with_hash (htab=0x2837b40, 
    element=0xfafc1c50, hash=3457379796, insert=NO_INSERT)
    at ../../gcc/libiberty/hashtab.c:634
#4  0x01612168 in vn_reference_lookup_1 (vr=0xfafc1c50, vnresult=0x0)
    at ../../gcc/gcc/tree-ssa-sccvn.c:775
#5  0x01612324 in vn_reference_lookup (op=0x408fb0a8, vuses=0x40107a60, 
    maywalk=0 '\0', vnresult=0x0) at ../../gcc/gcc/tree-ssa-sccvn.c:832
#6  0x01614788 in visit_reference_op_store (lhs=0x408fb0a8, op=0x406d7ea8, 
    stmt=0x408fdb60) at ../../gcc/gcc/tree-ssa-sccvn.c:1513
#7  0x016181cc in visit_use (use=0x40b05850)
    at ../../gcc/gcc/tree-ssa-sccvn.c:1996
#8  0x01618fd0 in process_scc (scc=0x2837c50)
    at ../../gcc/gcc/tree-ssa-sccvn.c:2140
#9  0x0161a3cc in extract_and_process_scc_for_name (name=0x406d7a48)
    at ../../gcc/gcc/tree-ssa-sccvn.c:2192
#10 0x0161a790 in DFS (name=0x406d7a48) at ../../gcc/gcc/tree-ssa-sccvn.c:2245
#11 0x0161b9bc in run_scc_vn (may_insert_arg=1 '\001')
---Type <return> to continue, or q <return> to quit---
    at ../../gcc/gcc/tree-ssa-sccvn.c:2505
#12 0x015b5e2c in execute_pre (do_fre=1 '\001')
    at ../../gcc/gcc/tree-ssa-pre.c:4220
#13 0x015b61bc in execute_fre () at ../../gcc/gcc/tree-ssa-pre.c:4326
#14 0x00c6b8ec in execute_one_pass (pass=0x22d892c)
    at ../../gcc/gcc/passes.c:1295
#15 0x00c6bb64 in execute_pass_list (pass=0x22d892c)
    at ../../gcc/gcc/passes.c:1345
#16 0x00c6bb88 in execute_pass_list (pass=0x22d7ddc)
    at ../../gcc/gcc/passes.c:1346
#17 0x0117ffe4 in tree_rest_of_compilation (fndecl=0x400b4f50)
    at ../../gcc/gcc/tree-optimize.c:417
#18 0x01999148 in cgraph_expand_function (node=0x408b0400)
    at ../../gcc/gcc/cgraphunit.c:1158
#19 0x01999388 in cgraph_expand_all_functions ()
    at ../../gcc/gcc/cgraphunit.c:1221
#20 0x01999cbc in cgraph_optimize () at ../../gcc/gcc/cgraphunit.c:1438
#21 0x000ecce8 in gnat_write_global_declarations ()
    at ../../gcc/gcc/ada/utils.c:4202
#22 0x00f224d0 in compile_file () at ../../gcc/gcc/toplev.c:976
#23 0x00f25190 in do_compile () at ../../gcc/gcc/toplev.c:2163
#24 0x00f25244 in toplev_main (argc=19, argv=0xfafc101c)
    at ../../gcc/gcc/toplev.c:2195
---Type <return> to continue, or q <return> to quit---
#25 0x0060b384 in main (argc=19, argv=0xfafc101c) at ../../gcc/gcc/main.c:35


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[danglin at gcc dot gnu dot org]

------- Comment #4 from danglin at gcc dot gnu dot org  2008-07-20 21:29 -------
(gdb) p *vro1
$3 = {opcode = ARRAY_REF, type = 0x40022af8, op0 = 0x4068ae00, 
  op1 = 0x406d7a48, op2 = 0x0}
(gdb) p *vro2
$4 = {opcode = ARRAY_REF, type = 0x40022af8, op0 = 0x4068ae00, op1 = 0x0, 
  op2 = 0x0}


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[andreasmeier80 at gmx dot de]

------- Comment #5 from andreasmeier80 at gmx dot de  2008-07-21 12:55 -------
For me it is working today


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[r dot emrich at de dot tecosim dot com]

------- Comment #6 from r dot emrich at de dot tecosim dot com  2008-07-22 07:53 -------
(In reply to comment #5)
> For me it is working today
> 

I don't Know if it's related but today (rev. 138048) I get the following on
x86_64-unknown-linux-gnu:

/SCRATCH/tmp.haKcfD9964/Linux/x86_64-unknown-linux-gnu/openSUSE_10.3/gcc-4.4.0/gcc-4.4.0/./prev-gcc/xgcc
-B/SCRATCH/tmp.haKcfD9964/Linux/x86_64-unknown-linux-gnu/openSUSE_10.3/gcc-4.4.0/gcc-4.4.0/./prev-gcc/
-B/opt/gnu/gcc/Linux/x86_64-unknown-linux-gnu/openSUSE_10.3/gcc-4.4.0/x86_64-unknown-linux-gnu/bin/
-c -g -O2      -gnatpg -gnata -gnatwns -nostdinc -I- -I. -Iada
-I/opt/gnu/src/gcc/gcc-4.4.0/gcc/ada
/opt/gnu/src/gcc/gcc-4.4.0/gcc/ada/osint.adb -o ada/osint.o 

raised STORAGE_ERROR : stack overflow (or erroneous memory access)
gmake[3]: *** [ada/osint.o] Error 1 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[ebotcazou at gcc dot gnu dot org]

------- Comment #7 from ebotcazou at gcc dot gnu dot org  2008-07-23 09:35 -------
I'm seeing this as well since the PRE rewrite.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-07-23 09:35:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[ebotcazou at gcc dot gnu dot org]

------- Comment #8 from ebotcazou at gcc dot gnu dot org  2008-07-27 09:04 -------
With some 'make' kludgery, I get the same reproducible error on x86 as Dave.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|hppa2.0w-hp-hpux11.11       |
           Keywords|wrong-code                  |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[ebotcazou at gcc dot gnu dot org]

------- Comment #9 from ebotcazou at gcc dot gnu dot org  2008-07-27 09:16 -------
This points to an immediate problem in vn_reference_op_compute_hash:

/* Compute the hash for a reference operand VRO1.  */

static hashval_t
vn_reference_op_compute_hash (const vn_reference_op_t vro1)
{
  return iterative_hash_expr (vro1->op0, vro1->opcode)
    + iterative_hash_expr (vro1->op1, vro1->opcode);
}

op2 is not hashed (whereas it is on the 4.3 branch).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[dberlin at dberlin dot org]

------- Comment #10 from dberlin at gcc dot gnu dot org  2008-07-27 15:37 -------
Subject: Re:  [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

No, it doesn't.
Even if the op isn't hashed, it is still compared for in
vn_reference_op_eq, so at worst the non-hashing will make it compare
more vn_reference_op's than it has to, it shouldn't affect
correctness.

On Sun, Jul 27, 2008 at 5:16 AM, ebotcazou at gcc dot gnu dot org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
>
> ------- Comment #9 from ebotcazou at gcc dot gnu dot org  2008-07-27 09:16 -------
> This points to an immediate problem in vn_reference_op_compute_hash:
>
> /* Compute the hash for a reference operand VRO1.  */
>
> static hashval_t
> vn_reference_op_compute_hash (const vn_reference_op_t vro1)
> {
>  return iterative_hash_expr (vro1->op0, vro1->opcode)
>    + iterative_hash_expr (vro1->op1, vro1->opcode);
> }
>
> op2 is not hashed (whereas it is on the 4.3 branch).
>
>
> --
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830
>
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.
>


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[ebotcazou at gcc dot gnu dot org]

------- Comment #11 from ebotcazou at gcc dot gnu dot org  2008-07-27 15:58 -------
> Even if the op isn't hashed, it is still compared for in
> vn_reference_op_eq, so at worst the non-hashing will make it compare
> more vn_reference_op's than it has to, it shouldn't affect
> correctness.

You're right, fixing this oversight was not sufficient, there was another.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |ebotcazou at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-07-23 09:35:26         |2008-07-27 15:58:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[ebotcazou at gcc dot gnu dot org]

------- Comment #12 from ebotcazou at gcc dot gnu dot org  2008-07-27 16:56 -------
Subject: Bug 36830

Author: ebotcazou
Date: Sun Jul 27 16:55:31 2008
New Revision: 138191

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=138191
Log:
        PR tree-optimization/36830
        * tree-ssa-sccvn.c (vn_reference_op_compute_hash): Hash operand #2.
        (expressions_equal_p): Return false if only one operand is null.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-ssa-sccvn.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[ebotcazou at gcc dot gnu dot org]

------- Comment #13 from ebotcazou at gcc dot gnu dot org  2008-07-27 16:58 -------
Subject: Bug 36830

Author: ebotcazou
Date: Sun Jul 27 16:57:34 2008
New Revision: 138192

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=138192
Log:
        PR tree-optimization/36830
        * tree-vn.c (expressions_equal_p): Return false if only one operand
        is null.

Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/tree-vn.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830

[Bug tree-optimization/36830] [4.4 Regression] STORAGE_ERROR raised compiling s-os_lib.adb

[ebotcazou at gcc dot gnu dot org]

------- Comment #14 from ebotcazou at gcc dot gnu dot org  2008-07-27 17:04 -------
Presumably.


-- 

ebotcazou at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36830