[Bug tree-optimization/36945] New: [4.4 Regression] PRE/SCCVN do not handle aggregate function arguments correctly

[Bug tree-optimization/36945] New: [4.4 Regression] PRE/SCCVN do not handle aggregate function arguments correctly

[rguenth at gcc dot gnu dot org]

struct Bar { int a; int b; };
struct Foo { int x; struct Bar y; };

int __attribute__((const)) foo (struct Bar);

int bar (int b)
{
  struct Foo f;
  int c;
  while (b--)
    {
      c = foo(f.y);
    }
  return c;
}

./cc1 -quiet -O2 t.i -fdump-tree-all-details
t.i: In function 'bar':
t.i:7: internal compiler error: vector VEC(vn_reference_op_s,base) index domain
error, in create_component_ref_by_pieces at tree-ssa-pre.c:2413
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 
           Summary: [4.4 Regression] PRE/SCCVN do not handle aggregate
                    function arguments correctly
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: rguenth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36945

[Bug tree-optimization/36945] [4.4 Regression] PRE/SCCVN do not handle aggregate function arguments correctly

[rguenth at gcc dot gnu dot org]

------- Comment #1 from rguenth at gcc dot gnu dot org  2008-07-26 18:17 -------
I'll deal with it.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-07-26 18:17:11
               date|                            |
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36945

[Bug tree-optimization/36945] [4.4 Regression] PRE/SCCVN do not handle aggregate function arguments correctly

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2008-07-26 19:33 -------
The simplest solution is to punt value-numbering calls with arguments that
do not fit in one vn_reference_op.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36945

[Bug tree-optimization/36945] [4.4 Regression] PRE/SCCVN do not handle aggregate function arguments correctly

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2008-07-29 13:57 -------
I have a patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36945

[Bug tree-optimization/36945] [4.4 Regression] PRE/SCCVN do not handle aggregate function arguments correctly

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2008-07-29 17:10 -------
Subject: Bug 36945

Author: rguenth
Date: Tue Jul 29 17:09:26 2008
New Revision: 138257

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=138257
Log:
2008-07-29  Richard Guenther  <rguenther@suse.de>

        PR tree-optimization/36945
        * tree-ssa-sccvn.h (copy_reference_ops_from_ref): Declare.
        * tree-ssa-sccvn.c (copy_reference_ops_from_ref): Export.
        Record invariant addresses un-decomposed.
        (copy_reference_ops_from_call): Record reference call
        arguments properly.  Simplify.
        * tree-ssa-pre.c (create_component_ref_by_pieces_1): New
        helper split out from ...
        (create_component_ref_by_pieces): ... here.  Simplify.
        Prepare for recursive invocation for call arguments.
        (create_expression_by_pieces): Adjust call to
        create_component_ref_by_pieces.
        (compute_avail): Process operand 2 of reference ops.

        * gcc.dg/tree-ssa/ssa-pre-18.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-pre-18.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-pre.c
    trunk/gcc/tree-ssa-sccvn.c
    trunk/gcc/tree-ssa-sccvn.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36945

[Bug tree-optimization/36945] [4.4 Regression] PRE/SCCVN do not handle aggregate function arguments correctly

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2008-07-29 17:09 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36945