public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "manu at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/33720] A negative value in OpenMP clause num_threads is not detected at runtime
Date: Thu, 07 Aug 2008 02:56:00 -0000	[thread overview]
Message-ID: <20080807025511.25658.qmail@sourceware.org> (raw)
In-Reply-To: <bug-33720-13968@http.gcc.gnu.org/bugzilla/>



------- Comment #3 from manu at gcc dot gnu dot org  2008-08-07 02:55 -------
(In reply to comment #2)
> I'm not sure we should do anything about this.
> We have a warning if the compiler can detect non-positive value at compile
> time,
> but we certainly can't ever issue any diagnostic at runtime for num_threads
> 0 (because the implementation uses that value to mean no num_threads clause was
> present) and I'm not convinced the runtime library needs to be verbose to
> stderr.  So e.g. silently assuming just one thread is IMHO better than doing
> gomp_fatal in there.  You shouldn't expect any particular behavior from program
> which triggers undefined behavior.

But in this case the value is negative, not zero, and it seems that gomp_fatal
is already being called:

libgomp: Out of memory allocating 34359738400 bytes

It will be better to print the cause of that "out of memory" error, that is,
that the number of threads was negative.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org,
                   |                            |jakub at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33720


  parent reply	other threads:[~2008-08-07  2:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09 20:49 [Bug c/33720] New: A negative value in OpenMP clause num_threasds " geir at cray dot com
2007-10-09 23:28 ` [Bug libgomp/33720] " bkoz at gcc dot gnu dot org
2007-11-12 19:37 ` [Bug libgomp/33720] A negative value in OpenMP clause num_threads " jakub at gcc dot gnu dot org
2008-08-07  2:56 ` manu at gcc dot gnu dot org [this message]
2009-07-31 15:12 ` manu at gcc dot gnu dot org
2009-09-14 20:00 ` geir at cray dot com
     [not found] <bug-33720-4@http.gcc.gnu.org/bugzilla/>
2013-06-19 18:19 ` geir at cray dot com
2013-06-19 18:23 ` jakub at gcc dot gnu.org
2013-06-19 20:45 ` manu at gcc dot gnu.org
2021-12-29  7:54 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080807025511.25658.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).