[Bug ada/37005] New: GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[Bug ada/37005] New: GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[joel at gcc dot gnu dot org]

Did not occur with SVN trunk revision 138315 as reported here
http://gcc.gnu.org/ml/gcc-testresults/2008-07/msg02920.html


+===========================GNAT BUG DETECTED==============================+
| 4.4.0 20080801 (experimental) [trunk revision 138517]
(sparc-unknown-rtems4.9) GCC error:|
| in set_value_range, at tree-vrp.c:392                                    |
| Error detected around cd2a24e.adb:37                                     |
| Please submit a bug report; see http://gcc.gnu.org/bugs.html.            |
| Use a subject line meaningful to you and us to track the bug.            |
| Include the entire contents of this bug box in the report.               |
| Include the exact gcc or gnatmake command that you entered.              |
| Also include sources listed below in gnatchop format                     |
| (concatenated together with no headers between files).                   |
+==========================================================================+
Please include these source files with error report
Note that list may not be accurate in some cases,
so please double check that the problem can still
be reproduced with the set of files listed.

cd2a24e.adb
/home/joel/work-gnat/svn/gcc/gcc/testsuite/ada/acats/work-sis/support/report.ads


raised TYPES.UNRECOVERABLE_ERROR : comperr.adb:424
End of compilation


-- 
           Summary: GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: joel at gcc dot gnu dot org
GCC target triplet: sparc-rtems4.9


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005

[Bug ada/37005] GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[joel at gcc dot gnu dot org]

------- Comment #1 from joel at gcc dot gnu dot org  2008-08-08 16:03 -------
Also occurs on powerpc-rtems4.9 - 

4.4.0 20080807 (experimental) [trunk revision 138841]


-- 

joel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 GCC target triplet|sparc-rtems4.9              |sparc-rtems4.9 powerpc-
                   |                            |rtems4.9
            Summary|GNAT Bug Box for            |GNAT Bug Box for
                   |cd2a24e.adb:37 at tree-     |cd2a24e.adb:37 at tree-
                   |vrp.c:392                   |vrp.c:392


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005

[Bug tree-optimization/37005] [4.4 Regression] GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005

[Bug tree-optimization/37005] [4.4 Regression] GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2008-08-22 15:07 -------
Seems to be target independent, I also see this on x86_64.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
 GCC target triplet|sparc-rtems4.9 powerpc-     |
                   |rtems4.9                    |
           Priority|P3                          |P2
   Last reconfirmed|0000-00-00 00:00:00         |2008-08-22 15:07:20
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005

[Bug tree-optimization/37005] [4.4 Regression] GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[rguenth at gcc dot gnu dot org]

------- Comment #3 from rguenth at gcc dot gnu dot org  2008-08-22 20:52 -------
I have a patch.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-08-22 15:07:20         |2008-08-22 20:52:58
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005

[Bug tree-optimization/37005] [4.4 Regression] GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2008-08-27 15:27 -------
The FE generates

        if ((SAVE_EXPR <cd2a24e__ident ((integer) c1)> < c1 || SAVE_EXPR
<cd2a24e__ident ((integer) c1)> > c2) || cd2a24e__ident (4) <= 3 && c2 > 2)
          {

where c2 is of type cd2a24e__check_type (an enum with the range [3, 5]).
As you can see the comparison is against a value of different type (actually
it's of the same type, but it is out-of-range).

VRP generates a fallback range using TYPE_MIN_VALUE producing [3, 2] which
leads to the ICE.

This out-of-range comparison is generated by fold from 3 <= c2 during
canonicalization.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005

[Bug tree-optimization/37005] [4.4 Regression] GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[rguenth at gcc dot gnu dot org]

------- Comment #5 from rguenth at gcc dot gnu dot org  2008-08-28 08:31 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005

[Bug tree-optimization/37005] [4.4 Regression] GNAT Bug Box for cd2a24e.adb:37 at tree-vrp.c:392

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2008-08-28 08:33 -------
Subject: Bug 37005

Author: rguenth
Date: Thu Aug 28 08:31:37 2008
New Revision: 139702

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139702
Log:
2008-08-28  Richard Guenther  <rguenther@suse.de>

        PR middle-end/37005
        * fold-const.c (maybe_canonicalize_comparison_1): Require
        undefined overflow only for canonicalizing A +- CST cmp CST.
        Make sure to not generate new constants that are not inside
        their TYPE_MIN/MAX_VALUE range.
        (maybe_canonicalize_comparison): Remove undefined overflow
        checking from here.
        (fold_binary): Remove now duplicate folding.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fold-const.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37005