[Bug bootstrap/33304] New: Bootstrap failure on solaris2 using cc due to empty macro arguments

[Bug bootstrap/33304] New: Bootstrap failure on solaris2 using cc due to empty macro arguments

[ghazi at gcc dot gnu dot org]

I'm getting bootstrap failure with mainline on sparc-sun-solaris2.10 using cc
for stage1.  The failure occurs due to empty macro arguments.  They occur in
two places, one of which I've posted a patch for:
http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01131.html

The second occurance is in c-common.c on line 2249 where it says:
  C_COMMON_FIXED_TYPES (, fract);
Other instances occur below that in the same file.

In another thread, I fixed an empty macro argument problem encountered when
using gcc-2.8.1 for stage1 here:
http://gcc.gnu.org/ml/gcc-patches/2007-08/msg01119.html

According to Joseph later in that thread, empty macro arguments are undefined
in ISO C90.  Since we claim to only require ISO C90 to bootstrap, and because
we want to ensure older versions of GCC continue to be usable to bootstrap,
IMHO we should not allow empty macro arguments in the sources.


-- 
           Summary: Bootstrap failure on solaris2 using cc due to empty
                    macro arguments
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: ghazi at gcc dot gnu dot org
  GCC host triplet: sparc-sun-solaris2.10


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33304

[Bug bootstrap/33304] Bootstrap failure on solaris2 using cc due to empty macro arguments

[ghazi at gcc dot gnu dot org]

------- Comment #1 from ghazi at gcc dot gnu dot org  2008-06-23 17:50 -------
Patches to fix these problems in c-common.c/tree.c were posted here:

http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00687.html
http://gcc.gnu.org/ml/gcc-patches/2008-06/msg00858.html


-- 

ghazi at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-06-23 17:50:52
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33304

[Bug bootstrap/33304] Bootstrap failure on solaris2 using cc due to empty macro arguments

[aph at gcc dot gnu dot org]

------- Comment #2 from aph at gcc dot gnu dot org  2008-07-03 10:31 -------
Subject: Bug 33304

Author: aph
Date: Thu Jul  3 10:31:03 2008
New Revision: 137413

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=137413
Log:
2008-07-03  Andrew Haley  <aph@redhat.com>

        PR bootstrap/33304
        * vec.h (VEC_TA): New.
        (DEF_VEC_I, DEF_VEC_P, DEF_VEC_ALLOC_I, DEF_VEC_ALLOC_P,
        DEF_VEC_O, DEF_VEC_ALLOC_O: Use VEC_TA.
        * c-common.c (C_COMMON_FIXED_TYPES_SAT): New macro.
        (C_COMMON_FIXED_MODE_TYPES_SAT): New macro.
        (C_COMMON_FIXED_TYPES): Remove first arg.
        (C_COMMON_FIXED_MODE_TYPES): Likewise.
        * tree.c (MAKE_FIXED_TYPE_NODE): Break into two macros,
        MAKE_FIXED_TYPE_NODE and MAKE_FIXED_TYPE_NODE_WIDTH in order
        not to use empty macro arguments.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-common.c
    trunk/gcc/tree.c
    trunk/gcc/vec.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33304

[Bug bootstrap/33304] Bootstrap failure on solaris2 using cc due to empty macro arguments

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2008-08-16 22:47 -------
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33304

[Bug bootstrap/33304] Bootstrap failure on solaris2 using cc due to empty macro arguments

[aph at gcc dot gnu dot org]

------- Comment #4 from aph at gcc dot gnu dot org  2008-11-10 12:10 -------
Subject: Bug 33304

Author: aph
Date: Mon Nov 10 12:08:55 2008
New Revision: 141735

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141735
Log:
2008-11-10  Andrew Haley  <aph@redhat.com>

        Backport from mainline:

        PR bootstrap/33304
        * vec.h (VEC_TA): New.
        (DEF_VEC_I, DEF_VEC_P, DEF_VEC_ALLOC_I, DEF_VEC_ALLOC_P,
        DEF_VEC_O, DEF_VEC_ALLOC_O: Use VEC_TA.
        * c-common.c (C_COMMON_FIXED_TYPES_SAT): New macro.
        (C_COMMON_FIXED_MODE_TYPES_SAT): New macro.
        (C_COMMON_FIXED_TYPES): Remove first arg.
        (C_COMMON_FIXED_MODE_TYPES): Likewise.
        * tree.c (MAKE_FIXED_TYPE_NODE): Break into two macros,
        MAKE_FIXED_TYPE_NODE and MAKE_FIXED_TYPE_NODE_WIDTH in order
        not to use empty macro arguments.


Modified:
    branches/gcc-4_3-branch/gcc/ChangeLog
    branches/gcc-4_3-branch/gcc/c-common.c
    branches/gcc-4_3-branch/gcc/tree.c
    branches/gcc-4_3-branch/gcc/vec.h


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33304