public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/37150] vectorizer issue
Date: Mon, 18 Aug 2008 15:56:00 -0000	[thread overview]
Message-ID: <20080818155511.21327.qmail@sourceware.org> (raw)
In-Reply-To: <bug-37150-6642@http.gcc.gnu.org/bugzilla/>



------- Comment #2 from rguenth at gcc dot gnu dot org  2008-08-18 15:55 -------
Note that there is no loop left on the trunk for the testcase, but after
the vectorizer it is all unrolled completely (unvectorized, of course).
Again this looks like missing vectorization of scalar code.

Note that the first complete unrolling pass unrolls loops that result in
smaller code.  This interferes with vectorization in your case, so can
you try

Index: tree-ssa-loop-ivcanon.c
===================================================================
*** tree-ssa-loop-ivcanon.c     (revision 139200)
--- tree-ssa-loop-ivcanon.c     (working copy)
*************** tree_unroll_loops_completely (bool may_i
*** 359,374 ****

        FOR_EACH_LOOP (li, loop, LI_ONLY_INNERMOST)
        {
!         if (may_increase_size && maybe_hot_bb_p (loop->header)
!             /* Unroll outermost loops only if asked to do so or they do
!                not cause code growth.  */
!             && (unroll_outer
!                 || loop_outer (loop_outer (loop))))
            ul = UL_ALL;
          else
            ul = UL_NO_GROWTH;
!         changed |= canonicalize_loop_induction_variables
!                      (loop, false, ul, !flag_tree_loop_ivcanon);
        }

        if (changed)
--- 359,378 ----

        FOR_EACH_LOOP (li, loop, LI_ONLY_INNERMOST)
        {
!         /* Unroll outermost loops only if asked to do so.  */
!         if (!unroll_outer
!             && !loop_outer (loop_outer (loop)))
!           ul = UL_SINGLE_ITER;
!         else if (may_increase_size && maybe_hot_bb_p (loop->header))
            ul = UL_ALL;
          else
            ul = UL_NO_GROWTH;
!         if (canonicalize_loop_induction_variables
!               (loop, false, ul, !flag_tree_loop_ivcanon))
!           {
!             statistics_counter_event (cfun, "Loops completely unrolled", 1);
!             changed = true;
!           }
        }

        if (changed)


?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37150


  parent reply	other threads:[~2008-08-18 15:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18 15:34 [Bug middle-end/37150] New: " jv244 at cam dot ac dot uk
2008-08-18 15:35 ` [Bug middle-end/37150] " jv244 at cam dot ac dot uk
2008-08-18 15:56 ` rguenth at gcc dot gnu dot org [this message]
2008-08-18 16:10 ` burnus at gcc dot gnu dot org
2008-08-19 10:55 ` jv244 at cam dot ac dot uk
2008-08-19 11:37 ` jv244 at cam dot ac dot uk
2008-08-19 13:51 ` jv244 at cam dot ac dot uk
2008-08-24 22:50 ` [Bug middle-end/37150] vectorizer misses some loops pinskia at gcc dot gnu dot org
2008-12-27  6:33 ` pinskia at gcc dot gnu dot org
2009-08-06  7:55 ` jv244 at cam dot ac dot uk
2009-08-06  9:40 ` rguenth at gcc dot gnu dot org
2009-08-06 10:24 ` jv244 at cam dot ac dot uk
2009-08-06 10:49 ` irar at il dot ibm dot com
2009-08-06 11:11 ` jv244 at cam dot ac dot uk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080818155511.21327.qmail@sourceware.org \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).