From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12522 invoked by alias); 26 Aug 2008 02:01:50 -0000 Received: (qmail 11055 invoked by uid 48); 26 Aug 2008 02:00:27 -0000 Date: Tue, 26 Aug 2008 02:01:00 -0000 Message-ID: <20080826020027.11046.qmail@sourceware.org> X-Bugzilla-Reason: CC References: Subject: [Bug middle-end/37170] [4.4 Regression]: gcc.dg/weak/weak-1.c In-Reply-To: Reply-To: gcc-bugzilla@gcc.gnu.org To: gcc-bugs@gcc.gnu.org From: "hp at gcc dot gnu dot org" Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2008-08/txt/msg01958.txt.bz2 ------- Comment #54 from hp at gcc dot gnu dot org 2008-08-26 02:00 ------- Created an attachment (id=16146) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16146&action=view) Patch, take 5. Removing the "TREE_CODE (decl) == FUNCTION_DECL && ..." part helped to elide the bogus weak declarations for vtables that had been taken care of locally. Doh. :) On Darwin, there were also some spurious .weak_reference X emitted for locally-defined X. Fixed by gating that output as in assemble_external. Trivially tested with the test-cases that have appeared here. Test runs started for native x86_64-linux and cross to cris-elf. I'd be thankful for your testing. -- hp at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16141|0 |1 is obsolete| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37170