[Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug c/31673]  New: "`for' loop initial declaration used outside C99 mode" is confusing
@ 2007-04-23 20:33 j at uriah dot heep dot sax dot de
  2007-04-23 20:34 ` [Bug c/31673] " j at uriah dot heep dot sax dot de
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: j at uriah dot heep dot sax dot de @ 2007-04-23 20:33 UTC (permalink / raw)
  To: gcc-bugs

The error message

`for' loop initial declaration used outside C99 mode

is just confusing to the average user.  The default -std level is "gnu89"
which forbids for loop initial declarations, but as the user might not
have even heard about C99 let alone mentioned that somewhere on purpose,
this message causes an unusual high amount of support traffic.

I suggest replacing it by

`foo' loop initial declarations are only allowed in C99 mode


-- 
           Summary: "`for' loop initial declaration used outside C99 mode"
                    is confusing
           Product: gcc
           Version: 4.3.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: j at uriah dot heep dot sax dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
@ 2007-04-23 20:34 ` j at uriah dot heep dot sax dot de
  2007-04-23 20:40 ` pinskia at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: j at uriah dot heep dot sax dot de @ 2007-04-23 20:34 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from j at uriah dot heep dot sax dot de  2007-04-23 21:34 -------
Created an attachment (id=13431)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13431&action=view)
Suggested patch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
  2007-04-23 20:34 ` [Bug c/31673] " j at uriah dot heep dot sax dot de
@ 2007-04-23 20:40 ` pinskia at gcc dot gnu dot org
  2007-04-23 20:49 ` j at uriah dot heep dot sax dot de
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-04-23 20:40 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from pinskia at gcc dot gnu dot org  2007-04-23 21:39 -------
> this message causes an unusual high amount of support traffic.

Does it?  This is the first time I have seen a request for a change.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
  2007-04-23 20:34 ` [Bug c/31673] " j at uriah dot heep dot sax dot de
  2007-04-23 20:40 ` pinskia at gcc dot gnu dot org
@ 2007-04-23 20:49 ` j at uriah dot heep dot sax dot de
  2007-04-23 20:57 ` pinskia at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: j at uriah dot heep dot sax dot de @ 2007-04-23 20:49 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from j at uriah dot heep dot sax dot de  2007-04-23 21:49 -------
(In reply to comment #2)

> > this message causes an unusual high amount of support traffic.
> 
> Does it?  This is the first time I have seen a request for a change.

When I first saw it, it took quite a while until I realized what it's
going to tell me.

See here for the example that triggered this enhancement request:

http://www.avrfreaks.net/index.php?name=PNphpBB2&file=viewtopic&t=49112#311973

(Just reading that single article is enough, alas the rest of that
thread is getting *way* off.)

I'm sure though I've been explaining that a number of times before.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
                   ` (2 preceding siblings ...)
  2007-04-23 20:49 ` j at uriah dot heep dot sax dot de
@ 2007-04-23 20:57 ` pinskia at gcc dot gnu dot org
  2007-04-23 21:05 ` j at uriah dot heep dot sax dot de
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2007-04-23 20:57 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from pinskia at gcc dot gnu dot org  2007-04-23 21:57 -------
> (Just reading that single article is enough, alas the rest of that
> thread is getting *way* off.)

Sounds like this is a case of not reading the documentation again.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
                   ` (3 preceding siblings ...)
  2007-04-23 20:57 ` pinskia at gcc dot gnu dot org
@ 2007-04-23 21:05 ` j at uriah dot heep dot sax dot de
  2007-05-23 16:36 ` manu at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: j at uriah dot heep dot sax dot de @ 2007-04-23 21:05 UTC (permalink / raw)
  To: gcc-bugs

------- Comment #5 from j at uriah dot heep dot sax dot de  2007-04-23 22:05 -------
(In reply to comment #4)

> Sounds like this is a case of not reading the documentation again.

Well, unlike many others, he even *knew* something about C99, yet he
did not grok the error message's content.  And he's even an English
native speaker, so what do you guess might a non-native speaker run
into when trying to parse that sentence?  And no, don't expect the
translations to become better than the original. ;-)

Negated hints (``outside C99 mode'') are almost never easy to
understand.

-- 

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
                   ` (4 preceding siblings ...)
  2007-04-23 21:05 ` j at uriah dot heep dot sax dot de
@ 2007-05-23 16:36 ` manu at gcc dot gnu dot org
  2008-08-27 23:57 ` manu at gcc dot gnu dot org
  2008-08-27 23:57 ` manu at gcc dot gnu dot org
  7 siblings, 0 replies; 9+ messages in thread
From: manu at gcc dot gnu dot org @ 2007-05-23 16:36 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from manu at gcc dot gnu dot org  2007-05-23 17:36 -------
(In reply to comment #1)
> Created an attachment (id=13431)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13431&action=view) [edit]
> Suggested patch.
> 

Joerg, please test the patch and modify any failing testcases, then submit the
patch to gcc-patches. I think your version is clearer. Perhaps "`for' loop
initial declarations only allowed in C99 mode" is shorter and equally clear.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
                   ` (5 preceding siblings ...)
  2007-05-23 16:36 ` manu at gcc dot gnu dot org
@ 2008-08-27 23:57 ` manu at gcc dot gnu dot org
  2008-08-27 23:57 ` manu at gcc dot gnu dot org
  7 siblings, 0 replies; 9+ messages in thread
From: manu at gcc dot gnu dot org @ 2008-08-27 23:57 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from manu at gcc dot gnu dot org  2008-08-27 23:56 -------
Fixed for GCC 4.4


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug c/31673] "`for' loop initial declaration used outside C99 mode" is confusing
  2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
                   ` (6 preceding siblings ...)
  2008-08-27 23:57 ` manu at gcc dot gnu dot org
@ 2008-08-27 23:57 ` manu at gcc dot gnu dot org
  7 siblings, 0 replies; 9+ messages in thread
From: manu at gcc dot gnu dot org @ 2008-08-27 23:57 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from manu at gcc dot gnu dot org  2008-08-27 23:55 -------
Subject: Bug 31673

Author: manu
Date: Wed Aug 27 23:54:36 2008
New Revision: 139681

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139681
Log:
2008-08-27  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>

        PR c/31673
        * c-decl.c (check_for_loop_decls): Improve error message. Give
        hint.
testsuite/
        * gcc.dg/c90-fordecl-1.c: Update.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-decl.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/c90-fordecl-1.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31673


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2008-08-27 23:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-23 20:33 [Bug c/31673] New: "`for' loop initial declaration used outside C99 mode" is confusing j at uriah dot heep dot sax dot de
2007-04-23 20:34 ` [Bug c/31673] " j at uriah dot heep dot sax dot de
2007-04-23 20:40 ` pinskia at gcc dot gnu dot org
2007-04-23 20:49 ` j at uriah dot heep dot sax dot de
2007-04-23 20:57 ` pinskia at gcc dot gnu dot org
2007-04-23 21:05 ` j at uriah dot heep dot sax dot de
2007-05-23 16:36 ` manu at gcc dot gnu dot org
2008-08-27 23:57 ` manu at gcc dot gnu dot org
2008-08-27 23:57 ` manu at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).