public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "irar at il dot ibm dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/36630] [4.3/4.4 Regression] ICE in vect_update_ivs_after_vectorizer Date: Wed, 03 Sep 2008 10:44:00 -0000 [thread overview] Message-ID: <20080903104321.17746.qmail@sourceware.org> (raw) In-Reply-To: <bug-36630-87@http.gcc.gnu.org/bugzilla/> ------- Comment #8 from irar at il dot ibm dot com 2008-09-03 10:43 ------- (In reply to comment #7) > I still think that handling NULL from evolution_part_in_loop_num is the > correct thing to do. Even if you need to move this check to the analysis > phase. > > The interesting thing is that the access function during > vect_analyze_scalar_cycles_1 is > > {2, +, 1}_1 > > which is because after the vectorized part of the loop the prologue > remains which has a non-constant evolution start. I tried to do the check during the analysis, but it seems impossible, since, as you wrote, this access function does not exist during the analysis. > > So with the reasoning that you analyzed the access function of the > original loop properly you can probably strip the conversion that > confuses you at just vect_update_ivs_after_vectorizer. I tested this on the vectorizer tests: Index: tree-vect-transform.c =================================================================== --- tree-vect-transform.c (revision 139930) +++ tree-vect-transform.c (working copy) @@ -6529,6 +6529,7 @@ vect_update_ivs_after_vectorizer (loop_v access_fn = analyze_scalar_evolution (loop, PHI_RESULT (phi)); gcc_assert (access_fn); + STRIP_NOPS (access_fn); evolution_part = unshare_expr (evolution_part_in_loop_num (access_fn, loop->num)); gcc_assert (evolution_part != NULL_TREE); > (Or store > the relevant information during analysis where the evolution is > still simple enough) > > This would fix the ICE, but I wonder if it may cause wrong code because > of mismatched types somehow. At least, this does not happen with the vectorizer testsuite. Another thing, 4.4 does not vectorize this loop anymore (and, therefore, there is no ICE), because of unknown number of iterations: (analyze_scalar_evolution (loop_nb = 1) (scalar = i_18) (get_scalar_evolution (scalar = i_18) (scalar_evolution = i_18)) (set_scalar_evolution (scalar = i_18) (scalar_evolution = i_18)) ) (set_nb_iterations_in_loop = scev_not_known)) (get_loop_exit_condition if (y_3(D) > i_13) ) -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36630
next prev parent reply other threads:[~2008-09-03 10:44 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-06-25 12:48 [Bug tree-optimization/36630] New: " jakub at gcc dot gnu dot org 2008-06-25 12:48 ` [Bug tree-optimization/36630] " jakub at gcc dot gnu dot org 2008-06-25 14:28 ` rguenth at gcc dot gnu dot org 2008-06-26 11:58 ` irar at il dot ibm dot com 2008-06-26 12:12 ` rguenther at suse dot de 2008-06-26 18:34 ` irar at il dot ibm dot com 2008-07-10 14:19 ` rguenth at gcc dot gnu dot org 2008-07-16 6:20 ` irar at il dot ibm dot com 2008-07-18 16:53 ` rguenth at gcc dot gnu dot org 2008-08-27 22:13 ` jsm28 at gcc dot gnu dot org 2008-08-28 15:11 ` rguenth at gcc dot gnu dot org 2008-09-03 10:44 ` irar at il dot ibm dot com [this message] 2008-09-03 21:04 ` spop at gcc dot gnu dot org 2008-09-07 7:16 ` irar at gcc dot gnu dot org 2008-09-07 10:08 ` irar at gcc dot gnu dot org 2008-09-07 11:06 ` irar at il dot ibm dot com 2008-09-08 7:46 ` irar at il dot ibm dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080903104321.17746.qmail@sourceware.org \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).