[Bug middle-end/37380] New: ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[Bug middle-end/37380] New: ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[danglin at gcc dot gnu dot org]

In stage2,

/home/dave/gnu/gcc-4.4/objdir/./prev-gcc/xgcc
-B/home/dave/gnu/gcc-4.4/objdir/./prev-gcc/
-B/home/dave/opt/gnu/gcc/gcc-4.4.0/hppa-linux/bin/  -I../../gcc/libcpp -I.
-I../../gcc/libcpp/../include -I../../gcc/libcpp/include  -g -O2 -W -Wall
-Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition
-Wmissing-format-attribute -pedantic -Wno-long-long -Werror -I../../gcc/libcpp
-I. -I../../gcc/libcpp/../include -I../../gcc/libcpp/include  -c -o
directives.o -MT directives.o -MMD -MP -MF .deps/directives.Tpo
../../gcc/libcpp/directives.c
cc1: warnings being treated as errors
../../gcc/libcpp/charset.c: In function 'emit_numeric_escape':
../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in
this function
make[3]: *** [charset.o] Error 1

dave@hiauly6:~/gnu/gcc-4.4/objdir/prev-gcc$ ./xgcc -B./ -v
Reading specs from ./specs
Target: hppa-linux
Configured with: ../gcc/configure --with-gnu-as --with-gnu-ld --enable-shared
--prefix=/home/dave/opt/gnu/gcc/gcc-4.4.0
--with-local-prefix=/home/dave/opt/gnu --enable-threads=posix
--enable-__cxa_atexit --build=hppa-linux --enable-clocale=gnu
--enable-java-gc=boehm --enable-java-awt=xlib --enable-languages=c
Thread model: posix
gcc version 4.4.0 20080905 (experimental) [trunk revision 140022] (GCC)


-- 
           Summary: ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width'
                    is used uninitialized in this function
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
 GCC build triplet: hppa-unknown-linux-gnu
  GCC host triplet: hppa-unknown-linux-gnu
GCC target triplet: hppa-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[danglin at gcc dot gnu dot org]

------- Comment #1 from danglin at gcc dot gnu dot org  2008-09-05 02:20 -------
In charset.c.004t.gimple, I see

  cvt.77 = cvt;
  D.6101 = cvt.77.width;
  width = (size_t) D.6101;

So, I think stage must be miscompiled.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[danglin at gcc dot gnu dot org]

------- Comment #2 from danglin at gcc dot gnu dot org  2008-09-07 00:08 -------
This was introduced in revision 139930.


-- 

danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[danglin at gcc dot gnu dot org]

------- Comment #3 from danglin at gcc dot gnu dot org  2008-09-07 00:09 -------
Sorrry, that should have been revision 139931.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Keywords|                            |build
            Summary|../../gcc/libcpp/charset.c:1|[4.4 Regression]
                   |103: error: 'cvt.77.width'  |../../gcc/libcpp/charset.c:1
                   |is used uninitialized in    |103: error: 'cvt.77.width'
                   |this function               |is used uninitialized in
                   |                            |this function
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[andreast at gcc dot gnu dot org]

-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-09-07 21:11:45
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[rguenth at gcc dot gnu dot org]

------- Comment #4 from rguenth at gcc dot gnu dot org  2008-09-08 09:56 -------
I don't see how SRA can affect 004.gimple output, but the gimplification looks
wrong.  For 

  size_t width = cvt.width;

you should see

  D.6101 = cvt.width;
  width = (size_t) D.6101;


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[sje at cup dot hp dot com]

------- Comment #5 from sje at cup dot hp dot com  2008-09-08 21:47 -------
I wonder if the problem is the new call to force_gimple_operand.  We now have:

src = force_gimple_operand (src, ......)

and then later we use src in the call to gimple_build_assign.  I think the call
to force_gimple_operand is going to change src to something that
gimple_build_assign doesn't expect like GS_ALL_DONE.  Or is that actually OK?


-- 

sje at cup dot hp dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sje at cup dot hp dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[rguenth at gcc dot gnu dot org]

------- Comment #6 from rguenth at gcc dot gnu dot org  2008-09-09 07:31 -------
Can you attach preprocessed source so I can reproduce this with a cross?
Thanks.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[dave at hiauly1 dot hia dot nrc dot ca]

------- Comment #7 from dave at hiauly1 dot hia dot nrc dot ca  2008-09-09 16:30 -------
Subject: Re:  [4.4 Regression]
        ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used
        uninitialized in this function

> Can you attach preprocessed source so I can reproduce this with a cross?

Here it is.

Thanks,
Dave


------- Comment #8 from dave at hiauly1 dot hia dot nrc dot ca  2008-09-09 16:30 -------
Created an attachment (id=16267)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16267&action=view)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[rguenth at gcc dot gnu dot org]

------- Comment #9 from rguenth at gcc dot gnu dot org  2008-09-09 16:56 -------
The key to the problem seems to be a structure passed by value where the
target passes it as pointer and the struct is callee-copied.  This gimplifies
to the correct

  cvt.64 ={v} cvt;
  D.6054_4 = cvt.64.width;
  width_5 = (size_t) D.6054_4;

but somehow SRA completely messes up scalarizing the struct copy from the
parameter:

  cvt$width_59 = cvt.64.width;
  cvt$cd_60 = cvt.64.cd;
  cvt$func_61 = cvt.64.func;
  cvt.64$cd_62 = cvt$cd_60;
  cvt.64$func_63 = cvt$func_61;
  cvt.64$width_64 = cvt$width_59;
  D.6054_4 = cvt.64$width_64;
  width_5 = (size_t) D.6054_4;

where it removed the initialization of cvt.64.  Which seems because of

2311      src = force_gimple_operand (src, &seq2, false, NULL_TREE);
cvt$width
cvt.width
(gdb) n
2312      gimple_seq_add_seq (&seq, seq2);
(gdb) call debug_generic_expr (src)
cvt.64.width

so we force-gimple-operanded cvt.width to cvt.64.width (but seq2 is empty).


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rguenth at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-09-07 21:11:45         |2008-09-09 16:56:32
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[rguenth at gcc dot gnu dot org]

------- Comment #10 from rguenth at gcc dot gnu dot org  2008-09-09 17:18 -------
And the reason for that is that re-gimplifying cvt.width hits
gimplify_var_or_parm_decl which will substitute cvt with its
DECL_VALUE_EXPR which is cvt.64.  This is - unfortunate, because
we cannot easily fix that.

Looks like we have to add a new flag to gimplify_ctxp to avoid
this replacement for later gimplification of operands.  We can
of course also disable scalarizing of variables with DECL_VALUE_EXPR,
but that doesn't look right.

Diego, any preferences?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[sje at cup dot hp dot com]

------- Comment #11 from sje at cup dot hp dot com  2008-09-10 21:22 -------
Created an attachment (id=16288)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16288&action=view)
Smaller test case

Here is a smaller test case cut down from GCC sources.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[sje at cup dot hp dot com]

------- Comment #12 from sje at cup dot hp dot com  2008-09-15 18:55 -------
Anything new here?  It is causing a bootstrap failure on HPPA.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[rguenther at suse dot de]

------- Comment #13 from rguenther at suse dot de  2008-09-16 08:50 -------
Subject: Re:  [4.4 Regression] ../../gcc/libcpp/charset.c:1103:
 error: 'cvt.77.width' is used uninitialized in this function

On Mon, 15 Sep 2008, sje at cup dot hp dot com wrote:

> ------- Comment #12 from sje at cup dot hp dot com  2008-09-15 18:55 -------
> Anything new here?  It is causing a bootstrap failure on HPPA.

I will install a workaround not addressing the fundamental problem
with the gimplifier.

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[rguenth at gcc dot gnu dot org]

------- Comment #14 from rguenth at gcc dot gnu dot org  2008-09-16 12:35 -------
Subject: Bug 37380

Author: rguenth
Date: Tue Sep 16 12:34:01 2008
New Revision: 140388

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=140388
Log:
2008-09-16  Richard Guenther  <rguenther@suse.de>

        PR middle-end/37380
        * tree-sra.c (sra_build_assignment): Do not call the gimplifier
        if not necessary.

        * gcc.c-torture/compile/pr37380.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr37380.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-sra.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380

[Bug middle-end/37380] [4.4 Regression] ../../gcc/libcpp/charset.c:1103: error: 'cvt.77.width' is used uninitialized in this function

[rguenth at gcc dot gnu dot org]

------- Comment #15 from rguenth at gcc dot gnu dot org  2008-09-16 12:36 -------
Fixed.


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37380