[Bug rtl-optimization/14583] a switch statement can be converted to an array access

[Bug rtl-optimization/14583] a switch statement can be converted to an array access

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2008-09-08 19:51 -------
This was fixed by:
2008-07-01  Martin Jambor  <mjambor@suse.cz>

        * Makefile.in (tree-switch-conversion.o): Add.
        (OBJS-common): Add tree-swtch-conversion.o.
        * passes.c (init_optimization_passes): Add pass_convert_switch.
        * tree-pass.h: (pass_convert_switch): Add.
        * tree-switch-conversion.c: New file.
        * gcc.dg/tree-ssa/cswtch.c: New testcase.
        * common.opt (ftree-cswtch): New option.
        * params.h (PARAM_SWITCH_CONVERSION_BRANCH_RATIO): New parameter.
        * params.def (PARAM_SWITCH_CONVERSION_BRANCH_RATIO): New parameter.
        * opts.c (decode_options): Set flag_tree_switch_conversion when
        optimization level is >= 2.
        * doc/invoke.texi (Optimize Options): Added description of
        -ftree-swtch-conversion and switch-conversion-max-branch-ratio.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14583

[Bug rtl-optimization/14583] a switch statement can be converted to an array access

[steven at gcc dot gnu dot org]

------- Additional Comments From steven at gcc dot gnu dot org  2005-09-02 11:24 -------
Kazu, is this still not optimized properly? 
 

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14583

[Bug optimization/14583] New: a switch statement can be converted to an array access

[kazu at cs dot umass dot edu]

>From reverse_condition() from jump.c

enum rtx_code
reverse_condition (enum rtx_code code)
{
  switch (code)
    {
    case EQ:
      return NE;
    case NE:
      return EQ;
    case GT:
      return LE;

      :
      :
      :

    case LTGT:
      return UNKNOWN;

    default:
      abort ();
    }
}

All the cases except the last one returns a value, so the compiler
should be able to convert this switch statement to something like

  code -= LOWER_BOUND;
  if ((unsigned) code > UPPER_BOUND)
    abort ();
  tem = cases[code];
  if (tem == DEFAULT_CASE)
    abort ();
  return tem;

I think this is a win for both code size and speed on most, if not
all, platforms.

This kind of switch should be fairly common, and people may not like
to use an array themselves if the switch condition is an enum, just
like reverse_condition() in jump.c.

tree-ssa may be a good place to detect this.  I don't know if the
implementation should be done in tree-ssa or at expand time.  One
thing we can do is that just like CALL_EXPR_TAILCALL, we could flag
this kind of switch statement in tree-ssa and then emit an optimized
switch statement at the expand time.

-- 
           Summary: a switch statement can be converted to an array access
           Product: gcc
           Version: 3.5.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: kazu at cs dot umass dot edu
                CC: gcc-bugs at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14583

[Bug rtl-optimization/14583] a switch statement can be converted to an array access

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |16996
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14583