[Bug tree-optimization/37095] New: [4.4 regression] Trouble with covariant return

[Bug tree-optimization/37095] New: [4.4 regression] Trouble with covariant return

[reichelt at gcc dot gnu dot org]

The following valid code snippet fails to compile on mainline when compiled
with "-O":

=======================================
struct A
{
  virtual A* foo();
};

struct B : virtual A
{
  virtual B* foo() { return 0; }
};

B b;
=======================================

bug.cc:11: error: 'B* *.LTHUNK1()' aliased to undefined symbol
'_ZTch0_v0_n32_N1B3fooEv'


-- 
           Summary: [4.4 regression] Trouble with covariant return
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: reichelt at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095

[Bug tree-optimization/37095] [4.4 regression] Trouble with covariant return

[reichelt at gcc dot gnu dot org]

-- 

reichelt at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095

[Bug tree-optimization/37095] [4.4 regression] Trouble with covariant return

[rguenth at gcc dot gnu dot org]

------- Comment #2 from rguenth at gcc dot gnu dot org  2008-08-22 15:26 -------
This looks like a fallout from the unit-at-a-time changes.  The testcase
works for me with -O -fno-toplevel-reorder.

Honza, can you have a look here?


-- 

rguenth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Priority|P3                          |P1
   Last reconfirmed|0000-00-00 00:00:00         |2008-08-22 15:26:26
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095

[Bug tree-optimization/37095] [4.4 regression] Trouble with covariant return

[jakub at gcc dot gnu dot org]

------- Comment #3 from jakub at gcc dot gnu dot org  2008-09-01 13:50 -------
The problem is that cgraph_node_for_asm assumes that once it has been called
once, no new cgraph nodes will be created.  But that's not true, at least C++
lang_hooks.callgraph.emit_associated_thunks (decl) adds new cgraph nodes (for
the thunks).  So, either cgraph_create_node should keep populating
assembler_name_hash once that hash table is created, or there should be a
cgraph function which can be called for the late cgraph nodes to get registered
into
the assembler_name_hash.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095

[Bug tree-optimization/37095] [4.4 regression] Trouble with covariant return

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2008-09-01 19:03 -------
Created an attachment (id=16184)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16184&action=view)
gcc44-pr37095.patch

Patch I'm going to bootstrap now.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |jakub at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095

[Bug tree-optimization/37095] [4.4 regression] Trouble with covariant return

[jakub at gcc dot gnu dot org]

------- Comment #6 from jakub at gcc dot gnu dot org  2008-09-02 10:35 -------
Subject: Bug 37095

Author: jakub
Date: Tue Sep  2 10:33:46 2008
New Revision: 139887

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139887
Log:
        PR tree-optimization/37095
        * cgraph.c (cgraph_node): When creating new cgraph node after
        assembler_name_hash has been populated, record it in the hash
        table.

        * g++.dg/inherit/thunk9.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/inherit/thunk9.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraph.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095

[Bug tree-optimization/37095] [4.4 regression] Trouble with covariant return

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2008-09-02 10:34 -------
Fixed.


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095

[Bug tree-optimization/37095] [4.4 regression] Trouble with covariant return

[jakub at gcc dot gnu dot org]

------- Comment #7 from jakub at gcc dot gnu dot org  2008-09-10 08:32 -------
*** Bug 37167 has been marked as a duplicate of this bug. ***


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sje at cup dot hp dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37095