[Bug tree-optimization/37392] New: [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[Bug tree-optimization/37392] New: [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[tbm at cyrius dot com]

With current trunk (revision 140055):

(gdb) run -quiet -O3 ~/libimager-perl-fills.i
Starting program: /home/tbm/tmp/gcc/4.3-2008-09-06-r140055/gcc/cc1 -quiet -O3
~/libimager-perl-fills.i

Program received signal SIGSEGV, Segmentation fault.
verify_ssa (check_modified_stmt=1 '\001') at
/home/tbm/scratch/gcc/gcc/tree-ssa.c:751
751               if (!gimple_nop_p (stmt))
(gdb) where
#0  verify_ssa (check_modified_stmt=1 '\001') at
/home/tbm/scratch/gcc/gcc/tree-ssa.c:751
#1  0x0000000000640458 in execute_function_todo (data=<value optimized out>) at
/home/tbm/scratch/gcc/gcc/passes.c:998
#2  0x000000000064071f in execute_todo (flags=0) at
/home/tbm/scratch/gcc/gcc/passes.c:1024
#3  0x00000000006409bf in execute_one_pass (pass=0x101be60) at
/home/tbm/scratch/gcc/gcc/passes.c:1262
#4  0x0000000000640c35 in execute_pass_list (pass=0x101be60) at
/home/tbm/scratch/gcc/gcc/passes.c:1326
#5  0x00000000007374dc in tree_rest_of_compilation (fndecl=0x7f9b94701600) at
/home/tbm/scratch/gcc/gcc/tree-optimize.c:418
#6  0x00000000008b08e0 in cgraph_expand_function (node=0x7f9b94535200) at
/home/tbm/scratch/gcc/gcc/cgraphunit.c:1038
#7  0x00000000008b2654 in cgraph_optimize () at
/home/tbm/scratch/gcc/gcc/cgraphunit.c:1097
#8  0x00000000004169c3 in c_write_global_declarations () at
/home/tbm/scratch/gcc/gcc/c-decl.c:8080
#9  0x00000000006e873f in toplev_main (argc=<value optimized out>, argv=<value
optimized out>)
    at /home/tbm/scratch/gcc/gcc/toplev.c:979
#10 0x00007f9b949441a6 in __libc_start_main () from /lib/libc.so.6
#11 0x00000000004044d9 in _start ()
(gdb)


-- 
           Summary: [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p
                    (stmt)
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: tbm at cyrius dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[tbm at cyrius dot com]

------- Comment #1 from tbm at cyrius dot com  2008-09-06 08:44 -------
Created an attachment (id=16240)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16240&action=view)
Preprocessed code


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[tbm at cyrius dot com]

------- Comment #2 from tbm at cyrius dot com  2008-09-06 08:45 -------
Created an attachment (id=16241)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16241&action=view)
Slightly reduced testcase


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[pinskia at gcc dot gnu dot org]

-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
            Summary|[4.4 Regression] Segfault in|[4.4 Regression] Segfault in
                   |verify_ssa: !gimple_nop_p   |verify_ssa: !gimple_nop_p
                   |(stmt)                      |(stmt)
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[pinskia at gcc dot gnu dot org]

------- Comment #3 from pinskia at gcc dot gnu dot org  2008-09-06 22:27 -------
Reduced testcase:
typedef struct
{
  unsigned char r, g, b;
}
rgb_color;
typedef union
{
  rgb_color rgb;
  unsigned char channel[4];
}
i_color;
struct i_fill_image_t
{
  double matrix[9];
};
static i_color
interp_i_color (i_color before, i_color after, double pos)
{
  i_color out;
  int ch;
  for (ch = 0; ch < 10; ++ch)
    out.channel[ch] = (1 - pos) * before.channel[ch] * after.channel[ch] ;
  if (out.channel[3])
    for (ch = 0; ch < 10; ++ch)
      if (ch != 3)
      {
        int temp = out.channel[ch] * 255 / out.channel[3];
        if (temp > 255)
          temp = 255;
      }
  return out;
}
void fill_image (  i_color * data )
{
  struct i_fill_image_t *f ;
  i_color *out = data;
  double rx = f->matrix[0];
  double ry = f->matrix[5];
  i_color c[2][2];
  i_color c2[2];
  int dy = 0;
  for (dy = 0; dy < 2; ++dy)
    c2[dy] = interp_i_color (c[dy][0], c[dy][1], rx);
  *out++ = interp_i_color (c2[0], c2[1], ry);
}

-- CUT --
It looks like inlining that is causing some SSA to have a NULL def statement.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu dot
                   |                            |org
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|0000-00-00 00:00:00         |2008-09-06 22:27:54
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[pinskia at gcc dot gnu dot org]

------- Comment #4 from pinskia at gcc dot gnu dot org  2008-09-06 22:48 -------
This works now with revision 140075.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2008-09-06 22:49 -------
I want to say part of the fix for PR 14703 fixed this bug.
Honza could you look into this bug?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[jsm28 at gcc dot gnu dot org]

-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[tbm at cyrius dot com]

------- Comment #6 from tbm at cyrius dot com  2008-09-12 05:28 -------
(In reply to comment #4)
> This works now with revision 140075.

Maybe the reduced one works now, but the original preprocessed source
still shows the problem.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[hubicka at gcc dot gnu dot org]

------- Comment #7 from hubicka at gcc dot gnu dot org  2008-09-12 09:52 -------
Testing patch..


-- 

hubicka at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |hubicka at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-09-06 22:27:54         |2008-09-12 09:52:53
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[hubicka at gcc dot gnu dot org]

------- Comment #8 from hubicka at gcc dot gnu dot org  2008-09-13 14:39 -------
Subject: Bug 37392

Author: hubicka
Date: Sat Sep 13 14:38:10 2008
New Revision: 140342

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=140342
Log:
        PR tree-optimization/37392
        * tree-inline.c (remap_gimple_stmt): Do not remap return value.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-inline.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392

[Bug tree-optimization/37392] [4.4 Regression] Segfault in verify_ssa: !gimple_nop_p (stmt)

[hubicka at gcc dot gnu dot org]

------- Comment #9 from hubicka at gcc dot gnu dot org  2008-09-13 22:38 -------
Fixed by my patch.


-- 

hubicka at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37392