public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/37447]  New: test pr28982b.c fails execution on power4 or later with ira change
@ 2008-09-09 18:05 janis at gcc dot gnu dot org
  2008-09-09 18:23 ` [Bug target/37447] [4.4 Regression] " pinskia at gcc dot gnu dot org
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: janis at gcc dot gnu dot org @ 2008-09-09 18:05 UTC (permalink / raw)
  To: gcc-bugs

Test gcc.c-torture/execute/pr28982b.c started failing execution for all -O2 and
-O3 options on powerpc64-linux with -m32 with this patch:

    http://gcc.gnu.org/viewcvs?view=rev&rev=139993

    r139993 | rsandifo | 2008-09-04 18:47:35 +0000 (Thu, 04 Sep 2008)

It still fails as of r140162.  The test passes with a powerpc-linux compiler
with default cpu options but fails with -mcpu=power4 or later.


-- 
           Summary: test pr28982b.c fails execution on power4 or later with
                    ira change
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: janis at gcc dot gnu dot org
GCC target triplet: powerpc-unknown-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug target/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
@ 2008-09-09 18:23 ` pinskia at gcc dot gnu dot org
  2008-09-09 18:23 ` [Bug middle-end/37447] " pinskia at gcc dot gnu dot org
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-09-09 18:23 UTC (permalink / raw)
  To: gcc-bugs



-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Severity|normal                      |major
           Keywords|                            |ra
            Summary|test pr28982b.c fails       |[4.4 Regression] test
                   |execution on power4 or later|pr28982b.c fails execution
                   |with ira change             |on power4 or later with ira
                   |                            |change
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
  2008-09-09 18:23 ` [Bug target/37447] [4.4 Regression] " pinskia at gcc dot gnu dot org
@ 2008-09-09 18:23 ` pinskia at gcc dot gnu dot org
  2008-09-09 18:24 ` pinskia at gcc dot gnu dot org
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-09-09 18:23 UTC (permalink / raw)
  To: gcc-bugs



-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |blocker
          Component|target                      |middle-end


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
  2008-09-09 18:23 ` [Bug target/37447] [4.4 Regression] " pinskia at gcc dot gnu dot org
  2008-09-09 18:23 ` [Bug middle-end/37447] " pinskia at gcc dot gnu dot org
@ 2008-09-09 18:24 ` pinskia at gcc dot gnu dot org
  2008-09-09 20:44 ` jsm28 at gcc dot gnu dot org
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2008-09-09 18:24 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #1 from pinskia at gcc dot gnu dot org  2008-09-09 18:23 -------
Confirmed, I see it too.  I configure GCC with --with-tune=cell.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
 GCC target triplet|powerpc-unknown-linux-gnu   |powerpc*-unknown-linux-gnu
   Last reconfirmed|0000-00-00 00:00:00         |2008-09-09 18:23:20
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2008-09-09 18:24 ` pinskia at gcc dot gnu dot org
@ 2008-09-09 20:44 ` jsm28 at gcc dot gnu dot org
  2008-09-10 15:16 ` bergner at gcc dot gnu dot org
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: jsm28 at gcc dot gnu dot org @ 2008-09-09 20:44 UTC (permalink / raw)
  To: gcc-bugs



-- 

jsm28 at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (3 preceding siblings ...)
  2008-09-09 20:44 ` jsm28 at gcc dot gnu dot org
@ 2008-09-10 15:16 ` bergner at gcc dot gnu dot org
  2008-10-01 23:11 ` rth at gcc dot gnu dot org
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu dot org @ 2008-09-10 15:16 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #2 from bergner at gcc dot gnu dot org  2008-09-10 15:14 -------
With a mainline from today, it fails for me at -O2.  Looking into it, it's
foo() that is miscompiled (I broke the 3 functions into their own files and
recompiled them),  It's also the last element of results (ie, results[19] that
miscompares (141 versus expected value of 190).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (4 preceding siblings ...)
  2008-09-10 15:16 ` bergner at gcc dot gnu dot org
@ 2008-10-01 23:11 ` rth at gcc dot gnu dot org
  2008-10-01 23:21 ` rth at gcc dot gnu dot org
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: rth at gcc dot gnu dot org @ 2008-10-01 23:11 UTC (permalink / raw)
  To: gcc-bugs



-- 

rth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rth at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-09-09 18:23:20         |2008-10-01 23:10:20
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (5 preceding siblings ...)
  2008-10-01 23:11 ` rth at gcc dot gnu dot org
@ 2008-10-01 23:21 ` rth at gcc dot gnu dot org
  2008-10-02  0:22 ` janis at gcc dot gnu dot org
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: rth at gcc dot gnu dot org @ 2008-10-01 23:21 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #3 from rth at gcc dot gnu dot org  2008-10-01 23:19 -------
Created an attachment (id=16446)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16446&action=view)
proposed patch

Please try this and see if it works.  I believe it does, since I see

-       stw 21,16(9)
-       addis 21,1,0x8
[lots of code]
+       stw 21,16(9)
+       addis 21,1,0x8

which suggests that the memory store hasn't been promoted
above where it ought.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (6 preceding siblings ...)
  2008-10-01 23:21 ` rth at gcc dot gnu dot org
@ 2008-10-02  0:22 ` janis at gcc dot gnu dot org
  2008-10-02  1:45 ` luisgpm at linux dot vnet dot ibm dot com
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: janis at gcc dot gnu dot org @ 2008-10-02  0:22 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #4 from janis at gcc dot gnu dot org  2008-10-02 00:21 -------
The test passes with a simple build of gcc with the patch from comment#3.  I
fired off a bootstrap and testsuite run.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (7 preceding siblings ...)
  2008-10-02  0:22 ` janis at gcc dot gnu dot org
@ 2008-10-02  1:45 ` luisgpm at linux dot vnet dot ibm dot com
  2008-10-02 11:29 ` amonakov at gcc dot gnu dot org
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: luisgpm at linux dot vnet dot ibm dot com @ 2008-10-02  1:45 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #5 from luisgpm at linux dot vnet dot ibm dot com  2008-10-02 01:43 -------
This problem also showed up as a CPU2000 regression in the Sixtrack benchmark
for PPC64, causing problems in the ondering of ld/st instructions.

A GCC patched with Richard's fix produced the right code and the regression is
gone.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (8 preceding siblings ...)
  2008-10-02  1:45 ` luisgpm at linux dot vnet dot ibm dot com
@ 2008-10-02 11:29 ` amonakov at gcc dot gnu dot org
  2008-10-02 16:24 ` janis at gcc dot gnu dot org
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: amonakov at gcc dot gnu dot org @ 2008-10-02 11:29 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #6 from amonakov at gcc dot gnu dot org  2008-10-02 11:27 -------
This patch also fixes miscompilation of vla1.f90 test on ia64 on sel-sched
branch.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (9 preceding siblings ...)
  2008-10-02 11:29 ` amonakov at gcc dot gnu dot org
@ 2008-10-02 16:24 ` janis at gcc dot gnu dot org
  2008-10-12 20:28 ` rth at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: janis at gcc dot gnu dot org @ 2008-10-02 16:24 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #7 from janis at gcc dot gnu dot org  2008-10-02 16:22 -------
The patch from comment #3 passes bootstrap and regtests on powerpc64-linux.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (11 preceding siblings ...)
  2008-10-12 20:28 ` rth at gcc dot gnu dot org
@ 2008-10-12 20:28 ` rth at gcc dot gnu dot org
  2008-10-12 21:47 ` hjl at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: rth at gcc dot gnu dot org @ 2008-10-12 20:28 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #9 from rth at gcc dot gnu dot org  2008-10-12 20:27 -------
Subject: Bug 37447

Author: rth
Date: Sun Oct 12 20:26:24 2008
New Revision: 141077

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141077
Log:
        PR middle-end/37447
        * Makefile.in (reload1.o): Depend on EMIT_RTL_H.
        * alias.c (value_addr_p, stack_addr_p): Remove.
        (nonoverlapping_memrefs_p): Remove IRA special case.
        * emit-rtl.c (get_spill_slot_decl, set_mem_attrs_for_spill): New.
        * emit-rtl.h (set_mem_attrs_for_spill): Declare.
        * reload1.c (alter_reg): Use it.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/alias.c
    trunk/gcc/emit-rtl.c
    trunk/gcc/emit-rtl.h
    trunk/gcc/reload1.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (10 preceding siblings ...)
  2008-10-02 16:24 ` janis at gcc dot gnu dot org
@ 2008-10-12 20:28 ` rth at gcc dot gnu dot org
  2008-10-12 20:28 ` rth at gcc dot gnu dot org
  2008-10-12 21:47 ` hjl at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: rth at gcc dot gnu dot org @ 2008-10-12 20:28 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #8 from rth at gcc dot gnu dot org  2008-10-12 20:27 -------
Fixed.


-- 

rth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug middle-end/37447] [4.4 Regression] test pr28982b.c fails execution on power4 or later with ira change
  2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
                   ` (12 preceding siblings ...)
  2008-10-12 20:28 ` rth at gcc dot gnu dot org
@ 2008-10-12 21:47 ` hjl at gcc dot gnu dot org
  13 siblings, 0 replies; 15+ messages in thread
From: hjl at gcc dot gnu dot org @ 2008-10-12 21:47 UTC (permalink / raw)
  To: gcc-bugs



------- Comment #10 from hjl at gcc dot gnu dot org  2008-10-12 21:45 -------
Subject: Bug 37447

Author: hjl
Date: Sun Oct 12 21:44:33 2008
New Revision: 141079

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141079
Log:
2008-10-12  H.J. Lu  <hongjiu.lu@intel.com>

        Backport from mainline:
        2008-10-12  Richard Henderson  <rth@redhat.com>

        PR middle-end/37447
        * Makefile.in (reload1.o): Depend on EMIT_RTL_H.
        * alias.c (value_addr_p, stack_addr_p): Remove.
        (nonoverlapping_memrefs_p): Remove IRA special case.
        * emit-rtl.c (get_spill_slot_decl, set_mem_attrs_for_spill): New.
        * emit-rtl.h (set_mem_attrs_for_spill): Declare.
        * reload1.c (alter_reg): Use it.

Modified:
    branches/ira-merge/gcc/ChangeLog.ira
    branches/ira-merge/gcc/Makefile.in
    branches/ira-merge/gcc/alias.c
    branches/ira-merge/gcc/emit-rtl.c
    branches/ira-merge/gcc/emit-rtl.h
    branches/ira-merge/gcc/reload1.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37447


^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2008-10-12 21:47 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-09 18:05 [Bug target/37447] New: test pr28982b.c fails execution on power4 or later with ira change janis at gcc dot gnu dot org
2008-09-09 18:23 ` [Bug target/37447] [4.4 Regression] " pinskia at gcc dot gnu dot org
2008-09-09 18:23 ` [Bug middle-end/37447] " pinskia at gcc dot gnu dot org
2008-09-09 18:24 ` pinskia at gcc dot gnu dot org
2008-09-09 20:44 ` jsm28 at gcc dot gnu dot org
2008-09-10 15:16 ` bergner at gcc dot gnu dot org
2008-10-01 23:11 ` rth at gcc dot gnu dot org
2008-10-01 23:21 ` rth at gcc dot gnu dot org
2008-10-02  0:22 ` janis at gcc dot gnu dot org
2008-10-02  1:45 ` luisgpm at linux dot vnet dot ibm dot com
2008-10-02 11:29 ` amonakov at gcc dot gnu dot org
2008-10-02 16:24 ` janis at gcc dot gnu dot org
2008-10-12 20:28 ` rth at gcc dot gnu dot org
2008-10-12 20:28 ` rth at gcc dot gnu dot org
2008-10-12 21:47 ` hjl at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).