[Bug target/37815] New: [4.4] ICE in vt_add_function_parameters (bootstrap error)

[Bug target/37815] New: [4.4] ICE in vt_add_function_parameters (bootstrap error)

[doko at ubuntu dot com]

seen with r141079 on the trunk, not with r141071

/build/buildd/gcc-snapshot-20081012/build/./gcc/xgcc
-B/build/buildd/gcc-snapshot-20081012/build/./gcc/
-B/usr/lib/gcc-snapshot/sparc-linux-gnu/bin/
-B/usr/lib/gcc-snapshot/sparc-linux-gnu/lib/ -isystem
/usr/lib/gcc-snapshot/sparc-linux-gnu/include -isystem
/usr/lib/gcc-snapshot/sparc-linux-gnu/sys-include -g -O2 -O2  -g -O2 -DIN_GCC  
-W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wcast-qual
-Wold-style-definition  -isystem ./include  -fPIC -g -DHAVE_GTHR_DEFAULT
-DIN_LIBGCC2 -D__GCC_FLOAT_NOT_NEEDED   -I. -I. -I../.././gcc
-I../../../src/libgcc -I../../../src/libgcc/. -I../../../src/libgcc/../gcc
-I../../../src/libgcc/../include  -DHAVE_CC_TLS -o _divtc3.o -MT _divtc3.o -MD
-MP -MF _divtc3.dep -DL_divtc3 -c ../../../src/libgcc/../gcc/libgcc2.c \
          -fvisibility=hidden -DHIDE_EXPORTS
../../../src/libgcc/../gcc/libgcc2.c: In function '__divtc3':
../../../src/libgcc/../gcc/libgcc2.c:1946: internal compiler error: in
vt_add_function_parameters, at var-tracking.c:3176
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-snapshot/README.Bugs> for instructions.
make[5]: *** [_divtc3.o] Error 1
make[5]: Leaving directory
`/build/buildd/gcc-snapshot-20081012/build/sparc-linux-gnu/libgcc'
make[4]: *** [all-stage1-target-libgcc] Error 2
make[4]: Leaving directory `/build/buildd/gcc-snapshot-20081012/build'
make[3]: *** [stage1-bubble] Error 2
make[3]: Leaving directory `/build/buildd/gcc-snapshot-20081012/build'
make[2]: *** [bootstrap-lean] Error 2

configured as a biarch compiler:
../src/configure  --enable-targets=all --with-cpu=v8 --with-long-double-128
--build=sparc-linux-gnu --host=sparc-linux-gnu --target=sparc-linux-gnu


-- 
           Summary: [4.4] ICE in vt_add_function_parameters (bootstrap
                    error)
           Product: gcc
           Version: 4.4.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: doko at ubuntu dot com
GCC target triplet: sparc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2008-10-13 19:35 -------
I get the same ICE for a few testcases in libstdc++ on powerpc-linux-gnu:
+FAIL: 25_algorithms/replace_copy_if/requirements/explicit_instantiation/pod.cc
(test for excess errors)
+FAIL: 25_algorithms/replace_if/requirements/explicit_instantiation/pod.cc
(test for excess errors)
+FAIL: 25_algorithms/stable_partition/requirements/explicit_instantiation/2.cc
(test for excess errors)
+FAIL:
25_algorithms/stable_partition/requirements/explicit_instantiation/pod.cc (test
for excess errors)

/home/apinski/src/local/gcc/objdir/powerpc64-unknown-linux-gnu/libstdc++-v3/include/bits/stl_algo.h:
In function 'void std::replace_if(_FIter, _FIter, _Predicate, const _Tp&) [with
_FIter = std::value_type*, _Predicate = std::predicate_type, _Tp =
std::value_type]':^M
/home/apinski/src/local/gcc/objdir/powerpc64-unknown-linux-gnu/libstdc++-v3/include/bits/stl_algo.h:4751:
internal compiler error: in vt_add_function_parameters, at
var-tracking.c:3176^M
Please submit a full bug report,^M
with preprocessed source if appropriate.^M
See <http://gcc.gnu.org/bugs.html> for instructions.^M
compiler exited with status 1


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org
           Severity|normal                      |blocker
          Component|target                      |middle-end
           Keywords|                            |build, ice-on-valid-code
            Summary|[4.4] ICE in                |[4.4 Regression] ICE in
                   |vt_add_function_parameters  |vt_add_function_parameters
                   |(bootstrap error)           |(bootstrap error)
   Target Milestone|---                         |4.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[andreast at gcc dot gnu dot org]

------- Comment #2 from andreast at gcc dot gnu dot org  2008-10-13 19:48 -------
sparc-solaris2.10 too, same pattern as on sparc-linux.
r141076 with r141078 build was ok.
r141077 with r141078 fails.


-- 

andreast at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2008-10-13 19:48:06
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[doko at ubuntu dot com]

------- Comment #3 from doko at ubuntu dot com  2008-10-14 07:21 -------
reverting r141077 on current trunk lets the bootstrap succeed on sparc-linux


-- 

doko at ubuntu dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[jakub at gcc dot gnu dot org]

------- Comment #4 from jakub at gcc dot gnu dot org  2008-10-14 11:25 -------
Created an attachment (id=16491)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16491&action=view)
libgcc2.i

Indeed, caused by r141077.  On the attached preprocessed source reproduceable
with -> sparc-linux cross with -g -O{1,2}.  The RTL dump with/without r141077
is identical until ira, then a bunch of stack slots are shared differently.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[jakub at gcc dot gnu dot org]

------- Comment #5 from jakub at gcc dot gnu dot org  2008-10-14 11:47 -------
vt_add_function_parameters asserts that REG_EXPR or MEM_EXPR of DECL_RTL of a
PARM decl, if it is non-NULL, is the PARM_DECL itself, but with the r141077
patch when the stack slots may be shared, decl might be actually
spill_slot_decl.
Not sure how should var-tracking.c figure out where the stack slot is still
used for the PARM_DECL and where it starts holding something else.
On this libgcc2.i sparc testcase the stack slot in question (fp-176) is used
first as c (one of PARM_DECLs) and after a while as c.49 (VAR_DECL).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[ktietz at gcc dot gnu dot org]

------- Comment #6 from ktietz at gcc dot gnu dot org  2008-10-17 12:25 -------
For target x86_64-pc-mingw32 it is the same

In file included from
/vol/d/sources/gcc_new/gcc_1017/build3/x86_64-pc-mingw32/libstdc++-v3/include/ostream:572,
                 from ../../../../libstdc++-v3/src/ostream-inst.cc:35:
/vol/d/sources/gcc_new/gcc_1017/build3/x86_64-pc-mingw32/libstdc++-v3/include/bits/ostream.tcc:
In member function 'std:
:basic_ostream<_CharT, _Traits>& std::basic_ostream<_CharT,
_Traits>::_M_insert(_ValueT) [with _ValueT = long double, _C
harT = char, _Traits = std::char_traits<char>]':
/vol/d/sources/gcc_new/gcc_1017/build3/x86_64-pc-mingw32/libstdc++-v3/include/bits/ostream.tcc:92:
internal compiler err
or: in vt_add_function_parameters, at var-tracking.c:3176
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[krebbel at gcc dot gnu dot org]

------- Comment #7 from krebbel at gcc dot gnu dot org  2008-10-17 13:16 -------
Same on s390x:
http://gcc.gnu.org/ml/gcc-patches/2008-10/msg00740.html

Please note that the patch attached to the email most likely isn't a correct
solution.


-- 

krebbel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krebbel at gcc dot gnu dot
                   |                            |org
   Last reconfirmed|2008-10-13 19:48:06         |2008-10-17 13:16:23
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[joel at gcc dot gnu dot org]

------- Comment #8 from joel at gcc dot gnu dot org  2008-10-17 15:44 -------
Also happens on powerpc-rtems4.10

+===========================GNAT BUG DETECTED==============================+
| 4.4.0 20081014 (experimental) [trunk revision 141108]
(powerpc-unknown-rtems4.10) GCC error:|
| in vt_add_function_parameters, at var-tracking.c:3176                    |
| Error detected around a-clrefi.adb:526                                   |


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[joel at gcc dot gnu dot org]

------- Comment #9 from joel at gcc dot gnu dot org  2008-10-17 15:45 -------
*** Bug 37840 has been marked as a duplicate of this bug. ***


-- 

joel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joel at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[rth at gcc dot gnu dot org]

-- 

rth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rth at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED
   Last reconfirmed|2008-10-17 13:16:23         |2008-10-17 15:56:19
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[rth at gcc dot gnu dot org]

------- Comment #10 from rth at gcc dot gnu dot org  2008-10-17 16:40 -------
Created an attachment (id=16513)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16513&action=view)
proposed patch

I'm pretty sure this patch is sufficient to return this function to working
order.
I'll have a look at the rest of var-tracking and see where else ought to be 
modified to ignore spill_slot_decl.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[andreast at gcc dot gnu dot org]

------- Comment #11 from andreast at gcc dot gnu dot org  2008-10-17 20:59 -------
Entered in testing part on sparc-solaris2.10

Bootstrap ok. with patch in comment #10


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[andreast at gcc dot gnu dot org]

------- Comment #12 from andreast at gcc dot gnu dot org  2008-10-18 18:22 -------
results here: http://gcc.gnu.org/ml/gcc-testresults/2008-10/msg01245.html
and here: http://gcc.gnu.org/ml/gcc-testresults/2008-10/msg01246.html


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[rth at gcc dot gnu dot org]

------- Comment #13 from rth at gcc dot gnu dot org  2008-10-21 20:49 -------
Subject: Bug 37815

Author: rth
Date: Tue Oct 21 20:48:16 2008
New Revision: 141278

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141278
Log:
        PR 37815
        * emit-rtl.c (get_spill_slot_decl): Export.
        * emit-rtl.h (get_spill_slot_decl): Declare.
        * var-tracking.c (vt_add_function_parameters): Relax assertion
        on the contents of MEM_EXPR in a PARM_DECL to include a spill slot.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/emit-rtl.c
    trunk/gcc/emit-rtl.h
    trunk/gcc/var-tracking.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[hjl at gcc dot gnu dot org]

------- Comment #14 from hjl at gcc dot gnu dot org  2008-10-22 00:22 -------
Subject: Bug 37815

Author: hjl
Date: Wed Oct 22 00:21:41 2008
New Revision: 141288

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=141288
Log:
2008-10-21  H.J. Lu  <hongjiu.lu@intel.com>

        Backport from mainline:
        2008-10-21  Richard Henderson  <rth@redhat.com>

        PR 37815
        * emit-rtl.c (get_spill_slot_decl): Export.
        * emit-rtl.h (get_spill_slot_decl): Declare.
        * var-tracking.c (vt_add_function_parameters): Relax assertion
        on the contents of MEM_EXPR in a PARM_DECL to include a spill slot.

Modified:
    branches/ira-merge/gcc/ChangeLog.ira
    branches/ira-merge/gcc/emit-rtl.c
    branches/ira-merge/gcc/emit-rtl.h
    branches/ira-merge/gcc/var-tracking.c


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[rth at gcc dot gnu dot org]

------- Comment #15 from rth at gcc dot gnu dot org  2008-10-22 00:46 -------
Fixed.


-- 

rth at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815

[Bug middle-end/37815] [4.4 Regression] ICE in vt_add_function_parameters (bootstrap error)

[pinskia at gcc dot gnu dot org]

------- Comment #16 from pinskia at gcc dot gnu dot org  2008-10-24 21:36 -------
Verified fixes the PPC GNU/Linux libstdc++ failures that I was receiving too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37815